Re: svn commit: r1657514 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

[Gil Portenseigne]

Hi Jacopo,

I'm not sure if its on purpose but you commit some dev warning logs : (italian words made me wonder :) ) :

Le 05/02/2015 10:26, [hidden email] a écrit :

+            <log level="warning" message="APPLICAZIONI"/>
+            <iterate list="paymentApplications" entry="paymentApplication">
+                <log level="warning" message="applicazione ${paymentApplication}"/>
+                <get-related-one value-field="paymentApplication" relation-name="Payment" to-value-field="payment"/>
+                <log level="warning" message="payment ${payment}"/>
+                <if>
+                    <condition>
+                        <or>
+                            <if-compare field="payment.statusId" operator="equals" value="PMNT_SENT"/>
+                            <if-compare field="payment.statusId" operator="equals" value="PMNT_CONFIRMED"/>
+                        </or>
+                    </condition>
+                    <then>
+                        <log level="warning" message="processing payment ${payment.paymentId}"/>
+                        <set field="createAcctgTransAndEntriesForPaymentApplicationInMap.paymentApplicationId" from-field="paymentApplication.paymentApplicationId"/>
+                        <if-compare field="payment.paymentTypeId" operator="equals" value="CUSTOMER_REFUND">
+                            <call-service service-name="createAcctgTransAndEntriesForCustomerRefundPaymentApplication" in-map-name="createAcctgTransAndEntriesForPaymentApplicationInMap">
+                                <result-to-field result-name="acctgTransId"/>
+                            </call-service>
+                        <else>
+                            <call-service service-name="createAcctgTransAndEntriesForPaymentApplication" in-map-name="createAcctgTransAndEntriesForPaymentApplicationInMap">
+                                <result-to-field result-name="acctgTransId"/>
+                            </call-service>
+                        </else>
+                        </if-compare>
+                        <log level="info" message="Accounting transaction ${acctgTransId} created for payment application ${paymentApplication.paymentApplicationId}"/>
+                    </then>
+                </if>
+            </iterate>
         </if-compare>
     </simple-method>

[Jacopo Cappellato-4]

Hi Gil,

thank you for the review! I have removed them in rev. 1657848

Jacopo

On Feb 6, 2015, at 8:28 PM, gil portenseigne <[hidden email]> wrote:

> Hi Jacopo,
>
> I'm not sure if its on purpose but you commit some dev warning logs : (italian words made me wonder :) ) :
>
> Le 05/02/2015 10:26, [hidden email] a écrit :
>> +            <log level="warning" message="APPLICAZIONI"/>
>> +            <iterate list="paymentApplications" entry="paymentApplication">
>> +                <log level="warning" message="applicazione ${paymentApplication}"/>
>> +                <get-related-one value-field="paymentApplication" relation-name="Payment" to-value-field="payment"/>
>> +                <log level="warning" message="payment ${payment}"/>
>> +                <if>
>> +                    <condition>
>> +                        <or>
>> +                            <if-compare field="payment.statusId" operator="equals" value="PMNT_SENT"/>
>> +                            <if-compare field="payment.statusId" operator="equals" value="PMNT_CONFIRMED"/>
>> +                        </or>
>> +                    </condition>
>> +                    <then>
>> +                        <log level="warning" message="processing payment ${payment.paymentId}"/>
>> +                        <set field="createAcctgTransAndEntriesForPaymentApplicationInMap.paymentApplicationId" from-field="paymentApplication.paymentApplicationId"/>
>> +                        <if-compare field="payment.paymentTypeId" operator="equals" value="CUSTOMER_REFUND">
>> +                            <call-service service-name="createAcctgTransAndEntriesForCustomerRefundPaymentApplication" in-map-name="createAcctgTransAndEntriesForPaymentApplicationInMap">
>> +                                <result-to-field result-name="acctgTransId"/>
>> +                            </call-service>
>> +                        <else>
>> +                            <call-service service-name="createAcctgTransAndEntriesForPaymentApplication" in-map-name="createAcctgTransAndEntriesForPaymentApplicationInMap">
>> +                                <result-to-field result-name="acctgTransId"/>
>> +                            </call-service>
>> +                        </else>
>> +                        </if-compare>
>> +                        <log level="info" message="Accounting transaction ${acctgTransId} created for payment application ${paymentApplication.paymentApplicationId}"/>
>> +                    </then>
>> +                </if>
>> +            </iterate>
>>          </if-compare>
>>      </simple-method>
>>
>>
>