OFBiz › OFBiz - Dev

Re: svn commit: r1662393 - in /ofbiz/trunk/framework: webapp/src/org/ofbiz/webapp/control/ContextFilter.java webtools/webapp/webtools/WEB-INF/web.xml

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1662393 - in /ofbiz/trunk/framework: webapp/src/org/ofbiz/webapp/control/ContextFilter.java webtools/webapp/webtools/WEB-INF/web.xml

Jacques Le Roux
Administrator
It was used by https://cwiki.apache.org/confluence/display/OFBIZ/Geronimo+and+IBM+Websphere+Application+Server+Community+Edition and R4.0

I guess nobody is indeed now using this. Even then, it was more an internal company political affair anyway, was fun though.

Jacques

Le 26/02/2015 10:09, [hidden email] a écrit :

> Author: jacopoc
> Date: Thu Feb 26 09:09:04 2015
> New Revision: 1662393
>
> URL: http://svn.apache.org/r1662393
> Log:
> Removed some old code that, as can be easily noticed by reviewing the lines I am removing, was completely useless; it was probably an half baked experiment that has been committed by error.
>
> Modified:
>      ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>      ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>
> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java?rev=1662393&r1=1662392&r2=1662393&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java (original)
> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java Thu Feb 26 09:09:04 2015
> @@ -407,15 +407,6 @@ public class ContextFilter implements Fi
>               if (Debug.verboseOn()) Debug.logVerbose("Adding web.xml context-param to application attribute with name [" + initParamName + "] and value [" + initParamValue + "]", module);
>               config.getServletContext().setAttribute(initParamName, initParamValue);
>           }
> -        String GeronimoMultiOfbizInstances = (String) config.getServletContext().getAttribute("GeronimoMultiOfbizInstances");
> -        if (UtilValidate.isNotEmpty(GeronimoMultiOfbizInstances)) {
> -            String ofbizHome = System.getProperty("ofbiz.home");
> -            if (GeronimoMultiOfbizInstances.equalsIgnoreCase("true") && UtilValidate.isEmpty(ofbizHome)) {
> -                ofbizHome = System.getProperty("ofbiz.home"); // This is only used in case of Geronimo or WASCE using OFBiz multi-instances. It allows to retrieve ofbiz.home value set in JVM env
> -                System.out.println("Set OFBIZ_HOME to - " + ofbizHome);
> -                System.setProperty("ofbiz.home", ofbizHome);
> -            }
> -        }
>       }
>  
>       protected String getServerId() {
>
> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml?rev=1662393&r1=1662392&r2=1662393&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml (original)
> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml Thu Feb 26 09:09:04 2015
> @@ -44,12 +44,6 @@ under the License.
>       <description>The location of the main-decorator screen to use for this webapp; referred to as a context variable in screen def XML files.</description>
>     </context-param>
>  
> -  <context-param>
> -    <param-name>GeronimoMultiOfbizInstances</param-name>
> -    <param-value>true</param-value>
> -    <description>This is only used in case of Geronimo or WASCE using OFBiz multi-instances. It allows to retrieve ofbiz.home value set in JVM env</description>
> -  </context-param>
> -
>       <filter>
>           <filter-name>ContextFilter</filter-name>
>           <display-name>ContextFilter</display-name>
>
>
>
Pierre Smits
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1662393 - in /ofbiz/trunk/framework: webapp/src/org/ofbiz/webapp/control/ContextFilter.java webtools/webapp/webtools/WEB-INF/web.xml

Pierre Smits
That must be related to the functionality in the appserver component?

Best regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Thu, Feb 26, 2015 at 10:29 AM, Jacques Le Roux <
[hidden email]> wrote:

> It was used by https://cwiki.apache.org/confluence/display/OFBIZ/
> Geronimo+and+IBM+Websphere+Application+Server+Community+Edition and R4.0
>
> I guess nobody is indeed now using this. Even then, it was more an
> internal company political affair anyway, was fun though.
>
> Jacques
>
> Le 26/02/2015 10:09, [hidden email] a écrit :
>
>  Author: jacopoc
>> Date: Thu Feb 26 09:09:04 2015
>> New Revision: 1662393
>>
>> URL: http://svn.apache.org/r1662393
>> Log:
>> Removed some old code that, as can be easily noticed by reviewing the
>> lines I am removing, was completely useless; it was probably an half baked
>> experiment that has been committed by error.
>>
>> Modified:
>>      ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>> ContextFilter.java
>>      ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>
>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>> ContextFilter.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/
>> src/org/ofbiz/webapp/control/ContextFilter.java?rev=
>> 1662393&r1=1662392&r2=1662393&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>> (original)
>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>> Thu Feb 26 09:09:04 2015
>> @@ -407,15 +407,6 @@ public class ContextFilter implements Fi
>>               if (Debug.verboseOn()) Debug.logVerbose("Adding web.xml
>> context-param to application attribute with name [" + initParamName + "]
>> and value [" + initParamValue + "]", module);
>>               config.getServletContext().setAttribute(initParamName,
>> initParamValue);
>>           }
>> -        String GeronimoMultiOfbizInstances = (String)
>> config.getServletContext().getAttribute("GeronimoMultiOfbizInstances");
>> -        if (UtilValidate.isNotEmpty(GeronimoMultiOfbizInstances)) {
>> -            String ofbizHome = System.getProperty("ofbiz.home");
>> -            if (GeronimoMultiOfbizInstances.equalsIgnoreCase("true") &&
>> UtilValidate.isEmpty(ofbizHome)) {
>> -                ofbizHome = System.getProperty("ofbiz.home"); // This
>> is only used in case of Geronimo or WASCE using OFBiz multi-instances. It
>> allows to retrieve ofbiz.home value set in JVM env
>> -                System.out.println("Set OFBIZ_HOME to - " + ofbizHome);
>> -                System.setProperty("ofbiz.home", ofbizHome);
>> -            }
>> -        }
>>       }
>>         protected String getServerId() {
>>
>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/
>> webtools/webapp/webtools/WEB-INF/web.xml?rev=1662393&r1=
>> 1662392&r2=1662393&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>> (original)
>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml Thu
>> Feb 26 09:09:04 2015
>> @@ -44,12 +44,6 @@ under the License.
>>       <description>The location of the main-decorator screen to use for
>> this webapp; referred to as a context variable in screen def XML
>> files.</description>
>>     </context-param>
>>   -  <context-param>
>> -    <param-name>GeronimoMultiOfbizInstances</param-name>
>> -    <param-value>true</param-value>
>> -    <description>This is only used in case of Geronimo or WASCE using
>> OFBiz multi-instances. It allows to retrieve ofbiz.home value set in JVM
>> env</description>
>> -  </context-param>
>> -
>>       <filter>
>>           <filter-name>ContextFilter</filter-name>
>>           <display-name>ContextFilter</display-name>
>>
>>
>>
>>
Jacopo Cappellato-5
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1662393 - in /ofbiz/trunk/framework: webapp/src/org/ofbiz/webapp/control/ContextFilter.java webtools/webapp/webtools/WEB-INF/web.xml

Jacopo Cappellato-5
Jacques, Pierre,

if you look at the code I have removed, that simplified is:

            String ofbizHome = System.getProperty("ofbiz.home");
            if (UtilValidate.isEmpty(ofbizHome)) {
                ofbizHome = System.getProperty("ofbiz.home");
                System.setProperty("ofbiz.home", ofbizHome);
            }

you will see that it is completely meaningless.

Jacopo


On Feb 26, 2015, at 10:35 AM, Pierre Smits <[hidden email]> wrote:

> That must be related to the functionality in the appserver component?
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Thu, Feb 26, 2015 at 10:29 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> It was used by https://cwiki.apache.org/confluence/display/OFBIZ/
>> Geronimo+and+IBM+Websphere+Application+Server+Community+Edition and R4.0
>>
>> I guess nobody is indeed now using this. Even then, it was more an
>> internal company political affair anyway, was fun though.
>>
>> Jacques
>>
>> Le 26/02/2015 10:09, [hidden email] a écrit :
>>
>> Author: jacopoc
>>> Date: Thu Feb 26 09:09:04 2015
>>> New Revision: 1662393
>>>
>>> URL: http://svn.apache.org/r1662393
>>> Log:
>>> Removed some old code that, as can be easily noticed by reviewing the
>>> lines I am removing, was completely useless; it was probably an half baked
>>> experiment that has been committed by error.
>>>
>>> Modified:
>>>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>>> ContextFilter.java
>>>     ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>
>>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>>> ContextFilter.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/
>>> src/org/ofbiz/webapp/control/ContextFilter.java?rev=
>>> 1662393&r1=1662392&r2=1662393&view=diff
>>> ============================================================
>>> ==================
>>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>>> (original)
>>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>>> Thu Feb 26 09:09:04 2015
>>> @@ -407,15 +407,6 @@ public class ContextFilter implements Fi
>>>              if (Debug.verboseOn()) Debug.logVerbose("Adding web.xml
>>> context-param to application attribute with name [" + initParamName + "]
>>> and value [" + initParamValue + "]", module);
>>>              config.getServletContext().setAttribute(initParamName,
>>> initParamValue);
>>>          }
>>> -        String GeronimoMultiOfbizInstances = (String)
>>> config.getServletContext().getAttribute("GeronimoMultiOfbizInstances");
>>> -        if (UtilValidate.isNotEmpty(GeronimoMultiOfbizInstances)) {
>>> -            String ofbizHome = System.getProperty("ofbiz.home");
>>> -            if (GeronimoMultiOfbizInstances.equalsIgnoreCase("true") &&
>>> UtilValidate.isEmpty(ofbizHome)) {
>>> -                ofbizHome = System.getProperty("ofbiz.home"); // This
>>> is only used in case of Geronimo or WASCE using OFBiz multi-instances. It
>>> allows to retrieve ofbiz.home value set in JVM env
>>> -                System.out.println("Set OFBIZ_HOME to - " + ofbizHome);
>>> -                System.setProperty("ofbiz.home", ofbizHome);
>>> -            }
>>> -        }
>>>      }
>>>        protected String getServerId() {
>>>
>>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/
>>> webtools/webapp/webtools/WEB-INF/web.xml?rev=1662393&r1=
>>> 1662392&r2=1662393&view=diff
>>> ============================================================
>>> ==================
>>> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>> (original)
>>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml Thu
>>> Feb 26 09:09:04 2015
>>> @@ -44,12 +44,6 @@ under the License.
>>>      <description>The location of the main-decorator screen to use for
>>> this webapp; referred to as a context variable in screen def XML
>>> files.</description>
>>>    </context-param>
>>>  -  <context-param>
>>> -    <param-name>GeronimoMultiOfbizInstances</param-name>
>>> -    <param-value>true</param-value>
>>> -    <description>This is only used in case of Geronimo or WASCE using
>>> OFBiz multi-instances. It allows to retrieve ofbiz.home value set in JVM
>>> env</description>
>>> -  </context-param>
>>> -
>>>      <filter>
>>>          <filter-name>ContextFilter</filter-name>
>>>          <display-name>ContextFilter</display-name>
>>>
>>>
>>>
>>>

Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1662393 - in /ofbiz/trunk/framework: webapp/src/org/ofbiz/webapp/control/ContextFilter.java webtools/webapp/webtools/WEB-INF/web.xml

Jacques Le Roux
Administrator
You are right Jacopo, it was part of an experiment for what I called "Multi-instances"
See same section name at https://cwiki.apache.org/confluence/display/OFBIZ/Geronimo+and+IBM+Websphere+Application+Server+Community+Edition
If you are ever interested

Jacques

Le 26/02/2015 10:52, Jacopo Cappellato a écrit :

> Jacques, Pierre,
>
> if you look at the code I have removed, that simplified is:
>
>              String ofbizHome = System.getProperty("ofbiz.home");
>              if (UtilValidate.isEmpty(ofbizHome)) {
>                  ofbizHome = System.getProperty("ofbiz.home");
>                  System.setProperty("ofbiz.home", ofbizHome);
>              }
>
> you will see that it is completely meaningless.
>
> Jacopo
>
>
> On Feb 26, 2015, at 10:35 AM, Pierre Smits <[hidden email]> wrote:
>
>> That must be related to the functionality in the appserver component?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Thu, Feb 26, 2015 at 10:29 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> It was used by https://cwiki.apache.org/confluence/display/OFBIZ/
>>> Geronimo+and+IBM+Websphere+Application+Server+Community+Edition and R4.0
>>>
>>> I guess nobody is indeed now using this. Even then, it was more an
>>> internal company political affair anyway, was fun though.
>>>
>>> Jacques
>>>
>>> Le 26/02/2015 10:09, [hidden email] a écrit :
>>>
>>> Author: jacopoc
>>>> Date: Thu Feb 26 09:09:04 2015
>>>> New Revision: 1662393
>>>>
>>>> URL: http://svn.apache.org/r1662393
>>>> Log:
>>>> Removed some old code that, as can be easily noticed by reviewing the
>>>> lines I am removing, was completely useless; it was probably an half baked
>>>> experiment that has been committed by error.
>>>>
>>>> Modified:
>>>>      ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>>>> ContextFilter.java
>>>>      ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>>
>>>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
>>>> ContextFilter.java
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/
>>>> src/org/ofbiz/webapp/control/ContextFilter.java?rev=
>>>> 1662393&r1=1662392&r2=1662393&view=diff
>>>> ============================================================
>>>> ==================
>>>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>>>> (original)
>>>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ContextFilter.java
>>>> Thu Feb 26 09:09:04 2015
>>>> @@ -407,15 +407,6 @@ public class ContextFilter implements Fi
>>>>               if (Debug.verboseOn()) Debug.logVerbose("Adding web.xml
>>>> context-param to application attribute with name [" + initParamName + "]
>>>> and value [" + initParamValue + "]", module);
>>>>               config.getServletContext().setAttribute(initParamName,
>>>> initParamValue);
>>>>           }
>>>> -        String GeronimoMultiOfbizInstances = (String)
>>>> config.getServletContext().getAttribute("GeronimoMultiOfbizInstances");
>>>> -        if (UtilValidate.isNotEmpty(GeronimoMultiOfbizInstances)) {
>>>> -            String ofbizHome = System.getProperty("ofbiz.home");
>>>> -            if (GeronimoMultiOfbizInstances.equalsIgnoreCase("true") &&
>>>> UtilValidate.isEmpty(ofbizHome)) {
>>>> -                ofbizHome = System.getProperty("ofbiz.home"); // This
>>>> is only used in case of Geronimo or WASCE using OFBiz multi-instances. It
>>>> allows to retrieve ofbiz.home value set in JVM env
>>>> -                System.out.println("Set OFBIZ_HOME to - " + ofbizHome);
>>>> -                System.setProperty("ofbiz.home", ofbizHome);
>>>> -            }
>>>> -        }
>>>>       }
>>>>         protected String getServerId() {
>>>>
>>>> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/
>>>> webtools/webapp/webtools/WEB-INF/web.xml?rev=1662393&r1=
>>>> 1662392&r2=1662393&view=diff
>>>> ============================================================
>>>> ==================
>>>> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml
>>>> (original)
>>>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/web.xml Thu
>>>> Feb 26 09:09:04 2015
>>>> @@ -44,12 +44,6 @@ under the License.
>>>>       <description>The location of the main-decorator screen to use for
>>>> this webapp; referred to as a context variable in screen def XML
>>>> files.</description>
>>>>     </context-param>
>>>>   -  <context-param>
>>>> -    <param-name>GeronimoMultiOfbizInstances</param-name>
>>>> -    <param-value>true</param-value>
>>>> -    <description>This is only used in case of Geronimo or WASCE using
>>>> OFBiz multi-instances. It allows to retrieve ofbiz.home value set in JVM
>>>> env</description>
>>>> -  </context-param>
>>>> -
>>>>       <filter>
>>>>           <filter-name>ContextFilter</filter-name>
>>>>           <display-name>ContextFilter</display-name>
>>>>
>>>>
>>>>
>>>>
>
>
Free forum by Nabble Edit this page