Re: svn commit: r1672752 [7/18] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/agreement/ applications/accounting/src/org/ofbiz/accounting/finaccount/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/sr...

[Nicolas Malin-2]

Indeed, thanks for your correction Adam, eclipse played a trick and I
didn't saw it.

Nicolas

Le 24/04/2015 23:02, Adam Heath a écrit :

> This is an example of why having a HUGE commit is wrong.  This problem
> listed below was not discovered, because there were too many changes
> to review.  My maven branch at OFBIZ-6271 is doing things in a much
> better way.
>
> ps: I discovered this because I am attempting to compile each and
> every component with no dependent jars listed, then adding back *just*
> what is required.  Any ant deps get extra attention, as they really
> shouldn't be needed.
>
> On 04/10/2015 03:22 PM, [hidden email] wrote:
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>> (original)
>> +++
>> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>> Fri Apr 10 20:22:54 2015
>> @@ -24,6 +24,7 @@ import java.util.ArrayList;
>>   import java.util.Collection;
>>   import java.util.Date;
>>   import java.util.HashMap;
>> +import java.util.HashSet;
>>   import java.util.Iterator;
>>   import java.util.LinkedList;
>>   import java.util.List;
>> @@ -35,10 +36,7 @@ import java.util.concurrent.Callable;
>>     import javax.transaction.Transaction;
>>   -import javolution.util.FastList;
>> -import javolution.util.FastMap;
>> -import javolution.util.FastSet;
>> -
>> +import org.apache.tools.ant.taskdefs.condition.HasMethod;
>
> What is this import supposed to do?  Nothing makes use of that class.
>