Re: svn commit: r1685210 - /ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch

[Pierre Smits]

Hi Gavin,

Adding a file called 'lookupField_patch.patch' to the hot-deploy stack of
the Bootstrap dev branch isn't the way to go. It doesn't do anything.

Best regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Jun 13, 2015 at 6:21 AM, <[hidden email]> wrote:

> Author: gavinmabie
> Date: Sat Jun 13 04:21:20 2015
> New Revision: 1685210
>
> URL: http://svn.apache.org/r1685210
> Log:
> Resolves OFBIZ-6452 - Lookup buttons in forms not displaying properly.
> This is linked to css in legacy.css. Comment out .field-lookup a selector
> line 2112
>
> Added:
>     ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
>
> Added: ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
> URL:
> http://svn.apache.org/viewvc/ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch?rev=1685210&view=auto
>
> ==============================================================================
> --- ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
> (added)
> +++ ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch Sat
> Jun 13 04:21:20 2015
> @@ -0,0 +1,25 @@
> +Index: legacy.css
> +===================================================================
> +--- legacy.css (revision 1680353)
> ++++ legacy.css (working copy)
> +@@ -2108,17 +2108,18 @@
> + .nav-pager ul .nav-pagesize {
> + padding: 0 30px 0 30px;
> + }
> +-
> ++/*
> + .field-lookup a{
> + background: url(../images/fieldlookup.png) no-repeat 0 0;
> + display: inline-block;
> + /* margin: 3px 10px 0px 4px; */
> ++/*
> + vertical-align:top;
> + margin-top:3px;
> + width:35px;
> + height:22px;
> + }
> +-
> ++*/
> + .CalLookupImage {
> + display:inline-block;
> + background: url(../images/cal.png) no-repeat;
>
>
>

[Gavin Mabie-2]

Hi Pierre

You are right. I will revert this. Apologies. I committed the patch instead
of the effected files - the latter has been done since.  I will remove the
unusable file ASAP.

Regards
Gavin
On 13 Jun 2015 11:24 AM, "Pierre Smits" <[hidden email]> wrote:

> Hi Gavin,
>
> Adding a file called 'lookupField_patch.patch' to the hot-deploy stack of
> the Bootstrap dev branch isn't the way to go. It doesn't do anything.
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Sat, Jun 13, 2015 at 6:21 AM, <[hidden email]> wrote:
>
> > Author: gavinmabie
> > Date: Sat Jun 13 04:21:20 2015
> > New Revision: 1685210
> >
> > URL: http://svn.apache.org/r1685210
> > Log:
> > Resolves OFBIZ-6452 - Lookup buttons in forms not displaying properly.
> > This is linked to css in legacy.css. Comment out .field-lookup a selector
> > line 2112
> >
> > Added:
> >     ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
> >
> > Added: ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch?rev=1685210&view=auto
> >
> >
> ==============================================================================
> > --- ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch
> > (added)
> > +++ ofbiz/branches/boostrap_theme/hot-deploy/lookupField_patch.patch Sat
> > Jun 13 04:21:20 2015
> > @@ -0,0 +1,25 @@
> > +Index: legacy.css
> > +===================================================================
> > +--- legacy.css (revision 1680353)
> > ++++ legacy.css (working copy)
> > +@@ -2108,17 +2108,18 @@
> > + .nav-pager ul .nav-pagesize {
> > + padding: 0 30px 0 30px;
> > + }
> > +-
> > ++/*
> > + .field-lookup a{
> > + background: url(../images/fieldlookup.png) no-repeat 0 0;
> > + display: inline-block;
> > + /* margin: 3px 10px 0px 4px; */
> > ++/*
> > + vertical-align:top;
> > + margin-top:3px;
> > + width:35px;
> > + height:22px;
> > + }
> > +-
> > ++*/
> > + .CalLookupImage {
> > + display:inline-block;
> > + background: url(../images/cal.png) no-repeat;
> >
> >
> >
>