Re: svn commit: r1686002 - /ofbiz/trunk/applications/party/entitydef/entitymodel.xml

[Jacques Le Roux]

Hi Devs,

Please give me your opinion on OFBIZ-6513.

While at it, I wanted to ask you if you would mind adding and address3 field to PostalAddress? It's sometimes useful when you need to add a 3rd
separated line to an address.

Thanks

Jacques


Le 17/06/2015 14:37, [hidden email] a écrit :

> Author: jleroux
> Date: Wed Jun 17 12:37:06 2015
> New Revision: 1686002
>
> URL: http://svn.apache.org/r1686002
> Log:
> OFBIZ-6513 - countyGeoId and geoPointId fields are missing in PartyAndPostalAddress entity view
>
> Rather than adding both fields, I rather adds an allias-all. Then if ever we add new fields to PostalAddress they will not miss there.
>
> Being only an addition, this does not need any data migration explanations
>
> Modified:
>      ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>
> Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=1686002&r1=1686001&r2=1686002&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Wed Jun 17 12:37:06 2015
> @@ -1346,6 +1346,7 @@ under the License.
>           <member-entity entity-alias="PCM" entity-name="PartyContactMech"/>
>           <member-entity entity-alias="CM" entity-name="ContactMech"/>
>           <member-entity entity-alias="PA" entity-name="PostalAddress"/>
> +        <alias-all entity-alias="PA"/>
>           <alias entity-alias="CM" name="contactMechId"/>
>           <alias entity-alias="PTY" name="partyId"/>
>           <alias entity-alias="PTY" name="statusId"/>
> @@ -1357,17 +1358,6 @@ under the License.
>           <alias entity-alias="PCM" name="comments"/>
>           <alias entity-alias="PCM" name="extension"/>
>           <alias entity-alias="PCM" name="allowSolicitation"/>
> -        <alias entity-alias="PA" name="toName"/>
> -        <alias entity-alias="PA" name="attnName"/>
> -        <alias entity-alias="PA" name="address1"/>
> -        <alias entity-alias="PA" name="address2"/>
> -        <alias entity-alias="PA" name="directions"/>
> -        <alias entity-alias="PA" name="city"/>
> -        <alias entity-alias="PA" name="postalCode"/>
> -        <alias entity-alias="PA" name="postalCodeExt"/>
> -        <alias entity-alias="PA" name="countryGeoId"/>
> -        <alias entity-alias="PA" name="stateProvinceGeoId"/>
> -        <alias entity-alias="PA" name="postalCodeGeoId"/>
>           <view-link entity-alias="PTY" rel-entity-alias="PCM">
>               <key-map field-name="partyId"/>
>           </view-link>
>
>
>

[Nicolas Malin-2]

Hi,

Use an alias-all on generique view, seems to me more interesting because
it more easire to reuse it with specific site code would extend the
PostalAdress entity. So +1.

Nicolas

Le 17/06/2015 14:37, [hidden email] a écrit :

> Author: jleroux
> Date: Wed Jun 17 12:37:06 2015
> New Revision: 1686002
>
> URL: http://svn.apache.org/r1686002
> Log:
> OFBIZ-6513 - countyGeoId and geoPointId fields are missing in PartyAndPostalAddress entity view
>
> Rather than adding both fields, I rather adds an allias-all. Then if ever we add new fields to PostalAddress they will not miss there.
>
> Being only an addition, this does not need any data migration explanations
>
> Modified:
>      ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>
> Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=1686002&r1=1686001&r2=1686002&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Wed Jun 17 12:37:06 2015
> @@ -1346,6 +1346,7 @@ under the License.
>           <member-entity entity-alias="PCM" entity-name="PartyContactMech"/>
>           <member-entity entity-alias="CM" entity-name="ContactMech"/>
>           <member-entity entity-alias="PA" entity-name="PostalAddress"/>
> +        <alias-all entity-alias="PA"/>
>           <alias entity-alias="CM" name="contactMechId"/>
>           <alias entity-alias="PTY" name="partyId"/>
>           <alias entity-alias="PTY" name="statusId"/>
> @@ -1357,17 +1358,6 @@ under the License.
>           <alias entity-alias="PCM" name="comments"/>
>           <alias entity-alias="PCM" name="extension"/>
>           <alias entity-alias="PCM" name="allowSolicitation"/>
> -        <alias entity-alias="PA" name="toName"/>
> -        <alias entity-alias="PA" name="attnName"/>
> -        <alias entity-alias="PA" name="address1"/>
> -        <alias entity-alias="PA" name="address2"/>
> -        <alias entity-alias="PA" name="directions"/>
> -        <alias entity-alias="PA" name="city"/>
> -        <alias entity-alias="PA" name="postalCode"/>
> -        <alias entity-alias="PA" name="postalCodeExt"/>
> -        <alias entity-alias="PA" name="countryGeoId"/>
> -        <alias entity-alias="PA" name="stateProvinceGeoId"/>
> -        <alias entity-alias="PA" name="postalCodeGeoId"/>
>           <view-link entity-alias="PTY" rel-entity-alias="PCM">
>               <key-map field-name="partyId"/>
>           </view-link>
>
>