Re: svn commit: r1722712 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1722712 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy

Scott Gray-3
Hi Jacques,

Keep in mind future readers will want to know what the bug was, not who
reported it. e.g. "Fix NPE occurring when company party has no general
location address"

Thanks
Scott

On 4 January 2016 at 00:46, <[hidden email]> wrote:

> Author: jleroux
> Date: Sun Jan  3 11:46:58 2016
> New Revision: 1722712
>
> URL: http://svn.apache.org/viewvc?rev=1722712&view=rev
> Log:
> Fixes a bug reported by Tiwonge Kawonga on user ML
>
> Modified:
>
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
>
> Modified:
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy?rev=1722712&r1=1722711&r2=1722712&view=diff
>
> ==============================================================================
> ---
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> (original)
> +++
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> Sun Jan  3 11:46:58 2016
> @@ -252,7 +252,7 @@ partyTaxAuthInfoList = from("PartyTaxAut
>                          .filterByDate(nowTimestamp, "fromDate",
> "thruDate")
>                          .queryList();
>  if (partyTaxAuthInfoList) {
> -    if (address.countryGeoId) {
> +    if (address?.countryGeoId) {
>          // if we have an address with country filter by that
>          partyTaxAuthInfoList.eachWithIndex { partyTaxAuthInfo, i ->
>              if
> (partyTaxAuthInfo.taxAuthGeoId.equals(address.countryGeoId)) {
>
>
>