Re: svn commit: r1750045 - /ofbiz/trunk/applications/party/widget/partymgr/LookupScreens.xml

[Nicolas Malin-2]

Le 24/06/2016 09:00, [hidden email] a écrit :
> +                <set field="andCondition" value="${groovy: return org.ofbiz.entity.condition.EntityCondition.makeCondition([
> +                    org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'CONTACT')])}"/>
This commit is fine and when I read it, I ask myself if a dsl groovy
syntax would be define like as example

${groovy: entity condition make([['roleTypeId' : 'CONTACT']]}

${groovy: entity condition make([andCondition, ['roleTypeId' : 'CONTACT']]}

${groovy: entity condition make([andCondition, make ('roleTypeId',
NOT_EQUALS,  'CONTACT')]}

It's completly open idea

Nicoals

[Jacques Le Roux]

+1 for 1 option (yes, I'm lazy). Of course people preferring the std groovy snippet could continue to use it :p

Jacques


Le 24/06/2016 à 09:14, Nicolas Malin a écrit :

> Le 24/06/2016 09:00, [hidden email] a écrit :
>> +                <set field="andCondition" value="${groovy: return org.ofbiz.entity.condition.EntityCondition.makeCondition([
>> + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'CONTACT')])}"/>
> This commit is fine and when I read it, I ask myself if a dsl groovy syntax would be define like as example
>
> ${groovy: entity condition make([['roleTypeId' : 'CONTACT']]}
>
> ${groovy: entity condition make([andCondition, ['roleTypeId' : 'CONTACT']]}
>
> ${groovy: entity condition make([andCondition, make ('roleTypeId', NOT_EQUALS,  'CONTACT')]}
>
> It's completly open idea
>
> Nicoals
>