Re: svn commit: r1750491 - /ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1750491 - /ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

Jacques Le Roux
Administrator
Hi Nicolas,

I see some tabs here ;)

BTW there is another occurrence at line 213

Jacques


Le 28/06/2016 à 14:02, [hidden email] a écrit :

> Author: nmalin
> Date: Tue Jun 28 12:02:57 2016
> New Revision: 1750491
>
> URL: http://svn.apache.org/viewvc?rev=1750491&view=rev
> Log:
> Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in the lookup applications/product/widget/catalog/LookupScreens#LookupVirtualProduct. Related issue OFBIZ-7659, thanks to Florian Montalbano for this.
>
> Modified:
>      ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
>
> Modified: ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml?rev=1750491&r1=1750490&r2=1750491&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml (original)
> +++ ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml Tue Jun 28 12:02:57 2016
> @@ -55,7 +55,7 @@ under the License.
>                   <set field="queryString" from-field="result.queryString"/>
>                   <set field="entityName" value="Product"/>
>                   <set field="searchFields" value="[productId, brandName, internalName]"/>
> -                <set field="andCondition" value="${groovy: return org.ofbiz.entity.condition.EntityCondition.makeCondition(&quot;isVirtual&quot;, &quot;Y&quot;)}"/>
> + <set field="conditionFields.isVirtual" value="Y" />
>               </actions>
>               <widgets>
>                   <decorator-screen name="LookupDecorator" location="component://common/widget/CommonScreens.xml">
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1750491 - /ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

Nicolas Malin-2


Le 28/06/2016 14:48, Jacques Le Roux a écrit :
> Hi Nicolas,
Hi Jacques
>
> I see some tabs here ;)
OMG , I control the patch only with nano ! thanks for spoting Jacques I
will fix it
>
> BTW there is another occurrence at line 213
Ok I will fix it also on the same way.

Nicolas

>
> Jacques
>
>
> Le 28/06/2016 à 14:02, [hidden email] a écrit :
>> Author: nmalin
>> Date: Tue Jun 28 12:02:57 2016
>> New Revision: 1750491
>>
>> URL: http://svn.apache.org/viewvc?rev=1750491&view=rev
>> Log:
>> Change 'andCondition' (which uses groovy as a value) to
>> 'conditionFields' in the lookup
>> applications/product/widget/catalog/LookupScreens#LookupVirtualProduct.
>> Related issue OFBIZ-7659, thanks to Florian Montalbano for this.
>>
>> Modified:
>> ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
>>
>> Modified:
>> ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml?rev=1750491&r1=1750490&r2=1750491&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
>> (original)
>> +++ ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
>> Tue Jun 28 12:02:57 2016
>> @@ -55,7 +55,7 @@ under the License.
>>                   <set field="queryString"
>> from-field="result.queryString"/>
>>                   <set field="entityName" value="Product"/>
>>                   <set field="searchFields" value="[productId,
>> brandName, internalName]"/>
>> -                <set field="andCondition" value="${groovy: return
>> org.ofbiz.entity.condition.EntityCondition.makeCondition(&quot;isVirtual&quot;,
>> &quot;Y&quot;)}"/>
>> +                 <set field="conditionFields.isVirtual" value="Y" />
>>               </actions>
>>               <widgets>
>>                   <decorator-screen name="LookupDecorator"
>> location="component://common/widget/CommonScreens.xml">
>>
>>
>>
>