Re: svn commit: r1757822 - in /ofbiz/trunk/applications/workeffort: config/WorkEffortUiLabels.xml webapp/workeffort/WEB-INF/controller.xml widget/WorkEffortForms.xml widget/WorkEffortMenus.xml widget/WorkEffortScreens.xml

[Nicolas Malin-2]

Taher,
Le 26/08/2016 à 13:37, [hidden email] a écrit :
>          <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit button-type="button"/></field>

We can simplfy this by

<field name="createButton"><submit/></field>

Give the same result ;)

And same for

         <field name="submitButton" title="${uiLabelMap.CommonUpdate}"><submit button-type="button"/></field>
By
         <field name="updateButton"><submit/></field>


Nicolas

[taher]

Good advice Nicolas, would you mind also taking another look at everything
and committing your recommendations against OFBIZ-7973?

On Fri, Aug 26, 2016 at 2:57 PM, Nicolas Malin <[hidden email]>
wrote:

> Taher,
> Le 26/08/2016 à 13:37, [hidden email] a écrit :
>
>>          <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit
>> button-type="button"/></field>
>>
>
> We can simplfy this by
>
> <field name="createButton"><submit/></field>
>
> Give the same result ;)
>
> And same for
>
>         <field name="submitButton" title="${uiLabelMap.CommonUpdate}"><submit
> button-type="button"/></field>
> By
>         <field name="updateButton"><submit/></field>
>
>
> Nicolas
>

[Nicolas Malin-2]

Yes sure I will do

I prefer just advice instead of commit on your commit, source of
frustration raise :)

Nicolas

Le 26/08/2016 à 14:17, Taher Alkhateeb a écrit :

> Good advice Nicolas, would you mind also taking another look at everything
> and committing your recommendations against OFBIZ-7973?
>
> On Fri, Aug 26, 2016 at 2:57 PM, Nicolas Malin <[hidden email]>
> wrote:
>
>> Taher,
>> Le 26/08/2016 à 13:37, [hidden email] a écrit :
>>
>>>           <field name="submitButton" title="${uiLabelMap.CommonCreate}"><submit
>>> button-type="button"/></field>
>>>
>> We can simplfy this by
>>
>> <field name="createButton"><submit/></field>
>>
>> Give the same result ;)
>>
>> And same for
>>
>>          <field name="submitButton" title="${uiLabelMap.CommonUpdate}"><submit
>> button-type="button"/></field>
>> By
>>          <field name="updateButton"><submit/></field>
>>
>>
>> Nicolas
>>

[taher]

If you provide follow up fixes I'd be flattered :) Also I'm knee deep into
the plugin system (BTW if you have thoughts I'd appreciate your input in
that thread)

On Fri, Aug 26, 2016 at 3:26 PM, Nicolas Malin <[hidden email]>
wrote:

> Yes sure I will do
>
> I prefer just advice instead of commit on your commit, source of
> frustration raise :)
>
> Nicolas
>
>
> Le 26/08/2016 à 14:17, Taher Alkhateeb a écrit :
>
>> Good advice Nicolas, would you mind also taking another look at everything
>> and committing your recommendations against OFBIZ-7973?
>>
>> On Fri, Aug 26, 2016 at 2:57 PM, Nicolas Malin <[hidden email]>
>> wrote:
>>
>> Taher,
>>> Le 26/08/2016 à 13:37, [hidden email] a écrit :
>>>
>>>           <field name="submitButton" title="${uiLabelMap.CommonCrea
>>>> te}"><submit
>>>> button-type="button"/></field>
>>>>
>>>> We can simplfy this by
>>>
>>> <field name="createButton"><submit/></field>
>>>
>>> Give the same result ;)
>>>
>>> And same for
>>>
>>>          <field name="submitButton" title="${uiLabelMap.CommonUpda
>>> te}"><submit
>>> button-type="button"/></field>
>>> By
>>>          <field name="updateButton"><submit/></field>
>>>
>>>
>>> Nicolas
>>>
>>>
>