Re: svn commit: r1761332 - /ofbiz/trunk/applications/commonext/widget/SystemInfoForms.xml

[Nicolas Malin-2]

Hi Michael
>           <field name="taskAssignment"><check/></field>
> -        <field name="updateButton"><submit/></field>
> +        <field name="updateButton" title="${uiLabelMap.CommonUpdate}"><submit/></field>
>       </form>
I didn't understand why you added this title. Normally the title
resolution need came from
     <property key="FormFieldTitle_updateButton">. For me it's a
regression and after checked the Jira OFBIZ-8121 I didn't see a valid reason

Can you explain me more why ?
>           <field name="noteInfo"><text size="50"/></field>
> -        <field name="createButton"><submit/></field>
> +        <field name="createButton" title="${uiLabelMap.CommonCreate}"><submit/></field>
>       </form>
>   </forms>
>
seem here

Nicoals

[Michael Brohl-3]

Hi Nicolas,

you are right, that change is also not necessary. Seems I was confused
while reviewing the other changes in the referenced Jira and the related
subtasks.

I will revert the commit.

Thanks for taking care,

Michael


Am 18.09.16 um 17:21 schrieb Nicolas Malin:

> Hi Michael
>>           <field name="taskAssignment"><check/></field>
>> -        <field name="updateButton"><submit/></field>
>> +        <field name="updateButton"
>> title="${uiLabelMap.CommonUpdate}"><submit/></field>
>>       </form>
> I didn't understand why you added this title. Normally the title
> resolution need came from
>     <property key="FormFieldTitle_updateButton">. For me it's a
> regression and after checked the Jira OFBIZ-8121 I didn't see a valid
> reason
>
> Can you explain me more why ?
>>           <field name="noteInfo"><text size="50"/></field>
>> -        <field name="createButton"><submit/></field>
>> +        <field name="createButton"
>> title="${uiLabelMap.CommonCreate}"><submit/></field>
>>       </form>
>>   </forms>
>>
> seem here
>
> Nicoals

[Nicolas Malin-2]

No worries Michael, thanks for your reactivity

Nicolas

Le 18/09/2016 à 17:36, Michael Brohl a écrit :

> Hi Nicolas,
>
> you are right, that change is also not necessary. Seems I was confused
> while reviewing the other changes in the referenced Jira and the
> related subtasks.
>
> I will revert the commit.
>
> Thanks for taking care,
>
> Michael
>
>
> Am 18.09.16 um 17:21 schrieb Nicolas Malin:
>> Hi Michael
>>>           <field name="taskAssignment"><check/></field>
>>> -        <field name="updateButton"><submit/></field>
>>> +        <field name="updateButton"
>>> title="${uiLabelMap.CommonUpdate}"><submit/></field>
>>>       </form>
>> I didn't understand why you added this title. Normally the title
>> resolution need came from
>>     <property key="FormFieldTitle_updateButton">. For me it's a
>> regression and after checked the Jira OFBIZ-8121 I didn't see a valid
>> reason
>>
>> Can you explain me more why ?
>>>           <field name="noteInfo"><text size="50"/></field>
>>> -        <field name="createButton"><submit/></field>
>>> +        <field name="createButton"
>>> title="${uiLabelMap.CommonCreate}"><submit/></field>
>>>       </form>
>>>   </forms>
>>>
>> seem here
>>
>> Nicoals
>
>