Re: svn commit: r1765030 - /ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReser veServices.xml

[Jacques Le Roux]

Hi Pranay,

Did you notice this small issue with integration tests?

https://ci.apache.org/builders/ofbiz-trunk

Thanks

Jacques


Le 15/10/2016 à 11:50, [hidden email] a écrit :

> Author: pranayp
> Date: Sat Oct 15 09:50:06 2016
> New Revision: 1765030
>
> URL: http://svn.apache.org/viewvc?rev=1765030&view=rev
> Log:
> Fixed: InventoryItemStatus logging for reserved serialized inventory item.
> (OFBIZ-8459)
>
> InventoryItemStatus will now be logged as: INV_PROMISED when a serialized inventory item is reserved for an order.
>
> Thanks:  Vaibhav Jain for the contribution.
>
> Modified:
>      ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml
>
> Modified: ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml?rev=1765030&r1=1765029&r2=1765030&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml (original)
> +++ ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml Sat Oct 15 09:50:06 2016
> @@ -400,8 +400,9 @@ under the License.
>               <if-compare value="SERIALIZED_INV_ITEM" operator="equals" field="inventoryItem.inventoryItemTypeId">
>                   <if-compare value="INV_AVAILABLE" operator="equals" field="inventoryItem.statusId">
>                       <!-- change status on inventoryItem -->
> -                    <set value="INV_PROMISED" field="inventoryItem.statusId"/>
> -                    <store-value value-field="inventoryItem"/>
> +                    <set field="updateInventoryItemMap.inventoryItemId" from-field="inventoryItem.inventoryItemId"/>
> +                    <set field="updateInventoryItemMap.statusId" value="INV_PROMISED"/>
> +                    <call-service service-name="updateInventoryItem" in-map-name="updateInventoryItemMap"/>
>  
>                       <!-- store OrderItemShipGrpInvRes record -->
>                       <call-simple-method method-name="getPromisedDateTime"/>
>
>
>

[Pranay Pandey-3]

Hi Jacques,

I got that one and reverting my commit now, will need to check the test and
then will come back.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Oct 15, 2016 at 5:40 PM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Pranay,
>
> Did you notice this small issue with integration tests?
>
> https://ci.apache.org/builders/ofbiz-trunk
>
> Thanks
>
> Jacques
>
>
>
> Le 15/10/2016 à 11:50, [hidden email] a écrit :
>
>> Author: pranayp
>> Date: Sat Oct 15 09:50:06 2016
>> New Revision: 1765030
>>
>> URL: http://svn.apache.org/viewvc?rev=1765030&view=rev
>> Log:
>> Fixed: InventoryItemStatus logging for reserved serialized inventory item.
>> (OFBIZ-8459)
>>
>> InventoryItemStatus will now be logged as: INV_PROMISED when a serialized
>> inventory item is reserved for an order.
>>
>> Thanks:  Vaibhav Jain for the contribution.
>>
>> Modified:
>>      ofbiz/trunk/applications/product/minilang/product/inventory
>> /InventoryReserveServices.xml
>>
>> Modified: ofbiz/trunk/applications/product/minilang/product/inventory/
>> InventoryReserveServices.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/produc
>> t/minilang/product/inventory/InventoryReserveServices.xml?re
>> v=1765030&r1=1765029&r2=1765030&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml
>> (original)
>> +++ ofbiz/trunk/applications/product/minilang/product/inventory/InventoryReserveServices.xml
>> Sat Oct 15 09:50:06 2016
>> @@ -400,8 +400,9 @@ under the License.
>>               <if-compare value="SERIALIZED_INV_ITEM" operator="equals"
>> field="inventoryItem.inventoryItemTypeId">
>>                   <if-compare value="INV_AVAILABLE" operator="equals"
>> field="inventoryItem.statusId">
>>                       <!-- change status on inventoryItem -->
>> -                    <set value="INV_PROMISED"
>> field="inventoryItem.statusId"/>
>> -                    <store-value value-field="inventoryItem"/>
>> +                    <set field="updateInventoryItemMap.inventoryItemId"
>> from-field="inventoryItem.inventoryItemId"/>
>> +                    <set field="updateInventoryItemMap.statusId"
>> value="INV_PROMISED"/>
>> +                    <call-service service-name="updateInventoryItem"
>> in-map-name="updateInventoryItemMap"/>
>>                         <!-- store OrderItemShipGrpInvRes record -->
>>                       <call-simple-method method-name="getPromisedDateTi
>> me"/>
>>
>>
>>
>>
>