Re: svn commit: r1781109 - /ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices. xml

[Jacques Le Roux]

Hi Jacopo,

Is it no related with a Jira? Since it's a functional change I think it would be better.

Thanks

Jacques


Le 31/01/2017 à 16:43, [hidden email] a écrit :

> Author: jacopoc
> Date: Tue Jan 31 15:43:46 2017
> New Revision: 1781109
>
> URL: http://svn.apache.org/viewvc?rev=1781109&view=rev
> Log:
> Fixed: reversed the debit and credit entries of the accounting transactions for
> fixed asset depreciations.
>
> Modified:
>      ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
>
> Modified: ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev=1781109&r1=1781108&r2=1781109&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml (original)
> +++ ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml Tue Jan 31 15:43:46 2017
> @@ -403,7 +403,7 @@ under the License.
>                       <condition>
>                           <and>
>                               <not><if-empty field="fixedAssetTypeGlAccount.accDepGlAccountId"/></not>
> -                            <if-compare field="parameters.debitCreditFlag" operator="equals" value="D"/>
> +                            <if-compare field="parameters.debitCreditFlag" operator="equals" value="C"/>
>                           </and>
>                       </condition>
>                       <then>
> @@ -415,7 +415,7 @@ under the License.
>                       <condition>
>                           <and>
>                               <not><if-empty field="fixedAssetTypeGlAccount.depGlAccountId"/></not>
> -                            <if-compare field="parameters.debitCreditFlag" operator="equals" value="C"/>
> +                            <if-compare field="parameters.debitCreditFlag" operator="equals" value="D"/>
>                           </and>
>                       </condition>
>                       <then>
>
>
>

[Jacopo Cappellato-5]

On Tue, Jan 31, 2017 at 10:06 PM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Jacopo,
>
> Is it no related with a Jira? Since it's a functional change I think it
> would be better.
>
> Thanks
>
> Jacques
>
>

Agreed. We should also back-port to all the release branches (I only did
for 16.12).
Any volunteers to do the backporting and creation of the Jira ticket? If
not I will take care of this when I will have a free slot.

Jacopo

[Gil Portenseigne]

Hi Jacopo,

I will do, tonight if nobody else take it.

Gil

On 01/02/2017 10:01, Jacopo Cappellato wrote:

> On Tue, Jan 31, 2017 at 10:06 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Jacopo,
>>
>> Is it no related with a Jira? Since it's a functional change I think it
>> would be better.
>>
>> Thanks
>>
>> Jacques
>>
>>
> Agreed. We should also back-port to all the release branches (I only did
> for 16.12).
> Any volunteers to do the backporting and creation of the Jira ticket? If
> not I will take care of this when I will have a free slot.
>
> Jacopo
>

[Jacques Le Roux]

Thanks to both

Jacques


Le 01/02/2017 à 10:30, gil portenseigne a écrit :

> Hi Jacopo,
>
> I will do, tonight if nobody else take it.
>
> Gil
>
> On 01/02/2017 10:01, Jacopo Cappellato wrote:
>> On Tue, Jan 31, 2017 at 10:06 PM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Hi Jacopo,
>>>
>>> Is it no related with a Jira? Since it's a functional change I think it
>>> would be better.
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>> Agreed. We should also back-port to all the release branches (I only did
>> for 16.12).
>> Any volunteers to do the backporting and creation of the Jira ticket? If
>> not I will take care of this when I will have a free slot.
>>
>> Jacopo
>>
>
>