Re: svn commit: r1787937 - /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentEvents.java

[Jacopo Cappellato-5]

Forwarding an email that I sent yesterday and seems to be lost in the net.

Jacopo

On Tue, Mar 21, 2017 at 1:34 PM, Jacopo Cappellato <
[hidden email]> wrote:

> On Tue, Mar 21, 2017 at 12:01 PM, <[hidden email]> wrote:
>
>> Log:
>> No functional change, just a TODO for later
>> [...]
>>
>> +        // TODO refactor I don't like much how this is written but it's
>> not simple to refactor
>>          boolean beganTx = false;
>>
>
> Thess changes should not be committed: they cause noise to a large
> audience, add irrelevant comments to the code and make it look like it is a
> personal repository.
>
> Please revert and find a better way, using your local repo, to keep track
> of your work in progress.
>
> Jacopo
>

[Jacques Le Roux]

Le 23/03/2017 à 09:03, Jacopo Cappellato a écrit :

> Forwarding an email that I sent yesterday and seems to be lost in the net.
>
> Jacopo
>
> On Tue, Mar 21, 2017 at 1:34 PM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> On Tue, Mar 21, 2017 at 12:01 PM, <[hidden email]> wrote:
>>
>>> Log:
>>> No functional change, just a TODO for later
>>> [...]
>>>
>>> +        // TODO refactor I don't like much how this is written but it's
>>> not simple to refactor
>>>           boolean beganTx = false;
>>>
>> Thess changes should not be committed: they cause noise to a large
>> audience, add irrelevant comments to the code and make it look like it is a
>> personal repository.
>>
>> Please revert and find a better way, using your local repo, to keep track
>> of your work in progress.
>>
>> Jacopo
>>

I can remove this TODO, no problem

Jacques