Re: svn commit: r1790499 - in /ofbiz/ofbiz-plugins/trunk/birt: entitydef/ServiceReportsView.xml src/main/java/org/apache/ofbiz/birt/flexible/BirtMasterReportServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1790499 - in /ofbiz/ofbiz-plugins/trunk/birt: entitydef/ServiceReportsView.xml src/main/java/org/apache/ofbiz/birt/flexible/BirtMasterReportServices.java

Jacopo Cappellato-5
On Fri, Apr 7, 2017 at 6:23 AM, <[hidden email]> wrote:

> Author: jleroux
> Date: Fri Apr  7 04:23:17 2017
> New Revision: 1790499
>
> ==================
> --- ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
> (original)
> +++ ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml Fri
> Apr  7 04:23:17 2017
> @@ -52,7 +52,7 @@ under the License.
>          <alias entity-alias="INITM" name="quantity"/>
>          <alias entity-alias="INITM" name="amount"/>
>          <alias entity-alias="PA" name="partyId"/>
> -        <alias entity-alias="PA" name="partyName"/>
> +<!--         <alias entity-alias="PA" name="partyName"/> -->
>          <alias entity-alias="PRO" name="productId"/>
>          <alias entity-alias="PRO" name="primaryProductCategoryId"/>
>          <view-link entity-alias="INV" rel-entity-alias="INITM">
>
>
Why not removing it?

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1790499 - in /ofbiz/ofbiz-plugins/trunk/birt: entitydef/ServiceReportsView.xml src/main/java/org/apache/ofbiz/birt/flexible/BirtMasterReportServices.java

Jacques Le Roux
Administrator
Yes good question, because, as I mentioned in the commit comment, I wanted to revisit it.

My idea was to replace it by using PartyViewName. But now that I look at it again, it's not worth the burden.

This is only an example for demoing Flexible Reports with services.

I just removed it with another useless line I left there

Jacques


Le 07/04/2017 à 08:52, Jacopo Cappellato a écrit :

> On Fri, Apr 7, 2017 at 6:23 AM, <[hidden email]> wrote:
>
>> Author: jleroux
>> Date: Fri Apr  7 04:23:17 2017
>> New Revision: 1790499
>>
>> ==================
>> --- ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
>> (original)
>> +++ ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml Fri
>> Apr  7 04:23:17 2017
>> @@ -52,7 +52,7 @@ under the License.
>>           <alias entity-alias="INITM" name="quantity"/>
>>           <alias entity-alias="INITM" name="amount"/>
>>           <alias entity-alias="PA" name="partyId"/>
>> -        <alias entity-alias="PA" name="partyName"/>
>> +<!--         <alias entity-alias="PA" name="partyName"/> -->
>>           <alias entity-alias="PRO" name="productId"/>
>>           <alias entity-alias="PRO" name="primaryProductCategoryId"/>
>>           <view-link entity-alias="INV" rel-entity-alias="INITM">
>>
>>
> Why not removing it?
>
> Jacopo
>