Re: svn commit: r1795781 - in /ofbiz/ofbiz-plugins/trunk: lucene/build.gradle solr/build.gradle

[Michael Brohl-3]

Hi Jacques,

why do we need the solr.log.dir in the Lucene plugin? I think the it
only belongs in the Solr Plugin.

I'll remove it during my work on
https://issues.apache.org/jira/browse/OFBIZ-9440 if there are no objections.

Regards,

Michael


Am 22.05.17 um 11:18 schrieb [hidden email]:

> Author: jleroux
> Date: Mon May 22 09:18:25 2017
> New Revision: 1795781
>
> URL: http://svn.apache.org/viewvc?rev=1795781&view=rev
> Log:
> Improved: Missing Java Option solr.log.dir. Logging may be missing or incomplete
> (OFBIZ-)
>
> I noticed this error in trunk demo error.log but could not reproduce locally
> (Windows)
>
> Jinghai suggested the fix committed, Taher mentioned it should be in plugins
>
>
> Thanks: Jinghai and Taher
>
> Modified:
>      ofbiz/ofbiz-plugins/trunk/lucene/build.gradle
>      ofbiz/ofbiz-plugins/trunk/solr/build.gradle
>
> Modified: ofbiz/ofbiz-plugins/trunk/lucene/build.gradle
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/lucene/build.gradle?rev=1795781&r1=1795780&r2=1795781&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/lucene/build.gradle (original)
> +++ ofbiz/ofbiz-plugins/trunk/lucene/build.gradle Mon May 22 09:18:25 2017
> @@ -20,4 +20,7 @@ dependencies {
>       pluginLibsCompile 'org.apache.lucene:lucene-core:6.5.1'
>       pluginLibsCompile 'org.apache.lucene:lucene-queryparser:6.5.1'
>       pluginLibsCompile 'org.apache.lucene:lucene-analyzers-common:6.5.1'
> -}
> \ No newline at end of file
> +}
> +def jvmArguments = ['-Xms128M', '-Xmx1024M',
> +    '-Dsolr.log.dir=runtime/logs',
> +                    '-Dsolr.log.level=INFO']
>
> Modified: ofbiz/ofbiz-plugins/trunk/solr/build.gradle
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/solr/build.gradle?rev=1795781&r1=1795780&r2=1795781&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/solr/build.gradle (original)
> +++ ofbiz/ofbiz-plugins/trunk/solr/build.gradle Mon May 22 09:18:25 2017
> @@ -19,3 +19,6 @@
>   dependencies {
>       pluginLibsCompile 'org.apache.solr:solr-core:6.5.1'
>   }
> +def jvmArguments = ['-Xms128M', '-Xmx1024M',
> +'-Dsolr.log.dir=runtime/logs',
> +                '-Dsolr.log.level=INFO']
>
>

[Jacques Le Roux]

Hi Michael,

You don't have to worry about that. I fixed the whole thing at revision: 1800457. Hint: it was not correctly done even for Solr.

Jacques


Le 29/06/2017 à 21:41, Michael Brohl a écrit :

> Hi Jacques,
>
> why do we need the solr.log.dir in the Lucene plugin? I think the it only belongs in the Solr Plugin.
>
> I'll remove it during my work on https://issues.apache.org/jira/browse/OFBIZ-9440 if there are no objections.
>
> Regards,
>
> Michael
>
>
> Am 22.05.17 um 11:18 schrieb [hidden email]:
>> Author: jleroux
>> Date: Mon May 22 09:18:25 2017
>> New Revision: 1795781
>>
>> URL: http://svn.apache.org/viewvc?rev=1795781&view=rev
>> Log:
>> Improved: Missing Java Option solr.log.dir. Logging may be missing or incomplete
>> (OFBIZ-)
>>
>> I noticed this error in trunk demo error.log but could not reproduce locally
>> (Windows)
>>
>> Jinghai suggested the fix committed, Taher mentioned it should be in plugins
>>
>>
>> Thanks: Jinghai and Taher
>>
>> Modified:
>>      ofbiz/ofbiz-plugins/trunk/lucene/build.gradle
>>      ofbiz/ofbiz-plugins/trunk/solr/build.gradle
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/lucene/build.gradle
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/lucene/build.gradle?rev=1795781&r1=1795780&r2=1795781&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-plugins/trunk/lucene/build.gradle (original)
>> +++ ofbiz/ofbiz-plugins/trunk/lucene/build.gradle Mon May 22 09:18:25 2017
>> @@ -20,4 +20,7 @@ dependencies {
>>       pluginLibsCompile 'org.apache.lucene:lucene-core:6.5.1'
>>       pluginLibsCompile 'org.apache.lucene:lucene-queryparser:6.5.1'
>>       pluginLibsCompile 'org.apache.lucene:lucene-analyzers-common:6.5.1'
>> -}
>> \ No newline at end of file
>> +}
>> +def jvmArguments = ['-Xms128M', '-Xmx1024M',
>> +    '-Dsolr.log.dir=runtime/logs',
>> +                    '-Dsolr.log.level=INFO']
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/solr/build.gradle
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/solr/build.gradle?rev=1795781&r1=1795780&r2=1795781&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-plugins/trunk/solr/build.gradle (original)
>> +++ ofbiz/ofbiz-plugins/trunk/solr/build.gradle Mon May 22 09:18:25 2017
>> @@ -19,3 +19,6 @@
>>   dependencies {
>>       pluginLibsCompile 'org.apache.solr:solr-core:6.5.1'
>>   }
>> +def jvmArguments = ['-Xms128M', '-Xmx1024M',
>> +'-Dsolr.log.dir=runtime/logs',
>> +                '-Dsolr.log.level=INFO']
>>
>>
>
>