Re: svn commit: r1798912 - /ofbiz/tools/demo-backup/trunk-manual-only.sh

[taher]

Why would you add 30 sec sleep!

The right way to do this is to change the command as follows:

./gradlew "ofbiz --shutdown"

In other words, don't send the shutdown command to the background.

On Jun 16, 2017 2:34 PM, <[hidden email]> wrote:

Author: jleroux
Date: Fri Jun 16 11:34:38 2017
New Revision: 1798912

URL: http://svn.apache.org/viewvc?rev=1798912&view=rev
Log:
Improved: Adds 30 sec sleep after "ofbizBackground --shutdown" to allow time
for OFBiz to stop
(OFBIZ-9414)

No functional change, this is only for demos. OFBIZ-9414 is a WIP,
to be checked tmrw



Modified:
    ofbiz/tools/demo-backup/trunk-manual-only.sh

Modified: ofbiz/tools/demo-backup/trunk-manual-only.sh
URL: http://svn.apache.org/viewvc/ofbiz/tools/demo-backup/trunk-
manual-only.sh?rev=1798912&r1=1798911&r2=1798912&view=diff
============================================================
==================
--- ofbiz/tools/demo-backup/trunk-manual-only.sh (original)
+++ ofbiz/tools/demo-backup/trunk-manual-only.sh Fri Jun 16 11:34:38 2017
@@ -4,6 +4,7 @@ cd /home/ofbizDemo/trunk
 svn up
 ./gradlew pullAllPluginsSource
 ./gradlew "ofbizBackground --shutdown"
+sleep 30
 ./gradlew cleanAll
 ./gradlew loadAll
 ./gradlew svnInfoFooter

[Jacques Le Roux]

Ah, I thought that you had to shutdown with ofbizBackground when you started with ofbizBackground

It's indeed simpler, I'll try that then, after having tried with sleep this night to be sure of the 2 scenarios

Thanks

Jacques


Le 16/06/2017 à 13:53, Taher Alkhateeb a écrit :

> Why would you add 30 sec sleep!
>
> The right way to do this is to change the command as follows:
>
> ./gradlew "ofbiz --shutdown"
>
> In other words, don't send the shutdown command to the background.
>
> On Jun 16, 2017 2:34 PM, <[hidden email]> wrote:
>
> Author: jleroux
> Date: Fri Jun 16 11:34:38 2017
> New Revision: 1798912
>
> URL: http://svn.apache.org/viewvc?rev=1798912&view=rev
> Log:
> Improved: Adds 30 sec sleep after "--shutdown" to allow time
> for OFBiz to stop
> (OFBIZ-9414)
>
> No functional change, this is only for demos. OFBIZ-9414 is a WIP,
> to be checked tmrw
>
>
>
> Modified:
>      ofbiz/tools/demo-backup/trunk-manual-only.sh
>
> Modified: ofbiz/tools/demo-backup/trunk-manual-only.sh
> URL: http://svn.apache.org/viewvc/ofbiz/tools/demo-backup/trunk-
> manual-only.sh?rev=1798912&r1=1798911&r2=1798912&view=diff
> ============================================================
> ==================
> --- ofbiz/tools/demo-backup/trunk-manual-only.sh (original)
> +++ ofbiz/tools/demo-backup/trunk-manual-only.sh Fri Jun 16 11:34:38 2017
> @@ -4,6 +4,7 @@ cd /home/ofbizDemo/trunk
>   svn up
>   ./gradlew pullAllPluginsSource
>   ./gradlew "ofbizBackground --shutdown"
> +sleep 30
>   ./gradlew cleanAll
>   ./gradlew loadAll
>   ./gradlew svnInfoFooter
>

[Jacques Le Roux]

Worked perfectly this night, thanks Taher!

For those interested see OFBIZ-9414

Was quite simple finally, and in most case terminateOfbiz should not be used. After all it's only a kill -9 (with its drawbacks)!

Jacques


Le 16/06/2017 à 15:49, Jacques Le Roux a écrit :

> Ah, I thought that you had to shutdown with ofbizBackground when you started with ofbizBackground
>
> It's indeed simpler, I'll try that then, after having tried with sleep this night to be sure of the 2 scenarios
>
> Thanks
>
> Jacques
>
>
> Le 16/06/2017 à 13:53, Taher Alkhateeb a écrit :
>> Why would you add 30 sec sleep!
>>
>> The right way to do this is to change the command as follows:
>>
>> ./gradlew "ofbiz --shutdown"
>>
>> In other words, don't send the shutdown command to the background.
>>
>> On Jun 16, 2017 2:34 PM, <[hidden email]> wrote:
>>
>> Author: jleroux
>> Date: Fri Jun 16 11:34:38 2017
>> New Revision: 1798912
>>
>> URL: http://svn.apache.org/viewvc?rev=1798912&view=rev
>> Log:
>> Improved: Adds 30 sec sleep after "--shutdown" to allow time
>> for OFBiz to stop
>> (OFBIZ-9414)
>>
>> No functional change, this is only for demos. OFBIZ-9414 is a WIP,
>> to be checked tmrw
>>
>>
>>
>> Modified:
>>      ofbiz/tools/demo-backup/trunk-manual-only.sh
>>
>> Modified: ofbiz/tools/demo-backup/trunk-manual-only.sh
>> URL: http://svn.apache.org/viewvc/ofbiz/tools/demo-backup/trunk-
>> manual-only.sh?rev=1798912&r1=1798911&r2=1798912&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/tools/demo-backup/trunk-manual-only.sh (original)
>> +++ ofbiz/tools/demo-backup/trunk-manual-only.sh Fri Jun 16 11:34:38 2017
>> @@ -4,6 +4,7 @@ cd /home/ofbizDemo/trunk
>>   svn up
>>   ./gradlew pullAllPluginsSource
>>   ./gradlew "ofbizBackground --shutdown"
>> +sleep 30
>>   ./gradlew cleanAll
>>   ./gradlew loadAll
>>   ./gradlew svnInfoFooter
>>
>
>

[Jacques Le Roux]

Not sure why but got this today

:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar UP-TO-DATE
:assemble UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:build UP-TO-DATE
:ofbiz
Config.java using configuration file start.properties
Set OFBIZ_HOME to - /home/ofbizDemo/trunk
org.apache.ofbiz.base.start.StartupException: Couldn't create server socket(/127.0.0.1:10523) (Address already in use (Bind failed))
     at org.apache.ofbiz.base.start.AdminServer.<init>(AdminServer.java:56)
     at org.apache.ofbiz.base.start.StartupControlPanel.createAdminServer(StartupControlPanel.java:172)
     at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:68)
     at org.apache.ofbiz.base.start.Start.main(Start.java:84)
Caused by: java.net.BindException: Address already in use (Bind failed)
     at java.net.PlainSocketImpl.socketBind(Native Method)
     at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
     at java.net.ServerSocket.bind(ServerSocket.java:375)
     at java.net.ServerSocket.<init>(ServerSocket.java:237)
     at org.apache.ofbiz.base.start.AdminServer.<init>(AdminServer.java:54)
     ... 3 more
:ofbiz  FAILED

So I had to kill (15 and 9) the trunk processes. I will see tomorrow...
It worked last night with the same config. I'm surprised to see ":compileJava UP-TO-DATE" since we made changes yesterday

Jacques

Le 18/06/2017 à 18:31, Jacques Le Roux a écrit :

> Worked perfectly this night, thanks Taher!
>
> For those interested see OFBIZ-9414
>
> Was quite simple finally, and in most case terminateOfbiz should not be used. After all it's only a kill -9 (with its drawbacks)!
>
> Jacques
>
>
> Le 16/06/2017 à 15:49, Jacques Le Roux a écrit :
>> Ah, I thought that you had to shutdown with ofbizBackground when you started with ofbizBackground
>>
>> It's indeed simpler, I'll try that then, after having tried with sleep this night to be sure of the 2 scenarios
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 16/06/2017 à 13:53, Taher Alkhateeb a écrit :
>>> Why would you add 30 sec sleep!
>>>
>>> The right way to do this is to change the command as follows:
>>>
>>> ./gradlew "ofbiz --shutdown"
>>>
>>> In other words, don't send the shutdown command to the background.
>>>
>>> On Jun 16, 2017 2:34 PM, <[hidden email]> wrote:
>>>
>>> Author: jleroux
>>> Date: Fri Jun 16 11:34:38 2017
>>> New Revision: 1798912
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1798912&view=rev
>>> Log:
>>> Improved: Adds 30 sec sleep after "--shutdown" to allow time
>>> for OFBiz to stop
>>> (OFBIZ-9414)
>>>
>>> No functional change, this is only for demos. OFBIZ-9414 is a WIP,
>>> to be checked tmrw
>>>
>>>
>>>
>>> Modified:
>>>      ofbiz/tools/demo-backup/trunk-manual-only.sh
>>>
>>> Modified: ofbiz/tools/demo-backup/trunk-manual-only.sh
>>> URL: http://svn.apache.org/viewvc/ofbiz/tools/demo-backup/trunk-
>>> manual-only.sh?rev=1798912&r1=1798911&r2=1798912&view=diff
>>> ============================================================
>>> ==================
>>> --- ofbiz/tools/demo-backup/trunk-manual-only.sh (original)
>>> +++ ofbiz/tools/demo-backup/trunk-manual-only.sh Fri Jun 16 11:34:38 2017
>>> @@ -4,6 +4,7 @@ cd /home/ofbizDemo/trunk
>>>   svn up
>>>   ./gradlew pullAllPluginsSource
>>>   ./gradlew "ofbizBackground --shutdown"
>>> +sleep 30
>>>   ./gradlew cleanAll
>>>   ./gradlew loadAll
>>>   ./gradlew svnInfoFooter
>>>
>>
>>
>
>