OFBiz › OFBiz - Dev

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Jacques Le Roux

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

Administrator

Ha got it OFBIZ-9577

Jacques

Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :

> Good catch Nicolas,
>
> Should there not be a related Jira?
>
> Thanks
>
> Jacques
>
>
> Le 14/08/2017 à 17:47, [hidden email] a écrit :
>> Author: nmalin
>> Date: Mon Aug 14 15:47:36 2017
>> New Revision: 1805011
>>
>> URL: http://svn.apache.org/viewvc?rev=1805011&view=rev
>> Log:
>> Fixed: Missing fieldInfo when call constructor for ModelFormField Password, File and Lookup
>> When you create a form with an entity or service auto fields, the three previous form field call only "super(fieldSource, modelFormField);" in
>> their constructor or this initialise a TextField with the fieldInfo FieldInfo.TEXT.
>> I force the field info when the super constructor is called
>>
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>
>> Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011&r1=1805010&r2=1805011&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java (original)
>> +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java Mon Aug 14 15:47:36 2017
>> @@ -2096,7 +2096,7 @@ public class ModelFormField {
>> }
>> public FileField(int fieldSource, ModelFormField modelFormField) {
>> - super(fieldSource, modelFormField);
>> + super(fieldSource, FieldInfo.FILE, modelFormField);
>> }
>> @Override
>> @@ -3028,7 +3028,7 @@ public class ModelFormField {
>> }
>> public LookupField(int fieldSource, ModelFormField modelFormField) {
>> - super(fieldSource, modelFormField);
>> + super(fieldSource, FieldInfo.LOOKUP, modelFormField);
>> this.descriptionFieldName = "";
>> this.fadeBackground = "";
>> this.formName = FlexibleStringExpander.getInstance("");
>> @@ -3250,7 +3250,7 @@ public class ModelFormField {
>> }
>> public PasswordField(int fieldSource, ModelFormField modelFormField) {
>> - super(fieldSource, modelFormField);
>> + super(fieldSource, FieldInfo.PASSWORD, modelFormField);
>> }
>> private PasswordField(PasswordField original, ModelFormField modelFormField) {
>>
>>
>>
>
>

Nicolas Malin-2

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

Not really, I detect it effectively during some trying related to the
OFBIZ-9577but actually I didn't detect any problem with that in the
framework.

So I corrected it because it's a easy framework error.

If you think it's interesting to open an issue, I can do that

Nicolas

Le 14/08/2017 à 19:49, Jacques Le Roux a écrit :

> Ha got it OFBIZ-9577
>
> Jacques
>
> Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :
>> Good catch Nicolas,
>>
>> Should there not be a related Jira?
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 14/08/2017 à 17:47, [hidden email] a écrit :
>>> Author: nmalin
>>> Date: Mon Aug 14 15:47:36 2017
>>> New Revision: 1805011
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1805011&view=rev
>>> Log:
>>> Fixed: Missing fieldInfo when call constructor for ModelFormField
>>> Password, File and Lookup
>>> When you create a form with an entity or service auto fields, the
>>> three previous form field call only "super(fieldSource,
>>> modelFormField);" in their constructor or this initialise a
>>> TextField with the fieldInfo FieldInfo.TEXT.
>>> I force the field info when the super constructor is called
>>>
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011&r1=1805010&r2=1805011&view=diff
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>> (original)
>>> +++
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>> Mon Aug 14 15:47:36 2017
>>> @@ -2096,7 +2096,7 @@ public class ModelFormField {
>>> }
>>> public FileField(int fieldSource, ModelFormField
>>> modelFormField) {
>>> - super(fieldSource, modelFormField);
>>> + super(fieldSource, FieldInfo.FILE, modelFormField);
>>> }
>>> @Override
>>> @@ -3028,7 +3028,7 @@ public class ModelFormField {
>>> }
>>> public LookupField(int fieldSource, ModelFormField
>>> modelFormField) {
>>> - super(fieldSource, modelFormField);
>>> + super(fieldSource, FieldInfo.LOOKUP, modelFormField);
>>> this.descriptionFieldName = "";
>>> this.fadeBackground = "";
>>> this.formName = FlexibleStringExpander.getInstance("");
>>> @@ -3250,7 +3250,7 @@ public class ModelFormField {
>>> }
>>> public PasswordField(int fieldSource, ModelFormField
>>> modelFormField) {
>>> - super(fieldSource, modelFormField);
>>> + super(fieldSource, FieldInfo.PASSWORD, modelFormField);
>>> }
>>> private PasswordField(PasswordField original,
>>> ModelFormField modelFormField) {
>>>
>>>
>>>
>>
>>
>
>

Jacques Le Roux

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

Administrator

I guess just a mention of the commit, and its reason, in OFBIZ-9577 should be enough

Thanks

Jacques

Le 14/08/2017 à 20:33, Nicolas Malin a écrit :

> Not really, I detect it effectively during some trying related to the OFBIZ-9577but actually I didn't detect any problem with that in the framework.
>
> So I corrected it because it's a easy framework error.
>
> If you think it's interesting to open an issue, I can do that
>
> Nicolas
>
>
> Le 14/08/2017 à 19:49, Jacques Le Roux a écrit :
>> Ha got it OFBIZ-9577
>>
>> Jacques
>>
>> Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :
>>> Good catch Nicolas,
>>>
>>> Should there not be a related Jira?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 14/08/2017 à 17:47, [hidden email] a écrit :
>>>> Author: nmalin
>>>> Date: Mon Aug 14 15:47:36 2017
>>>> New Revision: 1805011
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1805011&view=rev
>>>> Log:
>>>> Fixed: Missing fieldInfo when call constructor for ModelFormField Password, File and Lookup
>>>> When you create a form with an entity or service auto fields, the three previous form field call only "super(fieldSource, modelFormField);" in
>>>> their constructor or this initialise a TextField with the fieldInfo FieldInfo.TEXT.
>>>> I force the field info when the super constructor is called
>>>>
>>>>
>>>> Modified:
>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>
>>>> Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011&r1=1805010&r2=1805011&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java (original)
>>>> +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java Mon Aug 14 15:47:36 2017
>>>> @@ -2096,7 +2096,7 @@ public class ModelFormField {
>>>> }
>>>> public FileField(int fieldSource, ModelFormField modelFormField) {
>>>> - super(fieldSource, modelFormField);
>>>> + super(fieldSource, FieldInfo.FILE, modelFormField);
>>>> }
>>>> @Override
>>>> @@ -3028,7 +3028,7 @@ public class ModelFormField {
>>>> }
>>>> public LookupField(int fieldSource, ModelFormField modelFormField) {
>>>> - super(fieldSource, modelFormField);
>>>> + super(fieldSource, FieldInfo.LOOKUP, modelFormField);
>>>> this.descriptionFieldName = "";
>>>> this.fadeBackground = "";
>>>> this.formName = FlexibleStringExpander.getInstance("");
>>>> @@ -3250,7 +3250,7 @@ public class ModelFormField {
>>>> }
>>>> public PasswordField(int fieldSource, ModelFormField modelFormField) {
>>>> - super(fieldSource, modelFormField);
>>>> + super(fieldSource, FieldInfo.PASSWORD, modelFormField);
>>>> }
>>>> private PasswordField(PasswordField original, ModelFormField modelFormField) {
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
>

Nicolas Malin-2

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

done :)

Le 14/08/2017 à 23:10, Jacques Le Roux a écrit :

> I guess just a mention of the commit, and its reason, in OFBIZ-9577
> should be enough
>
> Thanks
>
> Jacques
>
>
> Le 14/08/2017 à 20:33, Nicolas Malin a écrit :
>> Not really, I detect it effectively during some trying related to the
>> OFBIZ-9577but actually I didn't detect any problem with that in the
>> framework.
>>
>> So I corrected it because it's a easy framework error.
>>
>> If you think it's interesting to open an issue, I can do that
>>
>> Nicolas
>>
>>
>> Le 14/08/2017 à 19:49, Jacques Le Roux a écrit :
>>> Ha got it OFBIZ-9577
>>>
>>> Jacques
>>>
>>> Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :
>>>> Good catch Nicolas,
>>>>
>>>> Should there not be a related Jira?
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 14/08/2017 à 17:47, [hidden email] a écrit :
>>>>> Author: nmalin
>>>>> Date: Mon Aug 14 15:47:36 2017
>>>>> New Revision: 1805011
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1805011&view=rev
>>>>> Log:
>>>>> Fixed: Missing fieldInfo when call constructor for ModelFormField
>>>>> Password, File and Lookup
>>>>> When you create a form with an entity or service auto fields, the
>>>>> three previous form field call only "super(fieldSource,
>>>>> modelFormField);" in their constructor or this initialise a
>>>>> TextField with the fieldInfo FieldInfo.TEXT.
>>>>> I force the field info when the super constructor is called
>>>>>
>>>>>
>>>>> Modified:
>>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>>
>>>>>
>>>>> Modified:
>>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011&r1=1805010&r2=1805011&view=diff
>>>>> ==============================================================================
>>>>>
>>>>> ---
>>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>> (original)
>>>>> +++
>>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>> Mon Aug 14 15:47:36 2017
>>>>> @@ -2096,7 +2096,7 @@ public class ModelFormField {
>>>>> }
>>>>> public FileField(int fieldSource, ModelFormField
>>>>> modelFormField) {
>>>>> - super(fieldSource, modelFormField);
>>>>> + super(fieldSource, FieldInfo.FILE, modelFormField);
>>>>> }
>>>>> @Override
>>>>> @@ -3028,7 +3028,7 @@ public class ModelFormField {
>>>>> }
>>>>> public LookupField(int fieldSource, ModelFormField
>>>>> modelFormField) {
>>>>> - super(fieldSource, modelFormField);
>>>>> + super(fieldSource, FieldInfo.LOOKUP, modelFormField);
>>>>> this.descriptionFieldName = "";
>>>>> this.fadeBackground = "";
>>>>> this.formName = FlexibleStringExpander.getInstance("");
>>>>> @@ -3250,7 +3250,7 @@ public class ModelFormField {
>>>>> }
>>>>> public PasswordField(int fieldSource, ModelFormField
>>>>> modelFormField) {
>>>>> - super(fieldSource, modelFormField);
>>>>> + super(fieldSource, FieldInfo.PASSWORD, modelFormField);
>>>>> }
>>>>> private PasswordField(PasswordField original,
>>>>> ModelFormField modelFormField) {
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
>

Jacques Le Roux

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

Administrator

Thanks Nicolas,

I completed with a quote in OFBIZ-9577 and a mention at the top of the commit comment (as it's in our template, for Michael to refer in the monthly
blog post)

Jacques

Le 14/08/2017 à 23:29, Nicolas Malin a écrit :

> done :)
>
>
> Le 14/08/2017 à 23:10, Jacques Le Roux a écrit :
>> I guess just a mention of the commit, and its reason, in OFBIZ-9577 should be enough
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 14/08/2017 à 20:33, Nicolas Malin a écrit :
>>> Not really, I detect it effectively during some trying related to the OFBIZ-9577but actually I didn't detect any problem with that in the framework.
>>>
>>> So I corrected it because it's a easy framework error.
>>>
>>> If you think it's interesting to open an issue, I can do that
>>>
>>> Nicolas
>>>
>>>
>>> Le 14/08/2017 à 19:49, Jacques Le Roux a écrit :
>>>> Ha got it OFBIZ-9577
>>>>
>>>> Jacques
>>>>
>>>> Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :
>>>>> Good catch Nicolas,
>>>>>
>>>>> Should there not be a related Jira?
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 14/08/2017 à 17:47, [hidden email] a écrit :
>>>>>> Author: nmalin
>>>>>> Date: Mon Aug 14 15:47:36 2017
>>>>>> New Revision: 1805011
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1805011&view=rev
>>>>>> Log:
>>>>>> Fixed: Missing fieldInfo when call constructor for ModelFormField Password, File and Lookup
>>>>>> When you create a form with an entity or service auto fields, the three previous form field call only "super(fieldSource, modelFormField);" in
>>>>>> their constructor or this initialise a TextField with the fieldInfo FieldInfo.TEXT.
>>>>>> I force the field info when the super constructor is called
>>>>>>
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>>>
>>>>>> Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011&r1=1805010&r2=1805011&view=diff
>>>>>> ==============================================================================
>>>>>> --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java (original)
>>>>>> +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java Mon Aug 14 15:47:36 2017
>>>>>> @@ -2096,7 +2096,7 @@ public class ModelFormField {
>>>>>> }
>>>>>> public FileField(int fieldSource, ModelFormField modelFormField) {
>>>>>> - super(fieldSource, modelFormField);
>>>>>> + super(fieldSource, FieldInfo.FILE, modelFormField);
>>>>>> }
>>>>>> @Override
>>>>>> @@ -3028,7 +3028,7 @@ public class ModelFormField {
>>>>>> }
>>>>>> public LookupField(int fieldSource, ModelFormField modelFormField) {
>>>>>> - super(fieldSource, modelFormField);
>>>>>> + super(fieldSource, FieldInfo.LOOKUP, modelFormField);
>>>>>> this.descriptionFieldName = "";
>>>>>> this.fadeBackground = "";
>>>>>> this.formName = FlexibleStringExpander.getInstance("");
>>>>>> @@ -3250,7 +3250,7 @@ public class ModelFormField {
>>>>>> }
>>>>>> public PasswordField(int fieldSource, ModelFormField modelFormField) {
>>>>>> - super(fieldSource, modelFormField);
>>>>>> + super(fieldSource, FieldInfo.PASSWORD, modelFormField);
>>>>>> }
>>>>>> private PasswordField(PasswordField original, ModelFormField modelFormField) {
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
>