Re: svn commit: r1835893 - /ofbiz/ofbiz-framework/trunk/f
Locked
 
|
What do you mean by no functional change? Did you check the two new
requests and event added? On Sat, Jul 14, 2018 at 12:58 PM, <[hidden email]> wrote: > Author: jleroux > Date: Sat Jul 14 09:58:22 2018 > New Revision: 1835893 > > URL: http://svn.apache.org/viewvc?rev=1835893&view=rev > Log: > Improved: no functional change, simply adds XXX tag :) > > Modified: > ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > > Modified: ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml?rev=1835893&r1=1835892&r2=1835893&view=diff > ============================================================================== > --- ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml (original) > +++ ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml Sat Jul 14 09:58:22 2018 > @@ -31,6 +31,7 @@ under the License. > <event name="checkRequestHeaderLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="checkRequestHeaderLogin"/> > <event name="checkServletRequestRemoteUserLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="checkServletRequestRemoteUserLogin"/> > <event name="checkExternalLoginKey" type="java" path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" invoke="checkExternalLoginKey"/> > + <event name="checkExternalServerLogin" type="java" path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" invoke="checkExternalServerLogin"/> > <event name="checkProtectedView" type="java" path="org.apache.ofbiz.webapp.control.ProtectViewWorker" invoke="checkProtectedView"/> > <event name="extensionConnectLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="extensionConnectLogin"/> > </preprocessor> > @@ -257,6 +258,22 @@ under the License. > <response name="error" type="none" /> > </request-map> > > + <!-- Common JavaScript getJwtToken Request, to receive JwtToken within regular JS Code --> > + <request-map uri="getJwtToken"> > + <security https="true" auth="false"/> > + <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="getJwtToken"/> <!-- TODO use later Deepak's createJwt in OFBIZ-9833-JWTManager.patch after complete patch review and test--> > + <response name="success" type="none" /> > + <response name="error" type="none" /> > + </request-map> > + > + <!-- Common JavaScript getAutoUserLoginId Request, to receive autoUserLoginId within regular JS Code --> > + <request-map uri="getAutoUserLoginId"> > + <security https="true" auth="false"/> > + <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="getAutoUserLoginId"/> > + <response name="success" type="none" /> > + <response name="error" type="none" /> > + </request-map> > + > <!-- Check if an UomConversion exists --> > <request-map uri="checkUomConversion"> > <security https="true" auth="false"/> > @@ -301,7 +318,7 @@ under the License. > </request-map> > > <!-- Set TimeZone from user's browser --> > - <!-- the auth setting is inconsistent with the one in the service for a good reason, see OFBIZ-10471 for an explanation --> > + <!-- XXX The auth setting is inconsistent with the one in the service for a good reason, see OFBIZ-10471 for an explanation --> > <request-map uri="SetTimeZoneFromBrowser"> > <security https="false" auth="false"/> > <event type="service" invoke="SetTimeZoneFromBrowser"/> > > |
Re: svn commit: r1835893 - /ofbiz/ofbiz-framework/trunk/f
Administrator
|
See r1835896, 4" after
Jacques Le 15/07/2018 à 18:22, Taher Alkhateeb a écrit : > What do you mean by no functional change? Did you check the two new > requests and event added? > > On Sat, Jul 14, 2018 at 12:58 PM, <[hidden email]> wrote: >> Author: jleroux >> Date: Sat Jul 14 09:58:22 2018 >> New Revision: 1835893 >> >> URL: http://svn.apache.org/viewvc?rev=1835893&view=rev >> Log: >> Improved: no functional change, simply adds XXX tag :) >> >> Modified: >> ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >> >> Modified: ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml?rev=1835893&r1=1835892&r2=1835893&view=diff >> ============================================================================== >> --- ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml (original) >> +++ ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml Sat Jul 14 09:58:22 2018 >> @@ -31,6 +31,7 @@ under the License. >> <event name="checkRequestHeaderLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="checkRequestHeaderLogin"/> >> <event name="checkServletRequestRemoteUserLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="checkServletRequestRemoteUserLogin"/> >> <event name="checkExternalLoginKey" type="java" path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" invoke="checkExternalLoginKey"/> >> + <event name="checkExternalServerLogin" type="java" path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" invoke="checkExternalServerLogin"/> >> <event name="checkProtectedView" type="java" path="org.apache.ofbiz.webapp.control.ProtectViewWorker" invoke="checkProtectedView"/> >> <event name="extensionConnectLogin" type="java" path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="extensionConnectLogin"/> >> </preprocessor> >> @@ -257,6 +258,22 @@ under the License. >> <response name="error" type="none" /> >> </request-map> >> >> + <!-- Common JavaScript getJwtToken Request, to receive JwtToken within regular JS Code --> >> + <request-map uri="getJwtToken"> >> + <security https="true" auth="false"/> >> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="getJwtToken"/> <!-- TODO use later Deepak's createJwt in OFBIZ-9833-JWTManager.patch after complete patch review and test--> >> + <response name="success" type="none" /> >> + <response name="error" type="none" /> >> + </request-map> >> + >> + <!-- Common JavaScript getAutoUserLoginId Request, to receive autoUserLoginId within regular JS Code --> >> + <request-map uri="getAutoUserLoginId"> >> + <security https="true" auth="false"/> >> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" invoke="getAutoUserLoginId"/> >> + <response name="success" type="none" /> >> + <response name="error" type="none" /> >> + </request-map> >> + >> <!-- Check if an UomConversion exists --> >> <request-map uri="checkUomConversion"> >> <security https="true" auth="false"/> >> @@ -301,7 +318,7 @@ under the License. >> </request-map> >> >> <!-- Set TimeZone from user's browser --> >> - <!-- the auth setting is inconsistent with the one in the service for a good reason, see OFBIZ-10471 for an explanation --> >> + <!-- XXX The auth setting is inconsistent with the one in the service for a good reason, see OFBIZ-10471 for an explanation --> >> <request-map uri="SetTimeZoneFromBrowser"> >> <security https="false" auth="false"/> >> <event type="service" invoke="SetTimeZoneFromBrowser"/> >> >> |
|
|
Noted, perhaps you can update the related threads in the future for
reference, I didn't see the connection. Sorry for the noise. On Sun, Jul 15, 2018, 8:03 PM Jacques Le Roux <[hidden email]> wrote: > See r1835896, 4" after > > Jacques > > Le 15/07/2018 à 18:22, Taher Alkhateeb a écrit : > > What do you mean by no functional change? Did you check the two new > > requests and event added? > > > > On Sat, Jul 14, 2018 at 12:58 PM, <[hidden email]> wrote: > >> Author: jleroux > >> Date: Sat Jul 14 09:58:22 2018 > >> New Revision: 1835893 > >> > >> URL: http://svn.apache.org/viewvc?rev=1835893&view=rev > >> Log: > >> Improved: no functional change, simply adds XXX tag :) > >> > >> Modified: > >> > ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > >> > >> Modified: > ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > >> URL: > http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml?rev=1835893&r1=1835892&r2=1835893&view=diff > >> > ============================================================================== > >> --- > ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > (original) > >> +++ > ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml > Sat Jul 14 09:58:22 2018 > >> @@ -31,6 +31,7 @@ under the License. > >> <event name="checkRequestHeaderLogin" type="java" > path="org.apache.ofbiz.webapp.control.LoginWorker" > invoke="checkRequestHeaderLogin"/> > >> <event name="checkServletRequestRemoteUserLogin" type="java" > path="org.apache.ofbiz.webapp.control.LoginWorker" > invoke="checkServletRequestRemoteUserLogin"/> > >> <event name="checkExternalLoginKey" type="java" > path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" > invoke="checkExternalLoginKey"/> > >> + <event name="checkExternalServerLogin" type="java" > path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" > invoke="checkExternalServerLogin"/> > >> <event name="checkProtectedView" type="java" > path="org.apache.ofbiz.webapp.control.ProtectViewWorker" > invoke="checkProtectedView"/> > >> <event name="extensionConnectLogin" type="java" > path="org.apache.ofbiz.webapp.control.LoginWorker" > invoke="extensionConnectLogin"/> > >> </preprocessor> > >> @@ -257,6 +258,22 @@ under the License. > >> <response name="error" type="none" /> > >> </request-map> > >> > >> + <!-- Common JavaScript getJwtToken Request, to receive JwtToken > within regular JS Code --> > >> + <request-map uri="getJwtToken"> > >> + <security https="true" auth="false"/> > >> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" > invoke="getJwtToken"/> <!-- TODO use later Deepak's createJwt in > OFBIZ-9833-JWTManager.patch after complete patch review and test--> > >> + <response name="success" type="none" /> > >> + <response name="error" type="none" /> > >> + </request-map> > >> + > >> + <!-- Common JavaScript getAutoUserLoginId Request, to receive > autoUserLoginId within regular JS Code --> > >> + <request-map uri="getAutoUserLoginId"> > >> + <security https="true" auth="false"/> > >> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" > invoke="getAutoUserLoginId"/> > >> + <response name="success" type="none" /> > >> + <response name="error" type="none" /> > >> + </request-map> > >> + > >> <!-- Check if an UomConversion exists --> > >> <request-map uri="checkUomConversion"> > >> <security https="true" auth="false"/> > >> @@ -301,7 +318,7 @@ under the License. > >> </request-map> > >> > >> <!-- Set TimeZone from user's browser --> > >> - <!-- the auth setting is inconsistent with the one in the service > for a good reason, see OFBIZ-10471 for an explanation --> > >> + <!-- XXX The auth setting is inconsistent with the one in the > service for a good reason, see OFBIZ-10471 for an explanation --> > >> <request-map uri="SetTimeZoneFromBrowser"> > >> <security https="false" auth="false"/> > >> <event type="service" invoke="SetTimeZoneFromBrowser"/> > >> > >> > > |
Re: svn commit: r1835893 - /ofbiz/ofbiz-framework/trunk/f
|
Administrator
|
Yes, if it's an important or big thing... I'll try to remember...
Jacques Le 15/07/2018 à 19:11, Taher Alkhateeb a écrit : > Noted, perhaps you can update the related threads in the future for > reference, I didn't see the connection. Sorry for the noise. > > On Sun, Jul 15, 2018, 8:03 PM Jacques Le Roux <[hidden email]> > wrote: > >> See r1835896, 4" after >> >> Jacques >> >> Le 15/07/2018 à 18:22, Taher Alkhateeb a écrit : >>> What do you mean by no functional change? Did you check the two new >>> requests and event added? >>> >>> On Sat, Jul 14, 2018 at 12:58 PM, <[hidden email]> wrote: >>>> Author: jleroux >>>> Date: Sat Jul 14 09:58:22 2018 >>>> New Revision: 1835893 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1835893&view=rev >>>> Log: >>>> Improved: no functional change, simply adds XXX tag :) >>>> >>>> Modified: >>>> >> ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >>>> Modified: >> ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >>>> URL: >> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml?rev=1835893&r1=1835892&r2=1835893&view=diff >> ============================================================================== >>>> --- >> ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >> (original) >>>> +++ >> ofbiz/ofbiz-framework/trunk/framework/common/webcommon/WEB-INF/common-controller.xml >> Sat Jul 14 09:58:22 2018 >>>> @@ -31,6 +31,7 @@ under the License. >>>> <event name="checkRequestHeaderLogin" type="java" >> path="org.apache.ofbiz.webapp.control.LoginWorker" >> invoke="checkRequestHeaderLogin"/> >>>> <event name="checkServletRequestRemoteUserLogin" type="java" >> path="org.apache.ofbiz.webapp.control.LoginWorker" >> invoke="checkServletRequestRemoteUserLogin"/> >>>> <event name="checkExternalLoginKey" type="java" >> path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" >> invoke="checkExternalLoginKey"/> >>>> + <event name="checkExternalServerLogin" type="java" >> path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager" >> invoke="checkExternalServerLogin"/> >>>> <event name="checkProtectedView" type="java" >> path="org.apache.ofbiz.webapp.control.ProtectViewWorker" >> invoke="checkProtectedView"/> >>>> <event name="extensionConnectLogin" type="java" >> path="org.apache.ofbiz.webapp.control.LoginWorker" >> invoke="extensionConnectLogin"/> >>>> </preprocessor> >>>> @@ -257,6 +258,22 @@ under the License. >>>> <response name="error" type="none" /> >>>> </request-map> >>>> >>>> + <!-- Common JavaScript getJwtToken Request, to receive JwtToken >> within regular JS Code --> >>>> + <request-map uri="getJwtToken"> >>>> + <security https="true" auth="false"/> >>>> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" >> invoke="getJwtToken"/> <!-- TODO use later Deepak's createJwt in >> OFBIZ-9833-JWTManager.patch after complete patch review and test--> >>>> + <response name="success" type="none" /> >>>> + <response name="error" type="none" /> >>>> + </request-map> >>>> + >>>> + <!-- Common JavaScript getAutoUserLoginId Request, to receive >> autoUserLoginId within regular JS Code --> >>>> + <request-map uri="getAutoUserLoginId"> >>>> + <security https="true" auth="false"/> >>>> + <event type="java" path="org.apache.ofbiz.common.CommonEvents" >> invoke="getAutoUserLoginId"/> >>>> + <response name="success" type="none" /> >>>> + <response name="error" type="none" /> >>>> + </request-map> >>>> + >>>> <!-- Check if an UomConversion exists --> >>>> <request-map uri="checkUomConversion"> >>>> <security https="true" auth="false"/> >>>> @@ -301,7 +318,7 @@ under the License. >>>> </request-map> >>>> >>>> <!-- Set TimeZone from user's browser --> >>>> - <!-- the auth setting is inconsistent with the one in the service >> for a good reason, see OFBIZ-10471 for an explanation --> >>>> + <!-- XXX The auth setting is inconsistent with the one in the >> service for a good reason, see OFBIZ-10471 for an explanation --> >>>> <request-map uri="SetTimeZoneFromBrowser"> >>>> <security https="false" auth="false"/> >>>> <event type="service" invoke="SetTimeZoneFromBrowser"/> >>>> >>>> >> |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |