Re: svn commit: r1841675 - /ofbiz/tools/verify-ofbiz-release.sh

[Mathieu Lirzin]

Hello Michael,

[hidden email] writes:

>  # use english gpg output
> -LC_MESSAGES=en_EN.UTF-8
> +export LC_MESSAGES=en_EN.UTF-8

This syntax is a bashism.  I don't know the portability requirements for
this script, but I would recommend using this syntax instead:

  LC_MESSAGES=en_EN.UTF-8
  export LC_MESSAGES

Thanks.

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Michael Brohl-3]

Hi Mathieu,

thanks for the hint!

There is no portability requirement, I once wrote this script to ease
the release checks and shared it with the community.

I changed the code so that there is no need for exporting the setting
anymore.

Regards,

Michael


Am 22.09.18 um 14:41 schrieb Mathieu Lirzin:

> Hello Michael,
>
> [hidden email] writes:
>
>>   # use english gpg output
>> -LC_MESSAGES=en_EN.UTF-8
>> +export LC_MESSAGES=en_EN.UTF-8
> This syntax is a bashism.  I don't know the portability requirements for
> this script, but I would recommend using this syntax instead:
>
>    LC_MESSAGES=en_EN.UTF-8
>    export LC_MESSAGES
>
> Thanks.
>