Re: svn commit: r1852532 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java

[Jacques Le Roux]

Hi Nicolas,

Not in R17?

Jacques

Le 30/01/2019 à 17:18, [hidden email] a écrit :

> Author: nmalin
> Date: Wed Jan 30 16:18:00 2019
> New Revision: 1852532
>
> URL: http://svn.apache.org/viewvc?rev=1852532&view=rev
> Log:
> Fixed: Disable widget verbose property on context doesn't works for rendering ftl template
>
> When OFBiz render a platform specific with a ftl template file, the widget verbosity throw function ModelWidget.widgetBoundary() was called with parameters as context. However this function control if a parameters is already present, so if you set a context.widgetVerbose = false, is was ignored and widget verbosity was present for ftl rendering.
>
> Modified:
>      ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java?rev=1852532&r1=1852531&r2=1852532&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java Wed Jan 30 16:18:00 2019
> @@ -149,8 +149,7 @@ public class HtmlWidget extends ModelScr
>  
>           if (location.endsWith(".ftl")) {
>               try {
> -                Map<String, ? extends Object> parameters = UtilGenerics.checkMap(context.get("parameters"));
> -                boolean insertWidgetBoundaryComments = ModelWidget.widgetBoundaryCommentsEnabled(parameters);
> +                boolean insertWidgetBoundaryComments = ModelWidget.widgetBoundaryCommentsEnabled(context);
>                   if (insertWidgetBoundaryComments) {
>                       writer.append(HtmlWidgetRenderer.formatBoundaryComment("Begin", "Template", location));
>                   }
>
>
>

[Nicolas Malin-2]

Also :),

I will do that

Nicolas

On 30/01/2019 19:55, Jacques Le Roux wrote:

> Hi Nicolas,
>
> Not in R17?
>
> Jacques
>
> Le 30/01/2019 à 17:18, [hidden email] a écrit :
>> Author: nmalin
>> Date: Wed Jan 30 16:18:00 2019
>> New Revision: 1852532
>>
>> URL: http://svn.apache.org/viewvc?rev=1852532&view=rev
>> Log:
>> Fixed: Disable widget verbose property on context doesn't works for
>> rendering ftl template
>>
>> When OFBiz render a platform specific with a ftl template file, the
>> widget verbosity throw function ModelWidget.widgetBoundary() was
>> called with parameters as context. However this function control if a
>> parameters is already present, so if you set a context.widgetVerbose
>> = false, is was ignored and widget verbosity was present for ftl
>> rendering.
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java?rev=1852532&r1=1852531&r2=1852532&view=diff
>> ==============================================================================
>>
>> ---
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>> (original)
>> +++
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>> Wed Jan 30 16:18:00 2019
>> @@ -149,8 +149,7 @@ public class HtmlWidget extends ModelScr
>>             if (location.endsWith(".ftl")) {
>>               try {
>> -                Map<String, ? extends Object> parameters =
>> UtilGenerics.checkMap(context.get("parameters"));
>> -                boolean insertWidgetBoundaryComments =
>> ModelWidget.widgetBoundaryCommentsEnabled(parameters);
>> +                boolean insertWidgetBoundaryComments =
>> ModelWidget.widgetBoundaryCommentsEnabled(context);
>>                   if (insertWidgetBoundaryComments) {
>> writer.append(HtmlWidgetRenderer.formatBoundaryComment("Begin",
>> "Template", location));
>>                   }
>>
>>
>>
>

[Pierre Smits-3]

It is a pity that this commit is not associated with a JIRA ticket. Now
this won't be appear in the monthly blog post, and won't appear in release
notes of upcoming releases of branches 17.12 and 18.12.

Best regards,

Pierre Smits

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer


On Thu, Jan 31, 2019 at 8:22 AM Nicolas Malin <[hidden email]>
wrote:

> Also :),
>
> I will do that
>
> Nicolas
>
> On 30/01/2019 19:55, Jacques Le Roux wrote:
> > Hi Nicolas,
> >
> > Not in R17?
> >
> > Jacques
> >
> > Le 30/01/2019 à 17:18, [hidden email] a écrit :
> >> Author: nmalin
> >> Date: Wed Jan 30 16:18:00 2019
> >> New Revision: 1852532
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1852532&view=rev
> >> Log:
> >> Fixed: Disable widget verbose property on context doesn't works for
> >> rendering ftl template
> >>
> >> When OFBiz render a platform specific with a ftl template file, the
> >> widget verbosity throw function ModelWidget.widgetBoundary() was
> >> called with parameters as context. However this function control if a
> >> parameters is already present, so if you set a context.widgetVerbose
> >> = false, is was ignored and widget verbosity was present for ftl
> >> rendering.
> >>
> >> Modified:
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >>
> >> Modified:
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java?rev=1852532&r1=1852531&r2=1852532&view=diff
> >>
> ==============================================================================
>
> >>
> >> ---
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>
> >> (original)
> >> +++
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>
> >> Wed Jan 30 16:18:00 2019
> >> @@ -149,8 +149,7 @@ public class HtmlWidget extends ModelScr
> >>             if (location.endsWith(".ftl")) {
> >>               try {
> >> -                Map<String, ? extends Object> parameters =
> >> UtilGenerics.checkMap(context.get("parameters"));
> >> -                boolean insertWidgetBoundaryComments =
> >> ModelWidget.widgetBoundaryCommentsEnabled(parameters);
> >> +                boolean insertWidgetBoundaryComments =
> >> ModelWidget.widgetBoundaryCommentsEnabled(context);
> >>                   if (insertWidgetBoundaryComments) {
> >> writer.append(HtmlWidgetRenderer.formatBoundaryComment("Begin",
> >> "Template", location));
> >>                   }
> >>
> >>
> >>
> >
>

[Michael Brohl-3]

This is wrong for the monthly blog posts, they are build from the commit
history.

Michael

Am 31.01.19 um 09:05 schrieb Pierre Smits:

> It is a pity that this commit is not associated with a JIRA ticket. Now
> this won't be appear in the monthly blog post, and won't appear in release
> notes of upcoming releases of branches 17.12 and 18.12.
>
> Best regards,
>
> Pierre Smits
>
>
> On Thu, Jan 31, 2019 at 8:22 AM Nicolas Malin <[hidden email]>
> wrote:
>
>> Also :),
>>
>> I will do that
>>
>> Nicolas
>>
>> On 30/01/2019 19:55, Jacques Le Roux wrote:
>>> Hi Nicolas,
>>>
>>> Not in R17?
>>>
>>> Jacques
>>>
>>> Le 30/01/2019 à 17:18, [hidden email] a écrit :
>>>> Author: nmalin
>>>> Date: Wed Jan 30 16:18:00 2019
>>>> New Revision: 1852532
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1852532&view=rev
>>>> Log:
>>>> Fixed: Disable widget verbose property on context doesn't works for
>>>> rendering ftl template
>>>>
>>>> When OFBiz render a platform specific with a ftl template file, the
>>>> widget verbosity throw function ModelWidget.widgetBoundary() was
>>>> called with parameters as context. However this function control if a
>>>> parameters is already present, so if you set a context.widgetVerbose
>>>> = false, is was ignored and widget verbosity was present for ftl
>>>> rendering.
>>>>
>>>> Modified:
>>>>
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>>>> Modified:
>>>>
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java?rev=1852532&r1=1852531&r2=1852532&view=diff
>> ==============================================================================
>>
>>>> ---
>>>>
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>>
>>>> (original)
>>>> +++
>>>>
>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
>>
>>>> Wed Jan 30 16:18:00 2019
>>>> @@ -149,8 +149,7 @@ public class HtmlWidget extends ModelScr
>>>>              if (location.endsWith(".ftl")) {
>>>>                try {
>>>> -                Map<String, ? extends Object> parameters =
>>>> UtilGenerics.checkMap(context.get("parameters"));
>>>> -                boolean insertWidgetBoundaryComments =
>>>> ModelWidget.widgetBoundaryCommentsEnabled(parameters);
>>>> +                boolean insertWidgetBoundaryComments =
>>>> ModelWidget.widgetBoundaryCommentsEnabled(context);
>>>>                    if (insertWidgetBoundaryComments) {
>>>> writer.append(HtmlWidgetRenderer.formatBoundaryComment("Begin",
>>>> "Template", location));
>>>>                    }
>>>>
>>>>
>>>>

[Pierre Smits-3]

It should be regarded of lesser importance where the entries for blog posts
(especially those about code changes) are gathered from, than what may be
regarded as useful to our current and future adopters. Referencing a JIRA
ticket provides a means to get more context about the issue resolved than
just the single line in blog posts.


Best regards,

Pierre Smits

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer


On Thu, Jan 31, 2019 at 9:37 AM Michael Brohl <[hidden email]>
wrote:

> This is wrong for the monthly blog posts, they are build from the commit
> history.
>
> Michael
>
> Am 31.01.19 um 09:05 schrieb Pierre Smits:
> > It is a pity that this commit is not associated with a JIRA ticket. Now
> > this won't be appear in the monthly blog post, and won't appear in
> release
> > notes of upcoming releases of branches 17.12 and 18.12.
> >
> > Best regards,
> >
> > Pierre Smits
> >
> >
> > On Thu, Jan 31, 2019 at 8:22 AM Nicolas Malin <[hidden email]>
> > wrote:
> >
> >> Also :),
> >>
> >> I will do that
> >>
> >> Nicolas
> >>
> >> On 30/01/2019 19:55, Jacques Le Roux wrote:
> >>> Hi Nicolas,
> >>>
> >>> Not in R17?
> >>>
> >>> Jacques
> >>>
> >>> Le 30/01/2019 à 17:18, [hidden email] a écrit :
> >>>> Author: nmalin
> >>>> Date: Wed Jan 30 16:18:00 2019
> >>>> New Revision: 1852532
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1852532&view=rev
> >>>> Log:
> >>>> Fixed: Disable widget verbose property on context doesn't works for
> >>>> rendering ftl template
> >>>>
> >>>> When OFBiz render a platform specific with a ftl template file, the
> >>>> widget verbosity throw function ModelWidget.widgetBoundary() was
> >>>> called with parameters as context. However this function control if a
> >>>> parameters is already present, so if you set a context.widgetVerbose
> >>>> = false, is was ignored and widget verbosity was present for ftl
> >>>> rendering.
> >>>>
> >>>> Modified:
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >>>> Modified:
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >>>> URL:
> >>>>
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java?rev=1852532&r1=1852531&r2=1852532&view=diff
> >>
> ==============================================================================
> >>
> >>>> ---
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >>
> >>>> (original)
> >>>> +++
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/HtmlWidget.java
> >>
> >>>> Wed Jan 30 16:18:00 2019
> >>>> @@ -149,8 +149,7 @@ public class HtmlWidget extends ModelScr
> >>>>              if (location.endsWith(".ftl")) {
> >>>>                try {
> >>>> -                Map<String, ? extends Object> parameters =
> >>>> UtilGenerics.checkMap(context.get("parameters"));
> >>>> -                boolean insertWidgetBoundaryComments =
> >>>> ModelWidget.widgetBoundaryCommentsEnabled(parameters);
> >>>> +                boolean insertWidgetBoundaryComments =
> >>>> ModelWidget.widgetBoundaryCommentsEnabled(context);
> >>>>                    if (insertWidgetBoundaryComments) {
> >>>> writer.append(HtmlWidgetRenderer.formatBoundaryComment("Begin",
> >>>> "Template", location));
> >>>>                    }
> >>>>
> >>>>
> >>>>
>
>