Re: svn commit: r1858243 - in /ofbiz/ofbiz-plugins/trunk: ecommerce/minilang/customer/CustomerEvents.xml example/template/reports/BarCode.fo.ftl

[Gil Portenseigne]

Hello Suraj,

You commited something about maritalStatus id this commit. I guess its
part of another JIRA.

Regards

Le 06:18 - samedi 27 avril, [hidden email] a écrit :

> Author: surajk
> Date: Sat Apr 27 06:18:17 2019
> New Revision: 1858243
>
> URL: http://svn.apache.org/viewvc?rev=1858243&view=rev
> Log:
> Improved: Use code128 instead of code39 for barcode generation.
> (OFBIZ-10896)
> Currently, we are using code39 to generate barcodes but there are some limitations of code39 as it only able to encrypt letters from A to Z, digits from 0 to 9 and an additional set of special characters – “. $ % + – / *”.
> Thanks Pawan Verma for reporting, analysis and providing the patch. Thanks everyone else for providing their inputs during discussion on Dev ML.
>
> Modified:
>     ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
>     ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
>
> Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml?rev=1858243&r1=1858242&r2=1858243&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml (original)
> +++ ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml Sat Apr 27 06:18:17 2019
> @@ -550,7 +550,7 @@ under the License.
>                  <process field="gender"><copy/></process>
>  
>                  <process field="residenceStatusEnumId"><copy/></process>
> -                <process field="maritalStatus"><copy/></process>
> +                <process field="maritalStatusEnumId"><copy/></process>
>                  <process field="employmentStatusEnumId"><copy/></process>
>                  <process field="occupation"><copy/></process>
>                  <process field="yearsWithEmployer"><convert type="Long"><fail-property resource="EcommerceUiLabels" property="EcommerceYearsWithEmployeeNotValid"/></convert></process>
>
> Modified: ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl?rev=1858243&r1=1858242&r2=1858243&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl (original)
> +++ ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl Sat Apr 27 06:18:17 2019
> @@ -38,10 +38,10 @@ under the License.
>          <fo:instream-foreign-object>
>            <barcode:barcode xmlns:barcode="http://barcode4j.krysalis.org/ns"
>                message="${exampleId}">
> -            <barcode:code39>
> +            <barcode:code128>
>                <barcode:height>0.75in</barcode:height>
>                <barcode:module-width>.375mm</barcode:module-width>
> -            </barcode:code39>
> +            </barcode:code128>
>              <barcode:human-readable>
>                <barcode:placement>bottom</barcode:placement>
>                <barcode:font-name>Helvetica</barcode:font-name>
>
>

[Suraj Khurana-2]

Hello Gil,

Nice catch, I also just noticed that something to commit that I have
already added in code is not available to commit now :)
Anyways, I have also committed related work and both are part of trunk
repository now.

This part is for plugins directory, I think we are good with this.
Still, if you insist, I can revert and split this commit into two different
commits (Three new commits :) )

--
Best Regards,
Suraj Khurana






On Sat, Apr 27, 2019 at 3:25 PM Gil Portenseigne <
[hidden email]> wrote:

> Hello Suraj,
>
> You commited something about maritalStatus id this commit. I guess its
> part of another JIRA.
>
> Regards
>
> Le 06:18 - samedi 27 avril, [hidden email] a écrit :
> > Author: surajk
> > Date: Sat Apr 27 06:18:17 2019
> > New Revision: 1858243
> >
> > URL: http://svn.apache.org/viewvc?rev=1858243&view=rev
> > Log:
> > Improved: Use code128 instead of code39 for barcode generation.
> > (OFBIZ-10896)
> > Currently, we are using code39 to generate barcodes but there are some
> limitations of code39 as it only able to encrypt letters from A to Z,
> digits from 0 to 9 and an additional set of special characters – “. $ % + –
> / *”.
> > Thanks Pawan Verma for reporting, analysis and providing the patch.
> Thanks everyone else for providing their inputs during discussion on Dev ML.
> >
> > Modified:
> >
>  ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
> >     ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
> >
> > Modified:
> ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml?rev=1858243&r1=1858242&r2=1858243&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
> (original)
> > +++
> ofbiz/ofbiz-plugins/trunk/ecommerce/minilang/customer/CustomerEvents.xml
> Sat Apr 27 06:18:17 2019
> > @@ -550,7 +550,7 @@ under the License.
> >                  <process field="gender"><copy/></process>
> >
> >                  <process field="residenceStatusEnumId"><copy/></process>
> > -                <process field="maritalStatus"><copy/></process>
> > +                <process field="maritalStatusEnumId"><copy/></process>
> >                  <process
> field="employmentStatusEnumId"><copy/></process>
> >                  <process field="occupation"><copy/></process>
> >                  <process field="yearsWithEmployer"><convert
> type="Long"><fail-property resource="EcommerceUiLabels"
> property="EcommerceYearsWithEmployeeNotValid"/></convert></process>
> >
> > Modified:
> ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
> > URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl?rev=1858243&r1=1858242&r2=1858243&view=diff
> >
> ==============================================================================
> > --- ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
> (original)
> > +++ ofbiz/ofbiz-plugins/trunk/example/template/reports/BarCode.fo.ftl
> Sat Apr 27 06:18:17 2019
> > @@ -38,10 +38,10 @@ under the License.
> >          <fo:instream-foreign-object>
> >            <barcode:barcode xmlns:barcode="
> http://barcode4j.krysalis.org/ns"
> >                message="${exampleId}">
> > -            <barcode:code39>
> > +            <barcode:code128>
> >                <barcode:height>0.75in</barcode:height>
> >                <barcode:module-width>.375mm</barcode:module-width>
> > -            </barcode:code39>
> > +            </barcode:code128>
> >              <barcode:human-readable>
> >                <barcode:placement>bottom</barcode:placement>
> >                <barcode:font-name>Helvetica</barcode:font-name>
> >
> >
>