Re: svn commit: r1861262 - /ofbiz/ofbiz-plugins/trunk/example/build.gradle

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1861262 - /ofbiz/ofbiz-plugins/trunk/example/build.gradle

Jacques Le Roux
Administrator
Le 13/06/2019 à 16:21, [hidden email] a écrit :

> Author: jleroux
> Date: Thu Jun 13 14:21:48 2019
> New Revision: 1861262
>
> URL: http://svn.apache.org/viewvc?rev=1861262&view=rev
> Log:
> Improved: Update Tomcat to 9.0.21
> (OFBIZ-11102)
>
> Mostly because of various concurrency and stability fixes for HTTP/2 as reported
> in the official announcement
>
> Once again missed to commit in example/build.gradle
>
> Modified:
>      ofbiz/ofbiz-plugins/trunk/example/build.gradle
>
> Modified: ofbiz/ofbiz-plugins/trunk/example/build.gradle
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/example/build.gradle?rev=1861262&r1=1861261&r2=1861262&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/example/build.gradle (original)
> +++ ofbiz/ofbiz-plugins/trunk/example/build.gradle Thu Jun 13 14:21:48 2019
> @@ -18,5 +18,5 @@
>    */
>  
>   dependencies {
> -    pluginLibsCompile 'org.apache.tomcat.embed:tomcat-embed-websocket:9.0.19'
> +    pluginLibsCompile 'org.apache.tomcat.embed:tomcat-embed-websocket:9.0.21'
>   }
> \ No newline at end of file
>
>
Hi,

Reading the initial log comment:

    <<taher  31/07/2016 10:54:26
    Fix and improve the library dependencies in Gradle - OFBIZ-7534

    - Convert many compile dependencies to runtime dependencies in Gradle
    - Move dependencies from framework to specialpurpose
       (only one in example component)
    - put a comment above dependencies which we think should be removed
       completely subject to further testing and confirmation from the
       community.

    After investigating the libs we realized that most of the dependencies
    in OFBiz are runtime rather than compile time. Furthermore, we also
    suspect that many of the runtime dependencies are not needed, however
    further testing is needed before we can confirm and remove them from
    build.gradle>>

Do we really need  this line?

Jacques

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1861262 - /ofbiz/ofbiz-plugins/trunk/example/build.gradle

Jacques Le Roux
Administrator
Sorry, forget it, it's only about websocket here, so needed

Le 13/06/2019 à 16:26, Jacques Le Roux a écrit :

> Le 13/06/2019 à 16:21, [hidden email] a écrit :
>> Author: jleroux
>> Date: Thu Jun 13 14:21:48 2019
>> New Revision: 1861262
>>
>> URL: http://svn.apache.org/viewvc?rev=1861262&view=rev
>> Log:
>> Improved: Update Tomcat to 9.0.21
>> (OFBIZ-11102)
>>
>> Mostly because of various concurrency and stability fixes for HTTP/2 as reported
>> in the official announcement
>>
>> Once again missed to commit in example/build.gradle
>>
>> Modified:
>>      ofbiz/ofbiz-plugins/trunk/example/build.gradle
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/example/build.gradle
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/example/build.gradle?rev=1861262&r1=1861261&r2=1861262&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-plugins/trunk/example/build.gradle (original)
>> +++ ofbiz/ofbiz-plugins/trunk/example/build.gradle Thu Jun 13 14:21:48 2019
>> @@ -18,5 +18,5 @@
>>    */
>>     dependencies {
>> -    pluginLibsCompile 'org.apache.tomcat.embed:tomcat-embed-websocket:9.0.19'
>> +    pluginLibsCompile 'org.apache.tomcat.embed:tomcat-embed-websocket:9.0.21'
>>   }
>> \ No newline at end of file
>>
>>
> Hi,
>
> Reading the initial log comment:
>
>    <<taher  31/07/2016 10:54:26
>    Fix and improve the library dependencies in Gradle - OFBIZ-7534
>
>    - Convert many compile dependencies to runtime dependencies in Gradle
>    - Move dependencies from framework to specialpurpose
>       (only one in example component)
>    - put a comment above dependencies which we think should be removed
>       completely subject to further testing and confirmation from the
>       community.
>
>    After investigating the libs we realized that most of the dependencies
>    in OFBiz are runtime rather than compile time. Furthermore, we also
>    suspect that many of the runtime dependencies are not needed, however
>    further testing is needed before we can confirm and remove them from
>    build.gradle>>
>
> Do we really need  this line?
>
> Jacques
>
>