Re: svn commit: r1862353 - in /ofbiz/ofbiz-framework/trunk: gradle/init-gradle-wrapper.ps1 gradlew gradlew.bat

[Mathieu Lirzin]

Hello Jacques,

[hidden email] writes:

>  # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
> -DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
> +DEFAULT_JVM_OPTS='"-Xmx64m"

In fact there was no repetition here.  “Xms” and “Xmx” are different
options corresponding respectively to the “initial heap size” and the
“max heap size”.

It was added automatically when doing the upgrade with the ‘./gradlew
wrapper ...’ command, so I guess we should keep both options which are
Gradle recommended defaults.

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Jacques Le Roux]

Le 30/06/2019 à 18:57, Mathieu Lirzin a écrit :

> Hello Jacques,
>
> [hidden email] writes:
>
>>   # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
>> -DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
>> +DEFAULT_JVM_OPTS='"-Xmx64m"
> In fact there was no repetition here.  “Xms” and “Xmx” are different
> options corresponding respectively to the “initial heap size” and the
> “max heap size”.
>
> It was added automatically when doing the upgrade with the ‘./gradlew
> wrapper ...’ command, so I guess we should keep both options which are
> Gradle recommended defaults.

Hi Mathieu,

We crossed on wire, you are right. I just spotted it while reusing gradlew which puts it there again. I really fixed it again!

Sorry for the noise

Jacques