Re: svn commit: r1864215 - in /ofbiz/ofbiz-framework/trunk/applications/party: servicedef/services_upgrade.xml src/main/java/org/apache/ofbiz/party/party/UpgradeServices.java

[Mathieu Lirzin]

Hello Pawan,

[hidden email] writes:

> Author: pawan
> Date: Fri Aug  2 10:36:33 2019
> New Revision: 1864215
>
> URL: http://svn.apache.org/viewvc?rev=1864215&view=rev
> Log:
> [Implemented]: Provide a service for moving data for marital status field (from boolean to enum)
> [OFBIZ-10977]
> Migrate Person's marital status from indicator to enumeration
> Since revision 1858261(27 April 2019) field oldMaritalStatus of Person has been deprecated.
> This service can be used to upgrade existing data of oldMaritalStatus field to the new maritalStatusEnumId
> field of Person Entity.
> [Thanks]: Suraj Khurana for your contribution and Jacques Le Roux for the review.

I don't know if this is intentional or just a misinterpretation but this commit
message doesn't follow the OFBiz commit guidelines [1].

It should have been something like:

--8<---------------cut here---------------start------------->8---
Implemented: Provide a service for moving data for marital status field
(OFBIZ-10977)

Migrate Person's marital status from indicator to enumeration Since revision
1858261(27 April 2019) field oldMaritalStatus of Person has been deprecated.
This service can be used to upgrade existing data of oldMaritalStatus field to
the new maritalStatusEnumId field of Person Entity.

Thanks: Suraj Khurana for your contribution and Jacques Le Roux for the review.
--8<---------------cut here---------------end--------------->8---

Please follow those guidelines next time.

Thanks.

[1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Pawan Verma]

Thanks, Mathieu for the review. I will be more careful next time.

--
Thanks & Regards
Pawan Verma
Technical Consultant
*HotWax Systems*
*Enterprise open source experts*
http://www.hotwaxsystems.com


On Sun, Aug 4, 2019 at 3:44 AM Mathieu Lirzin <[hidden email]>
wrote:

> Hello Pawan,
>
> [hidden email] writes:
>
> > Author: pawan
> > Date: Fri Aug  2 10:36:33 2019
> > New Revision: 1864215
> >
> > URL: http://svn.apache.org/viewvc?rev=1864215&view=rev
> > Log:
> > [Implemented]: Provide a service for moving data for marital status
> field (from boolean to enum)
> > [OFBIZ-10977]
> > Migrate Person's marital status from indicator to enumeration
> > Since revision 1858261(27 April 2019) field oldMaritalStatus of Person
> has been deprecated.
> > This service can be used to upgrade existing data of oldMaritalStatus
> field to the new maritalStatusEnumId
> > field of Person Entity.
> > [Thanks]: Suraj Khurana for your contribution and Jacques Le Roux for
> the review.
>
> I don't know if this is intentional or just a misinterpretation but this
> commit
> message doesn't follow the OFBiz commit guidelines [1].
>
> It should have been something like:
>
> --8<---------------cut here---------------start------------->8---
> Implemented: Provide a service for moving data for marital status field
> (OFBIZ-10977)
>
> Migrate Person's marital status from indicator to enumeration Since
> revision
> 1858261(27 April 2019) field oldMaritalStatus of Person has been
> deprecated.
> This service can be used to upgrade existing data of oldMaritalStatus
> field to
> the new maritalStatusEnumId field of Person Entity.
>
> Thanks: Suraj Khurana for your contribution and Jacques Le Roux for the
> review.
> --8<---------------cut here---------------end--------------->8---
>
> Please follow those guidelines next time.
>
> Thanks.
>
> [1]
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>