Re: svn commit: r552656 - /ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r552656 - /ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml

David E Jones-2

Thanks for fixing that Jacques.

BTW, the best solution to this sort of thing is to used escaped characters. For example, use "&lt;" instead of "<" and "&gt;" instead of ">".

BTW2, the common term for ">" in English is "Greater Than" and the common term for "<" in English is "Less Than".

-David


[hidden email] wrote:

> Author: jleroux
> Date: Mon Jul  2 20:03:57 2007
> New Revision: 552656
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=552656
> Log:
> < and >= in descriptions were preventing correct load of the services
>
> Modified:
>     ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
>
> Modified: ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml?view=diff&rev=552656&r1=552655&r2=552656
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml (original)
> +++ ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml Mon Jul  2 20:03:57 2007
> @@ -18,7 +18,7 @@
>  under the License.
>  -->
>  
> -<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>          xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/services.xsd">
>      <description>Accounting Services</description>
>      <vendor>OFBiz</vendor>
> @@ -229,7 +229,7 @@
>          <description>(Batch) Retries failed authorizations due to NSF (Not Sufficient Funds); these are for auto-orders</description>
>          <!-- this service has no parameters IN or OUT -->
>      </service>
> -    
> +
>      <service name="authOrderPaymentPreference" engine="java"
>              location="org.ofbiz.accounting.payment.PaymentGatewayServices" invoke="authOrderPaymentPreference" auth="true">
>          <description>Process (authorizes/re-authorizes) a single payment for an order with an optional overrideAmount</description>
> @@ -304,7 +304,7 @@
>              location="org.ofbiz.accounting.payment.PaymentGatewayServices" invoke="processCaptureSplitPayment" auth="true">
>          <description>Handles the creation of new OrderPaymentPreference record (and Auth) for partial captures</description>
>          <attribute name="orderPaymentPreference" type="GenericValue" mode="IN" optional="false"/>
> -        <attribute name="splitAmount" type="BigDecimal" mode="IN" optional="false"/>
> +        <attribute name="splitAmount" type="BigDecimal" mode="IN" optional="false"/>
>      </service>
>  
>      <service name="refundPayment" engine="java"
> @@ -538,12 +538,12 @@
>      <!-- Test Credit Card (CC) Requests -->
>      <service name="testCCProcessor" engine="java"
>              location="org.ofbiz.accounting.payment.PaymentGatewayServices" invoke="testProcessor">
> -        <description>Test Credit Card Auth Processing: declines auth requests for all orders < 100.00; approves auth requests for all orders >= 100.00</description>
> +        <description>Test Credit Card Auth Processing: declines auth requests for all orders inf. to 100.00; approves auth requests for all orders sup. or equal to 100.00</description>
>          <implements service="ccAuthInterface"/>
>      </service>
>      <service name="testCCProcessorWithCapture" engine="java"
>              location="org.ofbiz.accounting.payment.PaymentGatewayServices" invoke="testProcessorWithCapture">
> -        <description>Test Credit Card Auth Processing: declines auth requests for all orders < 100.00; approves auth requests for all orders >= 100.00</description>
> +        <description>Test Credit Card Auth Processing: declines auth requests for all orders inf. to  100.00; approves auth requests for all orders sup. or equal to  100.00</description>
>          <implements service="ccAuthInterface"/>
>      </service>
>      <service name="testRandomAuthorize" engine="java"
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r552656 - /ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml

Jacopo Cappellato
Sorry for this error and thanks to Jacques for fixing it.
In rev. I've further improved the services' descriptions following
David's suggestion.

Jacopo


David E Jones wrote:

>
> Thanks for fixing that Jacques.
>
> BTW, the best solution to this sort of thing is to used escaped
> characters. For example, use "&lt;" instead of "<" and "&gt;" instead of
> ">".
>
> BTW2, the common term for ">" in English is "Greater Than" and the
> common term for "<" in English is "Less Than".
>
> -David
>
>
> [hidden email] wrote:
>> Author: jleroux
>> Date: Mon Jul  2 20:03:57 2007
>> New Revision: 552656
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=552656
>> Log:
>> < and >= in descriptions were preventing correct load of the services
>>
>> Modified:
>>    
>> ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml?view=diff&rev=552656&r1=552655&r2=552656 
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
>> Mon Jul  2 20:03:57 2007
>> @@ -18,7 +18,7 @@
>>  under the License.
>>  -->
>>  
>> -<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>> +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>          
>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/services.xsd">
>>
>>      <description>Accounting Services</description>
>>      <vendor>OFBiz</vendor>
>> @@ -229,7 +229,7 @@
>>          <description>(Batch) Retries failed authorizations due to NSF
>> (Not Sufficient Funds); these are for auto-orders</description>
>>          <!-- this service has no parameters IN or OUT -->
>>      </service>
>> -    +
>>      <service name="authOrderPaymentPreference" engine="java"
>>              
>> location="org.ofbiz.accounting.payment.PaymentGatewayServices"
>> invoke="authOrderPaymentPreference" auth="true">
>>          <description>Process (authorizes/re-authorizes) a single
>> payment for an order with an optional overrideAmount</description>
>> @@ -304,7 +304,7 @@
>>              
>> location="org.ofbiz.accounting.payment.PaymentGatewayServices"
>> invoke="processCaptureSplitPayment" auth="true">
>>          <description>Handles the creation of new
>> OrderPaymentPreference record (and Auth) for partial
>> captures</description>
>>          <attribute name="orderPaymentPreference" type="GenericValue"
>> mode="IN" optional="false"/>
>> -        <attribute name="splitAmount" type="BigDecimal" mode="IN"
>> optional="false"/> +        <attribute name="splitAmount"
>> type="BigDecimal" mode="IN" optional="false"/>
>>      </service>
>>  
>>      <service name="refundPayment" engine="java"
>> @@ -538,12 +538,12 @@
>>      <!-- Test Credit Card (CC) Requests -->
>>      <service name="testCCProcessor" engine="java"
>>              
>> location="org.ofbiz.accounting.payment.PaymentGatewayServices"
>> invoke="testProcessor">
>> -        <description>Test Credit Card Auth Processing: declines auth
>> requests for all orders < 100.00; approves auth requests for all
>> orders >= 100.00</description>
>> +        <description>Test Credit Card Auth Processing: declines auth
>> requests for all orders inf. to 100.00; approves auth requests for all
>> orders sup. or equal to 100.00</description>
>>          <implements service="ccAuthInterface"/>
>>      </service>
>>      <service name="testCCProcessorWithCapture" engine="java"
>>              
>> location="org.ofbiz.accounting.payment.PaymentGatewayServices"
>> invoke="testProcessorWithCapture">
>> -        <description>Test Credit Card Auth Processing: declines auth
>> requests for all orders < 100.00; approves auth requests for all
>> orders >= 100.00</description>
>> +        <description>Test Credit Card Auth Processing: declines auth
>> requests for all orders inf. to  100.00; approves auth requests for
>> all orders sup. or equal to  100.00</description>
>>          <implements service="ccAuthInterface"/>
>>      </service>
>>      <service name="testRandomAuthorize" engine="java"
>>
>>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r552656 - /ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml

Jacques Le Roux
Administrator
In reply to this post by David E Jones-2
Hi David, Jacopo,

Yes, my first intention was to use "&lt;" and "&gt;". But as this was not much readable in the file, I thought that it might be
better to use a literal. Then my mother tongue superseded my almost awoke brain. What a story ;o)

Jacques


De : "David E Jones" <[hidden email]>
>
> Thanks for fixing that Jacques.
>
> BTW, the best solution to this sort of thing is to used escaped characters. For example, use "&lt;" instead of "<" and "&gt;"
instead of ">".

>
> BTW2, the common term for ">" in English is "Greater Than" and the common term for "<" in English is "Less Than".
>
> -David
>
>
> [hidden email] wrote:
> > Author: jleroux
> > Date: Mon Jul  2 20:03:57 2007
> > New Revision: 552656
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=552656
> > Log:
> > < and >= in descriptions were preventing correct load of the services
> >