Re: svn commit: r567431 - /ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r567431 - /ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java

Jacopo Cappellato
In my opinion, we should not apply this kind of changes to the release...

Jacopo



[hidden email] wrote:

> Author: jleroux
> Date: Sun Aug 19 10:17:26 2007
> New Revision: 567431
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=567431
> Log:
> Applied fix from trunk for revision: 567429
>
> Removed:
>     ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r567431 - /ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java

David E Jones

Yeah, I agree. Anything that is debatable in the trunk definitely shouldn't go in the release.

And that's aside from the fact that this isn't a BUG FIX, and only BUG FIXES should go into the release branch. The point is stability, not cleanliness (refactoring and improving things is great, but those aren't bug fixes).

-David


Jacopo Cappellato wrote:

> In my opinion, we should not apply this kind of changes to the release...
>
> Jacopo
>
>
>
> [hidden email] wrote:
>> Author: jleroux
>> Date: Sun Aug 19 10:17:26 2007
>> New Revision: 567431
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=567431
>> Log:
>> Applied fix from trunk for revision: 567429
>>
>> Removed:
>>    
>> ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r567431 - /ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java

Jacques Le Roux
Administrator
Ok, I agree. I wondered, and eventually I thought that cleaning also the release might be a good thing. I put it back right now.

Jacques

De : "David E Jones" <[hidden email]>
>
> Yeah, I agree. Anything that is debatable in the trunk definitely shouldn't go in the release.
>
> And that's aside from the fact that this isn't a BUG FIX, and only BUG FIXES should go into the release branch. The point is
stability, not cleanliness (refactoring and improving things is great, but those aren't bug fixes).

>
> -David
>
>
> Jacopo Cappellato wrote:
> > In my opinion, we should not apply this kind of changes to the release...
> >
> > Jacopo
> >
> >
> >
> > [hidden email] wrote:
> >> Author: jleroux
> >> Date: Sun Aug 19 10:17:26 2007
> >> New Revision: 567431
> >>
> >> URL: http://svn.apache.org/viewvc?view=rev&rev=567431
> >> Log:
> >> Applied fix from trunk for revision: 567429
> >>
> >> Removed:
> >>
> >> ofbiz/branches/release4.0/framework/base/src/base/org/ofbiz/base/util/template/FtlTransform.java
> >>
> >
> >