Re: svn commit: r593709 - /ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r593709 - /ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl

BJ Freeman
address1 on can have a space in the address.
seems a better way would be to use test for alphanumeric in address1

[hidden email] sent the following on 11/9/2007 5:23 PM:

> Author: jonesde
> Date: Fri Nov  9 17:23:20 2007
> New Revision: 593709
>
> URL: http://svn.apache.org/viewvc?rev=593709&view=rev
> Log:
> Fixed problem when address1 is empty
>
> Modified:
>     ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl
>
> Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl?rev=593709&r1=593708&r2=593709&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl (original)
> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl Fri Nov  9 17:23:20 2007
> @@ -76,7 +76,7 @@
>                    </div>
>                    <#if (postalAddress?has_content && !postalAddress.countryGeoId?has_content) || postalAddress.countryGeoId = "USA">
>                      <#assign addr1 = postalAddress.address1?if_exists>
> -                    <#if (addr1.indexOf(" ") > 0)>
> +                    <#if addr1?has_content && (addr1.indexOf(" ") > 0)>
>                        <#assign addressNum = addr1.substring(0, addr1.indexOf(" "))>
>                        <#assign addressOther = addr1.substring(addr1.indexOf(" ")+1)>
>                        <a target="_blank" href="http://www.whitepages.com/find_person_results.pl?fid=a&s_n=${addressNum}&s_a=${addressOther}&c=${postalAddress.city?if_exists}&s=${postalAddress.stateProvinceGeoId?if_exists}&x=29&y=18">(lookup:whitepages.com)</a>
>
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r593709 - /ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl

Jacques Le Roux
Administrator
BJ,

I can't see any problems using standard ways of writing addresses. Have you an example with an issue ?

Jacques

> address1 on can have a space in the address.
> seems a better way would be to use test for alphanumeric in address1
>
> [hidden email] sent the following on 11/9/2007 5:23 PM:
> > Author: jonesde
> > Date: Fri Nov  9 17:23:20 2007
> > New Revision: 593709
> >
> > URL: http://svn.apache.org/viewvc?rev=593709&view=rev
> > Log:
> > Fixed problem when address1 is empty
> >
> > Modified:
> >     ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl
> >
> > Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl
> > URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl?rev=593709&r1=593708&r2=593709&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl (original)
> > +++ ofbiz/trunk/applications/party/webapp/partymgr/party/profileblocks/Contact.ftl Fri Nov  9 17:23:20 2007
> > @@ -76,7 +76,7 @@
> >                    </div>
> >                    <#if (postalAddress?has_content && !postalAddress.countryGeoId?has_content) || postalAddress.countryGeoId =
"USA">
> >                      <#assign addr1 = postalAddress.address1?if_exists>
> > -                    <#if (addr1.indexOf(" ") > 0)>
> > +                    <#if addr1?has_content && (addr1.indexOf(" ") > 0)>
> >                        <#assign addressNum = addr1.substring(0, addr1.indexOf(" "))>
> >                        <#assign addressOther = addr1.substring(addr1.indexOf(" ")+1)>
> >                        <a target="_blank"
href="http://www.whitepages.com/find_person_results.pl?fid=a&s_n=${addressNum}&s_a=${addressOther}&c=${postalAddress.city?if_exists}
&s=${postalAddress.stateProvinceGeoId?if_exists}&x=29&y=18">(lookup:whitepages.com)</a>
> >
> >
> >
> >
> >
>