Administrator
|
Thanks Bilgin,
Just before commiting I used the automatic refactoring option in Eclipse but it ended in a mess (adding a loot of import java.util classes in place of import java.util.* for instance). So I reverted this part, forgeting the Security call I added previously on Chris's advice. Don't worry it's well tested, I sent myself a message using Gmail and received it. Jacques From: <[hidden email]> > URL: http://svn.apache.org/viewvc?rev=606794&view=rev > Log: > Added the missing import for r606789. > > Modified: > ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java > > Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794&r1=606793&r2=606794&view=diff > ============================================================================== > --- ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (original) > +++ ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Tue Dec 25 07:30:14 2007 > @@ -59,6 +59,7 @@ > import java.net.URL; > import java.sql.Timestamp; > import java.util.*; > +import java.security.Security; > > /** > * Email Services > > > |
side note, if you have a large library that does not get implemented
like java.util.* using the individual calls saves memory. it is a trade off between load speed and memory usage. Jacques Le Roux sent the following on 12/25/2007 8:54 AM: > Thanks Bilgin, > > Just before commiting I used the automatic refactoring option in Eclipse > but it ended in a mess (adding a loot of import java.util classes in > place of import java.util.* for instance). So I reverted this part, > forgeting the Security call I added previously on Chris's advice. > Don't worry it's well tested, I sent myself a message using Gmail and > received it. > > Jacques > > From: <[hidden email]> >> URL: http://svn.apache.org/viewvc?rev=606794&view=rev >> Log: >> Added the missing import for r606789. >> >> Modified: >> >> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >> >> >> Modified: >> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >> >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794&r1=606793&r2=606794&view=diff >> >> ============================================================================== >> >> --- >> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >> (original) >> +++ >> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >> Tue Dec 25 07:30:14 2007 >> @@ -59,6 +59,7 @@ >> import java.net.URL; >> import java.sql.Timestamp; >> import java.util.*; >> +import java.security.Security; >> >> /** >> * Email Services >> >> >> > > > > |
Administrator
|
My main motivation was to change as less as possible code, to make reviews easier...
Jacques ----- Original Message ----- From: "BJ Freeman" <[hidden email]> To: <[hidden email]> Sent: Tuesday, December 25, 2007 8:27 PM Subject: Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java > side note, if you have a large library that does not get implemented > like java.util.* using the individual calls saves memory. > it is a trade off between load speed and memory usage. > > Jacques Le Roux sent the following on 12/25/2007 8:54 AM: >> Thanks Bilgin, >> >> Just before commiting I used the automatic refactoring option in Eclipse >> but it ended in a mess (adding a loot of import java.util classes in >> place of import java.util.* for instance). So I reverted this part, >> forgeting the Security call I added previously on Chris's advice. >> Don't worry it's well tested, I sent myself a message using Gmail and >> received it. >> >> Jacques >> >> From: <[hidden email]> >>> URL: http://svn.apache.org/viewvc?rev=606794&view=rev >>> Log: >>> Added the missing import for r606789. >>> >>> Modified: >>> >>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>> >>> >>> Modified: >>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>> >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794&r1=606793&r2=606794&view=diff >>> >>> ============================================================================== >>> >>> --- >>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>> (original) >>> +++ >>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>> Tue Dec 25 07:30:14 2007 >>> @@ -59,6 +59,7 @@ >>> import java.net.URL; >>> import java.sql.Timestamp; >>> import java.util.*; >>> +import java.security.Security; >>> >>> /** >>> * Email Services >>> >>> >>> >> >> >> >> > > |
Thanks for the explanation.
Jacques Le Roux sent the following on 12/25/2007 12:17 PM: > My main motivation was to change as less as possible code, to make > reviews easier... > > Jacques > > ----- Original Message ----- From: "BJ Freeman" <[hidden email]> > To: <[hidden email]> > Sent: Tuesday, December 25, 2007 8:27 PM > Subject: Re: Import libraries was svn commit: r606794 - > /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java > > > >> side note, if you have a large library that does not get implemented >> like java.util.* using the individual calls saves memory. >> it is a trade off between load speed and memory usage. >> >> Jacques Le Roux sent the following on 12/25/2007 8:54 AM: >>> Thanks Bilgin, >>> >>> Just before commiting I used the automatic refactoring option in Eclipse >>> but it ended in a mess (adding a loot of import java.util classes in >>> place of import java.util.* for instance). So I reverted this part, >>> forgeting the Security call I added previously on Chris's advice. >>> Don't worry it's well tested, I sent myself a message using Gmail and >>> received it. >>> >>> Jacques >>> >>> From: <[hidden email]> >>>> URL: http://svn.apache.org/viewvc?rev=606794&view=rev >>>> Log: >>>> Added the missing import for r606789. >>>> >>>> Modified: >>>> >>>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>>> >>>> >>>> >>>> Modified: >>>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>>> >>>> >>>> URL: >>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794&r1=606793&r2=606794&view=diff >>>> >>>> >>>> ============================================================================== >>>> >>>> >>>> --- >>>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>>> >>>> (original) >>>> +++ >>>> ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java >>>> >>>> Tue Dec 25 07:30:14 2007 >>>> @@ -59,6 +59,7 @@ >>>> import java.net.URL; >>>> import java.sql.Timestamp; >>>> import java.util.*; >>>> +import java.security.Security; >>>> >>>> /** >>>> * Email Services >>>> >>>> >>>> >>> >>> >>> >>> >> >> > > > > |
Free forum by Nabble | Edit this page |