Re: svn commit: r609268 - /ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml

[Scott Gray]

Hi Hans

Its not that simple unfortunately, I think at least one phone number is
required, not specifically the home phone number.

Personally, I don't see the point in requiring a phone number at all (in the
back end anyway).

Regards
Scott

On 06/01/2008, [hidden email] <[hidden email]> wrote:

>
> Author: hansbak
> Date: Sat Jan  5 23:55:07 2008
> New Revision: 609268
>
> URL: http://svn.apache.org/viewvc?rev=609268&view=rev
> Log:
> contact tel required in validation, but not on the form: added
>
> Modified:
>     ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
>
> Modified:
> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml?rev=609268&r1=609267&r2=609268&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> (original)
> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> Sat Jan  5 23:55:07 2008
> @@ -322,7 +322,7 @@
>          <field name="HomePhoneTitle" title="${uiLabelMap.PartyHomePhone}"
> title-area-style="group-label"><display description=" "
> also-hidden="false"/></field>
>          <field name="USER_HOME_COUNTRY" title="${
> uiLabelMap.PartyCountryCode}"><text size="4" maxlength="10"/></field>
>          <field name="USER_HOME_AREA" title="${uiLabelMap.PartyAreaCode}"><text
> size="4" maxlength="10"/></field>
> -        <field name="USER_HOME_CONTACT" title="${
> uiLabelMap.PartyPhoneNumber}"><text size="15" maxlength="15"/></field>
> +        <field name="USER_HOME_CONTACT" title="${
> uiLabelMap.PartyPhoneNumber}" tooltip="${uiLabelMap.CommonRequired}"
> widget-style="required"><text size="15" maxlength="15"/></field>
>          <field name="USER_HOME_EXT" title="${uiLabelMap.PartyContactExt}"><text
> size="6" maxlength="10"/></field>
>          <field name="USER_HOME_ALLOW_SOL" title="${
> uiLabelMap.PartyContactAllowSolicitation}?"><drop-down
> allow-empty="true"><option key="Y" description="${uiLabelMap.CommonY}"/><option
> key="N" description="${uiLabelMap.CommonN}"/></drop-down></field>
>          <field name="WorkPhoneTitle" title="${
> uiLabelMap.PartyContactWorkPhoneNumber}"
> title-area-style="group-label"><display description=" "
> also-hidden="false"/></field>
>
>
>

[hans_bakker]

I simply added it because it is strange to be asked for a telephone
number but not indicated at the form esspecially if there are more
telephone numbers....


On Sun, 2008-01-06 at 21:20 +1300, Scott Gray wrote:

> Hi Hans
>
> Its not that simple unfortunately, I think at least one phone number is
> required, not specifically the home phone number.
>
> Personally, I don't see the point in requiring a phone number at all (in the
> back end anyway).
>
> Regards
> Scott
>
> On 06/01/2008, [hidden email] <[hidden email]> wrote:
> >
> > Author: hansbak
> > Date: Sat Jan  5 23:55:07 2008
> > New Revision: 609268
> >
> > URL: http://svn.apache.org/viewvc?rev=609268&view=rev
> > Log:
> > contact tel required in validation, but not on the form: added
> >
> > Modified:
> >     ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> >
> > Modified:
> > ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > URL:
> > http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml?rev=609268&r1=609267&r2=609268&view=diff
> >
> > ==============================================================================
> > --- ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > (original)
> > +++ ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > Sat Jan  5 23:55:07 2008
> > @@ -322,7 +322,7 @@
> >          <field name="HomePhoneTitle" title="${uiLabelMap.PartyHomePhone}"
> > title-area-style="group-label"><display description=" "
> > also-hidden="false"/></field>
> >          <field name="USER_HOME_COUNTRY" title="${
> > uiLabelMap.PartyCountryCode}"><text size="4" maxlength="10"/></field>
> >          <field name="USER_HOME_AREA" title="${uiLabelMap.PartyAreaCode}"><text
> > size="4" maxlength="10"/></field>
> > -        <field name="USER_HOME_CONTACT" title="${
> > uiLabelMap.PartyPhoneNumber}"><text size="15" maxlength="15"/></field>
> > +        <field name="USER_HOME_CONTACT" title="${
> > uiLabelMap.PartyPhoneNumber}" tooltip="${uiLabelMap.CommonRequired}"
> > widget-style="required"><text size="15" maxlength="15"/></field>
> >          <field name="USER_HOME_EXT" title="${uiLabelMap.PartyContactExt}"><text
> > size="6" maxlength="10"/></field>
> >          <field name="USER_HOME_ALLOW_SOL" title="${
> > uiLabelMap.PartyContactAllowSolicitation}?"><drop-down
> > allow-empty="true"><option key="Y" description="${uiLabelMap.CommonY}"/><option
> > key="N" description="${uiLabelMap.CommonN}"/></drop-down></field>
> >          <field name="WorkPhoneTitle" title="${
> > uiLabelMap.PartyContactWorkPhoneNumber}"
> > title-area-style="group-label"><display description=" "
> > also-hidden="false"/></field>
> >
> >
> >

[Scott Gray]

Yes but the home phone number is not actually required if for example you
enter a work phone instead.
The form needs a label with something like: You must enter at least one of
the following phone numbers

Regards
Scott

On 06/01/2008, Hans Bakker <[hidden email]> wrote:

>
> I simply added it because it is strange to be asked for a telephone
> number but not indicated at the form esspecially if there are more
> telephone numbers....
>
>
> On Sun, 2008-01-06 at 21:20 +1300, Scott Gray wrote:
> > Hi Hans
> >
> > Its not that simple unfortunately, I think at least one phone number is
> > required, not specifically the home phone number.
> >
> > Personally, I don't see the point in requiring a phone number at all (in
> the
> > back end anyway).
> >
> > Regards
> > Scott
> >
> > On 06/01/2008, [hidden email] <[hidden email]> wrote:
> > >
> > > Author: hansbak
> > > Date: Sat Jan  5 23:55:07 2008
> > > New Revision: 609268
> > >
> > > URL: http://svn.apache.org/viewvc?rev=609268&view=rev
> > > Log:
> > > contact tel required in validation, but not on the form: added
> > >
> > > Modified:
> > >
> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > >
> > > Modified:
> > > ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > > URL:
> > >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml?rev=609268&r1=609267&r2=609268&view=diff
> > >
> > >
> ==============================================================================
> > > ---
> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > > (original)
> > > +++
> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> > > Sat Jan  5 23:55:07 2008
> > > @@ -322,7 +322,7 @@
> > >          <field name="HomePhoneTitle" title="${
> uiLabelMap.PartyHomePhone}"
> > > title-area-style="group-label"><display description=" "
> > > also-hidden="false"/></field>
> > >          <field name="USER_HOME_COUNTRY" title="${
> > > uiLabelMap.PartyCountryCode}"><text size="4" maxlength="10"/></field>
> > >          <field name="USER_HOME_AREA" title="${
> uiLabelMap.PartyAreaCode}"><text
> > > size="4" maxlength="10"/></field>
> > > -        <field name="USER_HOME_CONTACT" title="${
> > > uiLabelMap.PartyPhoneNumber}"><text size="15" maxlength="15"/></field>
> > > +        <field name="USER_HOME_CONTACT" title="${
> > > uiLabelMap.PartyPhoneNumber}" tooltip="${uiLabelMap.CommonRequired}"
> > > widget-style="required"><text size="15" maxlength="15"/></field>
> > >          <field name="USER_HOME_EXT" title="${
> uiLabelMap.PartyContactExt}"><text
> > > size="6" maxlength="10"/></field>
> > >          <field name="USER_HOME_ALLOW_SOL" title="${
> > > uiLabelMap.PartyContactAllowSolicitation}?"><drop-down
> > > allow-empty="true"><option key="Y" description="${uiLabelMap.CommonY
> }"/><option
> > > key="N" description="${uiLabelMap.CommonN}"/></drop-down></field>
> > >          <field name="WorkPhoneTitle" title="${
> > > uiLabelMap.PartyContactWorkPhoneNumber}"
> > > title-area-style="group-label"><display description=" "
> > > also-hidden="false"/></field>
> > >
> > >
> > >
>
>