Re: svn commit: r662847 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: html/HtmlTreeRenderer.java tree/ModelTree.java tree/ModelTreeAction.java tree/ModelTreeCondition.java tree/TreeFactory.java tree/TreeStringRenderer.java

[David E Jones-2]

Wow, thanks for doing this Adrian. This code has been neglected for a  
long time, really from the beginning I'd say. I worked with Al a bit  
on the design of the XML file for it, and he implemented the whole  
thing and I haven't really looked at it since then. I'm glad there  
were just a few issues with it... it'll be a great tool especially  
once it is "super-AJAX-ed". ;)

-David


On Jun 3, 2008, at 11:32 AM, [hidden email] wrote:

> Author: adrianc
> Date: Tue Jun  3 10:32:07 2008
> New Revision: 662847
>
> URL: http://svn.apache.org/viewvc?rev=662847&view=rev
> Log:
> Fixed thread-safe issues in the tree widget. Eliminated compiler  
> warnings.
>
> Modified:
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/
> HtmlTreeRenderer.java
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/
> ModelTree.java
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/
> ModelTreeAction.java
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/
> ModelTreeCondition.java
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/
> TreeFactory.java
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/
> TreeStringRenderer.java
>

[Adrian Crum]

Thanks David!

Ever since you mentioned releasing the framework I have tried to clean
up the screen widget code. Also, thanks to Jacopo for helping out.

I have one more idea for cleaning up the widget code that I'm working
on. I'll submit a Jira issue with a POC patch in a few days.

-Adrian

David E Jones wrote:

>
> Wow, thanks for doing this Adrian. This code has been neglected for a
> long time, really from the beginning I'd say. I worked with Al a bit on
> the design of the XML file for it, and he implemented the whole thing
> and I haven't really looked at it since then. I'm glad there were just a
> few issues with it... it'll be a great tool especially once it is
> "super-AJAX-ed". ;)
>
> -David
>
>
> On Jun 3, 2008, at 11:32 AM, [hidden email] wrote:
>
>> Author: adrianc
>> Date: Tue Jun  3 10:32:07 2008
>> New Revision: 662847
>>
>> URL: http://svn.apache.org/viewvc?rev=662847&view=rev
>> Log:
>> Fixed thread-safe issues in the tree widget. Eliminated compiler
>> warnings.
>>
>> Modified:
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlTreeRenderer.java
>>
>>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/ModelTreeAction.java
>>
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/ModelTreeCondition.java
>>
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/TreeFactory.java
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/tree/TreeStringRenderer.java
>>
>>
>