Re: svn commit: r668125 - /ofbiz/trunk/applications/content/widget/content/ContentMenus.xml

[Adrian Crum]

Bilgin,

The col-right style is deprecated. Use opposed instead.

-Adrian

[hidden email] wrote:

> Author: bibryam
> Date: Mon Jun 16 05:04:31 2008
> New Revision: 668125
>
> URL: http://svn.apache.org/viewvc?rev=668125&view=rev
> Log:
> Fixed a style issue.
>
> Modified:
>     ofbiz/trunk/applications/content/widget/content/ContentMenus.xml
>
> Modified: ofbiz/trunk/applications/content/widget/content/ContentMenus.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/content/ContentMenus.xml?rev=668125&r1=668124&r2=668125&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/content/widget/content/ContentMenus.xml (original)
> +++ ofbiz/trunk/applications/content/widget/content/ContentMenus.xml Mon Jun 16 05:04:31 2008
> @@ -33,11 +33,11 @@
>          <menu-item name="CMS" title="${uiLabelMap.ContentCMS}"><link target="CMSContentFind"/></menu-item>
>          <menu-item name="CompDoc" title="${uiLabelMap.ContentCompDoc}"><link target="FindCompDoc"/></menu-item>
>          
> -        <menu-item name="Logout" title="${uiLabelMap.CommonLogout}" align-style="col-right" widget-style="headerButtonRight" selected-style="headerButtonRightSelected">
> +        <menu-item name="Logout" title="${uiLabelMap.CommonLogout}" align-style="col-right" selected-style="selected">
>              <condition><not><if-empty field-name="userLogin"/></not></condition>
>              <link target="logout"/>
>          </menu-item>
> -        <menu-item name="Login" title="${uiLabelMap.CommonLogin}" align-style="col-right" widget-style="headerButtonRight" selected-style="headerButtonRightSelected">
> +        <menu-item name="Login" title="${uiLabelMap.CommonLogin}" align-style="col-right" selected-style="selected">
>              <condition><if-empty field-name="userLogin"/></condition>
>              <link target="${checkLoginUrl}"/>
>          </menu-item>
>
>
>

[Bilgin Ibryam]

Adrian,
thanks for catching this. I replaced all col-right styles in rev668202.
and left only one in example component where I don't have access.

[Adrian Crum]

It would be cool if we could create a global application menu that
contains the main, logout, and login items. All application menus could
extend it and then we could eliminate all of that redundant menu widget
XML code.


Bilgin Ibryam wrote:
> Adrian,
> thanks for catching this. I replaced all col-right styles in rev668202.
> and left only one in example component where I don't have access.
>
>

[Bilgin Ibryam]

On Mon, 2008-06-16 at 09:11 -0700, Adrian Crum wrote:
> It would be cool if we could create a global application menu that
> contains the main, logout, and login items. All application menus
> could
> extend it and then we could eliminate all of that redundant menu
> widget
> XML code.

This is a great idea. I will take care of it. Thanks.

[Adrian Crum]

The "gotcha" will be the ordering of the menu items after the menu has
been extended. It might require some tweaks to the model widget code.


Bilgin Ibryam wrote:

> On Mon, 2008-06-16 at 09:11 -0700, Adrian Crum wrote:
>> It would be cool if we could create a global application menu that
>> contains the main, logout, and login items. All application menus
>> could
>> extend it and then we could eliminate all of that redundant menu
>> widget
>> XML code.
>
> This is a great idea. I will take care of it. Thanks.
>
>

[Bilgin Ibryam]

On Mon, 2008-06-16 at 09:54 -0700, Adrian Crum wrote:
> The "gotcha" will be the ordering of the menu items after the menu
> has
> been extended. It might require some tweaks to the model widget code.

Adrian, probably you are right, but I did a fast test and it worked
fine. Main menu item is on first position, and login/logout are on the
right side. align-style="opposed" solves the problem... Do I miss
something?

[Adrian Crum]

Bilgin Ibryam wrote:
> On Mon, 2008-06-16 at 09:54 -0700, Adrian Crum wrote:
>> The "gotcha" will be the ordering of the menu items after the menu
>> has
>> been extended. It might require some tweaks to the model widget code.
>
> Adrian, probably you are right, but I did a fast test and it worked
> fine. Main menu item is on first position, and login/logout are on the
> right side. align-style="opposed" solves the problem... Do I miss
> something?

That's great news! Let's see how it goes.