Re: svn commit: r673216 - /ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml

[Scott Gray]

Hi All (I'll assume Si isn't going to get this)

Is it correct to assume that the home phone will be the primary phone?  If
we have to set one as primary wouldn't it be better to let the user decide?

Regards
Scott

2008/7/2 <[hidden email]>:

> Author: sichen
> Date: Tue Jul  1 14:28:09 2008
> New Revision: 673216
>
> URL: http://svn.apache.org/viewvc?rev=673216&view=rev
> Log:
> also make phone numbers the primary phone number
>
> Modified:
>
>  ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>
> Modified:
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=673216&r1=673215&r2=673216&view=diff
>
> ==============================================================================
> ---
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> (original)
> +++
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> Tue Jul  1 14:28:09 2008
> @@ -332,6 +332,8 @@
>             <set from-field="tempMap.partyId"
> field="homePhonePurposeContext.partyId"/>
>             <set value="PHONE_HOME"
> field="homePhonePurposeContext.contactMechPurposeTypeId"/>
>             <call-service service-name="createPartyContactMechPurpose"
> in-map-name="homePhonePurposeContext"/>
> +            <set value="PRIMARY_PHONE"
> field="homePhonePurposeContext.contactMechPurposeTypeId"/>
> +            <call-service service-name="createPartyContactMechPurpose"
> in-map-name="homePhonePurposeContext"/>
>         </if-not-empty>
>
>         <!-- work phone -->
>
>
>

[Jacques Le Roux]

I saw it

+1 without any hesitations, choice is better

Jacques

From: "Scott Gray" <[hidden email]>

> Hi All (I'll assume Si isn't going to get this)
>
> Is it correct to assume that the home phone will be the primary phone?  If
> we have to set one as primary wouldn't it be better to let the user decide?
>
> Regards
> Scott
>
> 2008/7/2 <[hidden email]>:
>
>> Author: sichen
>> Date: Tue Jul  1 14:28:09 2008
>> New Revision: 673216
>>
>> URL: http://svn.apache.org/viewvc?rev=673216&view=rev
>> Log:
>> also make phone numbers the primary phone number
>>
>> Modified:
>>
>>  ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=673216&r1=673215&r2=673216&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> Tue Jul  1 14:28:09 2008
>> @@ -332,6 +332,8 @@
>>             <set from-field="tempMap.partyId"
>> field="homePhonePurposeContext.partyId"/>
>>             <set value="PHONE_HOME"
>> field="homePhonePurposeContext.contactMechPurposeTypeId"/>
>>             <call-service service-name="createPartyContactMechPurpose"
>> in-map-name="homePhonePurposeContext"/>
>> +            <set value="PRIMARY_PHONE"
>> field="homePhonePurposeContext.contactMechPurposeTypeId"/>
>> +            <call-service service-name="createPartyContactMechPurpose"
>> in-map-name="homePhonePurposeContext"/>
>>         </if-not-empty>
>>
>>         <!-- work phone -->
>>
>>
>>
>