Re: svn commit: r677855 - /ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl

[Adrian Crum]

Just a quick note to submitters and committers:

<td align="left">

is bad markup, and it is pointless. A <td> element (and any other
element) will align text to the left by default.

Another thing that is bad about ANY type of align attribute in markup is
the inability to switch directions - for right-to-left (RTL) languages.
It is better to use either the align-text or opposed (depending on the
element) CSS styles.

In this example, the

<td align="right">
   <b>

elements could be replaced with

<td class="label">

and it would have the same appearance.

-Adrian

[hidden email] wrote:

> Author: lektran
> Date: Fri Jul 18 01:42:03 2008
> New Revision: 677855
>
> URL: http://svn.apache.org/viewvc?rev=677855&view=rev
> Log:
> Fixed bug reported by Bruno Busco in the user list
>
> Modified:
>     ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl
>
> Modified: ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl?rev=677855&r1=677854&r2=677855&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl (original)
> +++ ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearch.ftl Fri Jul 18 01:42:03 2008
> @@ -69,7 +69,7 @@
>      
>      <table cellspacing="0" class="basic-table">
>          <tr>
> -          <td align="left"><input type="checkbox" name="selectAll" value="0" onclick="javascript:toggleAll(this);"> <b>${uiLabelMap.ProductProduct}</b></td>
> +          <td align="left"><input type="checkbox" name="selectAll" value="0" onclick="javascript:toggleAll(this);"/> <b>${uiLabelMap.ProductProduct}</b></td>
>            <td align="right">
>              <b>
>              <#if 0 < viewIndex?int>
> @@ -112,7 +112,7 @@
>            </#if>
>          </#list>
>        </table>
> -    <form>
> +    </form>
>      
>      <table cellspacing="0" class="basic-table">
>          <tr><td colspan="2"><hr/></td></tr>
>
>
>