Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl

Vikas Mayur-2
Hi Scott,

This style has been deprecated for back-end apps as per document
http://docs.ofbiz.org/display/OFBIZ/Misc+UI+Refactor+Guidelines+2
But my question is a bit different. What guidelines to follow for back-end
files (as in this case) that are also being used in ecommerce. I did not
find a mention about that. Is it good to use deprecated styles in these
scenarios ?

Thoughts Please ?

Thanks,
- Vikas


On Sat, Jul 26, 2008 at 2:48 AM, <[hidden email]> wrote:

> Author: lektran
> Date: Fri Jul 25 14:18:10 2008
> New Revision: 679900
>
> URL: http://svn.apache.org/viewvc?rev=679900&view=rev
> Log:
> Style the empty shopping cart div
>
> Modified:
>    ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>
> Modified:
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl?rev=679900&r1=679899&r2=679900&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> Fri Jul 25 14:18:10 2008
> @@ -71,7 +71,7 @@
>             <div style="margin-top: 4px;"><a
> href="<@ofbizUrl>checkoutoptions</@ofbizUrl>"
> class="buttontext">${uiLabelMap.EcommerceOnePageCheckout}</a></div>
>           </#if>
>         <#else>
> -          <div>${uiLabelMap.OrderShoppingCartEmpty}</div>
> +          <div
> class="tabletext">${uiLabelMap.OrderShoppingCartEmpty}</div>
>         </#if>
>     </div>
>  </div>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl

Scott Gray
Thanks Vikas, I guess I should have checked the commit history first.
I'll revert it and defer to Adrian for the correct approach.

Regards
Scott

2008/7/26 Vikas Mayur <[hidden email]>:

> Hi Scott,
>
> This style has been deprecated for back-end apps as per document
> http://docs.ofbiz.org/display/OFBIZ/Misc+UI+Refactor+Guidelines+2
> But my question is a bit different. What guidelines to follow for back-end
> files (as in this case) that are also being used in ecommerce. I did not
> find a mention about that. Is it good to use deprecated styles in these
> scenarios ?
>
> Thoughts Please ?
>
> Thanks,
> - Vikas
>
>
> On Sat, Jul 26, 2008 at 2:48 AM, <[hidden email]> wrote:
>
>> Author: lektran
>> Date: Fri Jul 25 14:18:10 2008
>> New Revision: 679900
>>
>> URL: http://svn.apache.org/viewvc?rev=679900&view=rev
>> Log:
>> Style the empty shopping cart div
>>
>> Modified:
>>    ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>>
>> Modified:
>> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl?rev=679900&r1=679899&r2=679900&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>> (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>> Fri Jul 25 14:18:10 2008
>> @@ -71,7 +71,7 @@
>>             <div style="margin-top: 4px;"><a
>> href="<@ofbizUrl>checkoutoptions</@ofbizUrl>"
>> class="buttontext">${uiLabelMap.EcommerceOnePageCheckout}</a></div>
>>           </#if>
>>         <#else>
>> -          <div>${uiLabelMap.OrderShoppingCartEmpty}</div>
>> +          <div
>> class="tabletext">${uiLabelMap.OrderShoppingCartEmpty}</div>
>>         </#if>
>>     </div>
>>  </div>
>>
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl

Adrian Crum-2
It would be best to have the eCommerce style sheet updated to more closely match the back ofice apps. There is a Jira issue created for that - https://issues.apache.org/jira/browse/OFBIZ-1119.

-Adrian


--- On Sat, 7/26/08, Scott Gray <[hidden email]> wrote:

> From: Scott Gray <[hidden email]>
> Subject: Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> To: [hidden email]
> Date: Saturday, July 26, 2008, 1:03 AM
> Thanks Vikas, I guess I should have checked the commit
> history first.
> I'll revert it and defer to Adrian for the correct
> approach.
>
> Regards
> Scott
>
> 2008/7/26 Vikas Mayur <[hidden email]>:
> > Hi Scott,
> >
> > This style has been deprecated for back-end apps as
> per document
> >
> http://docs.ofbiz.org/display/OFBIZ/Misc+UI+Refactor+Guidelines+2
> > But my question is a bit different. What guidelines to
> follow for back-end
> > files (as in this case) that are also being used in
> ecommerce. I did not
> > find a mention about that. Is it good to use
> deprecated styles in these
> > scenarios ?
> >
> > Thoughts Please ?
> >
> > Thanks,
> > - Vikas
> >
> >
> > On Sat, Jul 26, 2008 at 2:48 AM,
> <[hidden email]> wrote:
> >
> >> Author: lektran
> >> Date: Fri Jul 25 14:18:10 2008
> >> New Revision: 679900
> >>
> >> URL:
> http://svn.apache.org/viewvc?rev=679900&view=rev
> >> Log:
> >> Style the empty shopping cart div
> >>
> >> Modified:
> >>  
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> >>
> >> Modified:
> >>
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl?rev=679900&r1=679899&r2=679900&view=diff
> >>
> >>
> ==============================================================================
> >> ---
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> >> (original)
> >> +++
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> >> Fri Jul 25 14:18:10 2008
> >> @@ -71,7 +71,7 @@
> >>             <div style="margin-top:
> 4px;"><a
> >>
> href="<@ofbizUrl>checkoutoptions</@ofbizUrl>"
> >>
> class="buttontext">${uiLabelMap.EcommerceOnePageCheckout}</a></div>
> >>           </#if>
> >>         <#else>
> >> -        
> <div>${uiLabelMap.OrderShoppingCartEmpty}</div>
> >> +          <div
> >>
> class="tabletext">${uiLabelMap.OrderShoppingCartEmpty}</div>
> >>         </#if>
> >>     </div>
> >>  </div>
> >>
> >>
> >>
> >