Re: svn commit: r685078 - in /ofbiz/trunk: applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml specialpurpose/projectmgr/webapp/projectmgr/WEB-INF/controller.xml

[David E Jones-2]

On Aug 12, 2008, at 2:06 AM, [hidden email] wrote:

> +            <!-- check status of customer request should be  
> assigned -->
> +            <entity-one entity-name="CustRequest" value-
> name="custRequest"/>
> +            <if-compare operator="not-equals" value="CRQ_ACCEPTED"  
> field="custRequest.statusId">
> +                <add-error><fail-message message="Cannot create  
> task from Customer Request: wrong status of customer request"/></add-
> error>
> +            </if-compare>

Just a quick note: bad error messages really bug me, and this one  
lacks enough detail to get me to write an email about it... ;)

All it says is that the status is wrong, it doesn't say it is the  
current status that is wrong and it doesn't say which status is  
acceptable or show the current status so the user knows that it is  
indeed different.

-David

[Jacques Le Roux]

Moreover it's not localisable (i18n)

Jacques

From: "David E Jones" <[hidden email]>

>
> On Aug 12, 2008, at 2:06 AM, [hidden email] wrote:
>
>> +            <!-- check status of customer request should be  
>> assigned -->
>> +            <entity-one entity-name="CustRequest" value-
>> name="custRequest"/>
>> +            <if-compare operator="not-equals" value="CRQ_ACCEPTED"  
>> field="custRequest.statusId">
>> +                <add-error><fail-message message="Cannot create  
>> task from Customer Request: wrong status of customer request"/></add-
>> error>
>> +            </if-compare>
>
> Just a quick note: bad error messages really bug me, and this one  
> lacks enough detail to get me to write an email about it... ;)
>
> All it says is that the status is wrong, it doesn't say it is the  
> current status that is wrong and it doesn't say which status is  
> acceptable or show the current status so the user knows that it is  
> indeed different.
>
> -David