Re: svn commit: r714085 - in /ofbiz/trunk/debian: ./ rules

[BJ Freeman]

I see you put in a lot of debian stuff.
can you tell me how it relates to ofbiz.


[hidden email] sent the following on 11/14/2008 10:04 AM:

> Author: doogie
> Date: Fri Nov 14 10:03:59 2008
> New Revision: 714085
>
> URL: http://svn.apache.org/viewvc?rev=714085&view=rev
> Log:
> Use a stamps dir to save from having to compile ofbiz all the time.
>
> Modified:
>     ofbiz/trunk/debian/   (props changed)
>     ofbiz/trunk/debian/rules
>
> Propchange: ofbiz/trunk/debian/
> ------------------------------------------------------------------------------
> --- svn:ignore (original)
> +++ svn:ignore Fri Nov 14 10:03:59 2008
> @@ -8,3 +8,4 @@
>  ofbiz.postinst.debhelper
>  ofbiz.postrm.debhelper
>  ofbiz.substvars
> +stamps
>
> Modified: ofbiz/trunk/debian/rules
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/debian/rules?rev=714085&r1=714084&r2=714085&view=diff
> ==============================================================================
> --- ofbiz/trunk/debian/rules (original)
> +++ ofbiz/trunk/debian/rules Fri Nov 14 10:03:59 2008
> @@ -45,18 +45,20 @@
>  clean-debian:
>   dh_clean
>   rm -f debian/EncryptPassword.class
> - rm -rf runtime/catalina/work
> + rm -rf runtime/catalina/work debian/stamps
>  
>  clean: clean-debian
>   ant clean-all
>   debconf-updatepo
>  
> -build: build-ofbiz debian/EncryptPassword.class
> -build-ofbiz:
> +build: debian/stamps/build-ofbiz debian/EncryptPassword.class
> +build-ofbiz: debian/stamps/build-ofbiz
> +debian/stamps/build-ofbiz:
>   ant
> + @mkdir -p $(@D) && touch $@
>  
>  debian/EncryptPassword.class: %.class: %.java
> -debian/EncryptPassword.class: build-ofbiz
> +debian/EncryptPassword.class: debian/stamps/build-ofbiz
>   $(JAVAC) -classpath framework/base/build/lib/ofbiz-base.jar:framework/common/build/lib/ofbiz-common.jar -d $(@D) $*.java
>  
>  
>
>
>
>

[Jacques Le Roux]

I guess Adam is doing  a .deb package for OFBiz :o)

Jacques

From: "BJ Freeman" <[hidden email]>

>I see you put in a lot of debian stuff.
> can you tell me how it relates to ofbiz.
>
>
> [hidden email] sent the following on 11/14/2008 10:04 AM:
>> Author: doogie
>> Date: Fri Nov 14 10:03:59 2008
>> New Revision: 714085
>>
>> URL: http://svn.apache.org/viewvc?rev=714085&view=rev
>> Log:
>> Use a stamps dir to save from having to compile ofbiz all the time.
>>
>> Modified:
>>     ofbiz/trunk/debian/   (props changed)
>>     ofbiz/trunk/debian/rules
>>
>> Propchange: ofbiz/trunk/debian/
>> ------------------------------------------------------------------------------
>> --- svn:ignore (original)
>> +++ svn:ignore Fri Nov 14 10:03:59 2008
>> @@ -8,3 +8,4 @@
>>  ofbiz.postinst.debhelper
>>  ofbiz.postrm.debhelper
>>  ofbiz.substvars
>> +stamps
>>
>> Modified: ofbiz/trunk/debian/rules
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/debian/rules?rev=714085&r1=714084&r2=714085&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/debian/rules (original)
>> +++ ofbiz/trunk/debian/rules Fri Nov 14 10:03:59 2008
>> @@ -45,18 +45,20 @@
>>  clean-debian:
>>  dh_clean
>>  rm -f debian/EncryptPassword.class
>> - rm -rf runtime/catalina/work
>> + rm -rf runtime/catalina/work debian/stamps
>>  
>>  clean: clean-debian
>>  ant clean-all
>>  debconf-updatepo
>>  
>> -build: build-ofbiz debian/EncryptPassword.class
>> -build-ofbiz:
>> +build: debian/stamps/build-ofbiz debian/EncryptPassword.class
>> +build-ofbiz: debian/stamps/build-ofbiz
>> +debian/stamps/build-ofbiz:
>>  ant
>> + @mkdir -p $(@D) && touch $@
>>  
>>  debian/EncryptPassword.class: %.class: %.java
>> -debian/EncryptPassword.class: build-ofbiz
>> +debian/EncryptPassword.class: debian/stamps/build-ofbiz
>>  $(JAVAC) -classpath framework/base/build/lib/ofbiz-base.jar:framework/common/build/lib/ofbiz-common.jar -d $(@D) $*.java
>>  
>>  
>>
>>
>>
>>
>

[BJ Freeman]

was hoping to understand, so maybe put other distribution up also.
:)

Jacques Le Roux sent the following on 11/15/2008 1:49 AM:

> I guess Adam is doing  a .deb package for OFBiz :o)
>
> Jacques
>
> From: "BJ Freeman" <[hidden email]>
>> I see you put in a lot of debian stuff.
>> can you tell me how it relates to ofbiz.
>>
>>
>> [hidden email] sent the following on 11/14/2008 10:04 AM:
>>> Author: doogie
>>> Date: Fri Nov 14 10:03:59 2008
>>> New Revision: 714085
>>>
>>> URL: http://svn.apache.org/viewvc?rev=714085&view=rev
>>> Log:
>>> Use a stamps dir to save from having to compile ofbiz all the time.
>>>
>>> Modified:
>>>     ofbiz/trunk/debian/   (props changed)
>>>     ofbiz/trunk/debian/rules
>>>
>>> Propchange: ofbiz/trunk/debian/
>>> ------------------------------------------------------------------------------
>>>
>>> --- svn:ignore (original)
>>> +++ svn:ignore Fri Nov 14 10:03:59 2008
>>> @@ -8,3 +8,4 @@
>>>  ofbiz.postinst.debhelper
>>>  ofbiz.postrm.debhelper
>>>  ofbiz.substvars
>>> +stamps
>>>
>>> Modified: ofbiz/trunk/debian/rules
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/debian/rules?rev=714085&r1=714084&r2=714085&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- ofbiz/trunk/debian/rules (original)
>>> +++ ofbiz/trunk/debian/rules Fri Nov 14 10:03:59 2008
>>> @@ -45,18 +45,20 @@
>>>  clean-debian:
>>>  dh_clean
>>>  rm -f debian/EncryptPassword.class
>>> - rm -rf runtime/catalina/work
>>> + rm -rf runtime/catalina/work debian/stamps
>>>  
>>>  clean: clean-debian
>>>  ant clean-all
>>>  debconf-updatepo
>>>  
>>> -build: build-ofbiz debian/EncryptPassword.class
>>> -build-ofbiz:
>>> +build: debian/stamps/build-ofbiz debian/EncryptPassword.class
>>> +build-ofbiz: debian/stamps/build-ofbiz
>>> +debian/stamps/build-ofbiz:
>>>  ant
>>> + @mkdir -p $(@D) && touch $@
>>>  
>>>  debian/EncryptPassword.class: %.class: %.java
>>> -debian/EncryptPassword.class: build-ofbiz
>>> +debian/EncryptPassword.class: debian/stamps/build-ofbiz
>>>  $(JAVAC) -classpath
>>> framework/base/build/lib/ofbiz-base.jar:framework/common/build/lib/ofbiz-common.jar
>>> -d $(@D) $*.java
>>>  
>>>  
>>>
>>>
>>>
>>>
>>
>
>

[Adam Heath-2]

Jacques Le Roux wrote:
> I guess Adam is doing  a .deb package for OFBiz :o)

Actually, several.

I just recently split the package even further.  Before, I  had ofbiz
and ofbiz-specialpurpose, as separate debs.

Now, I have ofbiz-framework, ofbiz-applications, and
ofbiz-specialpurpose, with an ofbiz pseudo package that requires all
three.  I just recently did this, so I'm not done with the procedue, but
the plan is to have ofbiz-framework install itself, create the database,
install seed(and/or demo/ext).  Then each extension package will stop
the ofbiz daemon, and install it's data, then start the daemon back up.
 But only during the initial install.  Upgrades are not really that well
supported by ofbiz upstream.

I discovered that when I split application/framework, that there were
exceptions printed at startup.  It tries to load a bunch of freemarker
transforms, but the classes don't exist for that; I'll fix that problem
by using the META-INF/services framework.

The packages prompt for the type of database(postgres, mysql, derby,
hsql), create a separate user/db(for the first 2 choices), run ofbiz
itself as a separate user, move all files into their proper FHS
location(/var/cache, /var/lib, /var/log); basically, it's a well-behaved
debian package.

I've got some more changes I have to commit, plus finish the package
split, but soon, running ofbiz in debian will become even easier.

ps: just noticed this weekend, when I upgraded my system, that openjdk6
is in debian main; this means that ofbiz can go into main as well.

[Adrian Crum]

Adam Heath wrote:
> I discovered that when I split application/framework, that there were
> exceptions printed at startup.  It tries to load a bunch of freemarker
> transforms, but the classes don't exist for that; I'll fix that problem
> by using the META-INF/services framework.

FreeMarkerWorker should only log a warning, not throw an exception.

-Adrian

[Adam Heath-2]

Adrian Crum wrote:
> Adam Heath wrote:
>> I discovered that when I split application/framework, that there were
>> exceptions printed at startup.  It tries to load a bunch of freemarker
>> transforms, but the classes don't exist for that; I'll fix that problem
>> by using the META-INF/services framework.
>
> FreeMarkerWorker should only log a warning, not throw an exception.

So?  Exceptions are bad, anytime they are printed.  Makes it harder to
find real problems.

Besides, the config for this resides in framework, while the code
resides in applications.  That's bad, and completely fixable.

[Adrian Crum]

Adam Heath wrote:

> Adrian Crum wrote:
>> Adam Heath wrote:
>>> I discovered that when I split application/framework, that there were
>>> exceptions printed at startup.  It tries to load a bunch of freemarker
>>> transforms, but the classes don't exist for that; I'll fix that problem
>>> by using the META-INF/services framework.
>> FreeMarkerWorker should only log a warning, not throw an exception.
>
> So?  Exceptions are bad, anytime they are printed.  Makes it harder to
> find real problems.
>
> Besides, the config for this resides in framework, while the code
> resides in applications.  That's bad, and completely fixable.

That's because there was no common place to put the
applicationTransforms.properties file in the applications folder.

I look forward to seeing your solution.

-Adrian

[Adam Heath-2]

Adrian Crum wrote:

> Adam Heath wrote:
>> Adrian Crum wrote:
>>> Adam Heath wrote:
>>>> I discovered that when I split application/framework, that there were
>>>> exceptions printed at startup.  It tries to load a bunch of freemarker
>>>> transforms, but the classes don't exist for that; I'll fix that problem
>>>> by using the META-INF/services framework.
>>> FreeMarkerWorker should only log a warning, not throw an exception.
>>
>> So?  Exceptions are bad, anytime they are printed.  Makes it harder to
>> find real problems.
>>
>> Besides, the config for this resides in framework, while the code
>> resides in applications.  That's bad, and completely fixable.
>
> That's because there was no common place to put the
> applicationTransforms.properties file in the applications folder.

Each appliation that has a Freemarker transform will add a line to it's
own file in applications/foo/src/META-INF/services/$service_name.  Then,
javax.imageio.spi.ServiceRegistry will be used to find those, and
instante all that are on the classpath.

ps: The above class is for java < 1.6.  In 1.6, it was moved and
reworked into java.util.ServiceLoader.