Re: svn commit: r731346 [3/3] - in /ofbiz/branches/typecheckcleanup200810: applications/accounting/widget/ applications/content/script/org/ofbiz/content/content/ applications/ecommerce/script/org/ofbiz/ecommerce/customer/ applications/ecommerce/webapp/ecom...

[hans_bakker]

The following code was added at jan 4 by Scott(lektran) as part of the
double->bigdecimal conversion

may i ask why this was added and what it does? This part of code gives
an error when the old format of the database is used however using this
new code....

The error:
2009-01-12 12:04:55,946 (default-invoker-Thread-10) [
ModelService.java:545:ERROR] [ModelService.validate] :
{sendEmailDated} : (IN) Required test error:
org.ofbiz.service.ServiceValidationException: The following required
parameter is missing: [IN] [sendEmailDated.runtimeDataId]

I changed the data for this scheduled job to 'seed' data and reloaded
its definition...

The problem however did not go away....

can you help me Scott?

Regards,
Hans

> URL:
> http://svn.apache.org/viewvc/ofbiz/branches/typecheckcleanup200810/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml?rev=731346&r1=731345&r2=731346&view=diff
> ==============================================================================
> --- ofbiz/branches/typecheckcleanup200810/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml (original)
> +++ ofbiz/branches/typecheckcleanup200810/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml Sun Jan  4 11:46:24 2009
> @@ -361,6 +361,23 @@
>              <set-service-fields service-name="sendCommEventAsEmail" map-name="communicationEvent" to-map-name="inMap"/>
>              <call-service service-name="sendCommEventAsEmail" in-map-name="inMap" require-new-transaction="true"/>
>          </iterate>
> +        <set field="cookie" from-field="parameters.cookie" type="Integer"/>
> +        <calculate field-name="cookie" type="Integer">
> +            <calcop operator="add">
> +                <number value="1"/>
> +                <calcop operator="get" field-name="cookie"/>
> +            </calcop>
> +        </calculate>
> +        <set field="pk.runtimeDataId" value="TESTID"/>
> +        <find-by-primary-key map-name="pk" value-name="runtimeData" entity-name="RuntimeData"/>
> +        <set field="newData.runtimeDataId" from-field="pk.runtimeDataId"/>
> +        <set field="newData.cookie" from-field="cookie"/>
> +        <call-class-method method-name="serialize" class-name="org.ofbiz.entity.serialize.XmlSerializer" ret-field-name="dummy">
> +            <field field-name="newData" type="Object"/>
> +        </call-class-method>
> +        <log level="always" message="${dummy}"></log>
> +        <set field="runtimeData.runtimeInfo" from-field="dummy"/>
> +        <store-value value-name="runtimeData"/>
>      </simple-method>

[David E Jones-3]

This looks like some sort of test code that was committed mistakenly.  
Thanks for tracking that down Hans.

Scott, do you have any thoughts/comments on this?

-David


On Jan 11, 2009, at 9:09 PM, Hans Bakker wrote:

> The following code was added at jan 4 by Scott(lektran) as part of the
> double->bigdecimal conversion
>
> may i ask why this was added and what it does? This part of code gives
> an error when the old format of the database is used however using  
> this
> new code....
>
> The error:
> 2009-01-12 12:04:55,946 (default-invoker-Thread-10) [
> ModelService.java:545:ERROR] [ModelService.validate] :
> {sendEmailDated} : (IN) Required test error:
> org.ofbiz.service.ServiceValidationException: The following required
> parameter is missing: [IN] [sendEmailDated.runtimeDataId]
>
> I changed the data for this scheduled job to 'seed' data and reloaded
> its definition...
>
> The problem however did not go away....
>
> can you help me Scott?
>
> Regards,
> Hans
>
>
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/typecheckcleanup200810/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml?rev=731346&r1=731345&r2=731346&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/branches/typecheckcleanup200810/applications/party/script/
>> org/ofbiz/party/communication/CommunicationEventServices.xml  
>> (original)
>> +++ ofbiz/branches/typecheckcleanup200810/applications/party/script/
>> org/ofbiz/party/communication/CommunicationEventServices.xml Sun  
>> Jan  4 11:46:24 2009
>> @@ -361,6 +361,23 @@
>>             <set-service-fields service-name="sendCommEventAsEmail"  
>> map-name="communicationEvent" to-map-name="inMap"/>
>>             <call-service service-name="sendCommEventAsEmail" in-
>> map-name="inMap" require-new-transaction="true"/>
>>         </iterate>
>> +        <set field="cookie" from-field="parameters.cookie"  
>> type="Integer"/>
>> +        <calculate field-name="cookie" type="Integer">
>> +            <calcop operator="add">
>> +                <number value="1"/>
>> +                <calcop operator="get" field-name="cookie"/>
>> +            </calcop>
>> +        </calculate>
>> +        <set field="pk.runtimeDataId" value="TESTID"/>
>> +        <find-by-primary-key map-name="pk" value-
>> name="runtimeData" entity-name="RuntimeData"/>
>> +        <set field="newData.runtimeDataId" from-
>> field="pk.runtimeDataId"/>
>> +        <set field="newData.cookie" from-field="cookie"/>
>> +        <call-class-method method-name="serialize" class-
>> name="org.ofbiz.entity.serialize.XmlSerializer" ret-field-
>> name="dummy">
>> +            <field field-name="newData" type="Object"/>
>> +        </call-class-method>
>> +        <log level="always" message="${dummy}"></log>
>> +        <set field="runtimeData.runtimeInfo" from-field="dummy"/>
>> +        <store-value value-name="runtimeData"/>
>>     </simple-method>
>
>