Re: svn commit: r739568 - in /ofbiz/trunk: applications/accounting/webapp/accounting/fixedasset/ applications/party/webapp/partymgr/party/ applications/product/webapp/facility/facility/ framework/common/webcommon/WEB-INF/

[Jacopo Cappellato-4]

Hi Jacques,

I think it is a bad idea to hardcode demo data...

Jacopo

On Jan 31, 2009, at 3:57 PM, [hidden email] wrote:

> Author: jleroux
> Date: Sat Jan 31 14:57:28 2009
> New Revision: 739568
>
> URL: http://svn.apache.org/viewvc?rev=739568&view=rev
> Log:
> Make easier to see demonstration
>
> Modified:
>    ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/
> FixedAssetGeoLocation.ftl
>    ofbiz/trunk/applications/party/webapp/partymgr/party/
> partygeolocation.ftl
>    ofbiz/trunk/applications/product/webapp/facility/facility/
> FacilityLocationGeoLocation.ftl
>    ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl
>
> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/
> fixedasset/FixedAssetGeoLocation.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/FixedAssetGeoLocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/
> FixedAssetGeoLocation.ftl (original)
> +++ ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/
> FixedAssetGeoLocation.ftl Sat Jan 31 14:57:28 2009
> @@ -46,5 +46,5 @@
>     </#if>
>   </#if>
> <#else>
> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</
> @ofbizUrl>" class="button">$
> {uiLabelMap.CommonNoGeolocationAvailable}</a>
> </#if>
>
> Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/
> partygeolocation.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/partygeolocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/party/webapp/partymgr/party/
> partygeolocation.ftl (original)
> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/
> partygeolocation.ftl Sat Jan 31 14:57:28 2009
> @@ -46,5 +46,5 @@
>     </#if>
>   </#if>
> <#else>
> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
> +  <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</
> @ofbizUrl>" class="button">$
> {uiLabelMap.CommonNoGeolocationAvailable}</a>
> </#if>
>
> Modified: ofbiz/trunk/applications/product/webapp/facility/facility/
> FacilityLocationGeoLocation.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/facility/FacilityLocationGeoLocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/product/webapp/facility/facility/
> FacilityLocationGeoLocation.ftl (original)
> +++ ofbiz/trunk/applications/product/webapp/facility/facility/
> FacilityLocationGeoLocation.ftl Sat Jan 31 14:57:28 2009
> @@ -46,5 +46,6 @@
>     </#if>
>   </#if>
> <#else>
> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</
> @ofbizUrl>" class="button">$
> {uiLabelMap.CommonNoGeolocationAvailable}</a>
> +
> </#if>
>
> Modified: ofbiz/trunk/framework/common/webcommon/WEB-INF/
> geolocation.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl  
> (original)
> +++ ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl  
> Sat Jan 31 14:57:28 2009
> @@ -44,5 +44,6 @@
>     </#if>
>   </#if>
> <#else>
> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</
> @ofbizUrl>" class="button">$
> {uiLabelMap.CommonNoGeolocationAvailable}</a>
> +
> </#if>
>
>

[Jacques Le Roux]

Hi Jacopo,

Yes you are right, I did not think 1st but yes, this could introduce circular reference in case no demo data where used. Reverted in
revision: 739574

Thanks

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Hi Jacques,
>
> I think it is a bad idea to hardcode demo data...
>
> Jacopo
>
> On Jan 31, 2009, at 3:57 PM, [hidden email] wrote:
>
>> Author: jleroux
>> Date: Sat Jan 31 14:57:28 2009
>> New Revision: 739568
>>
>> URL: http://svn.apache.org/viewvc?rev=739568&view=rev
>> Log:
>> Make easier to see demonstration
>>
>> Modified:
>>    ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/ FixedAssetGeoLocation.ftl
>>    ofbiz/trunk/applications/party/webapp/partymgr/party/ partygeolocation.ftl
>>    ofbiz/trunk/applications/product/webapp/facility/facility/ FacilityLocationGeoLocation.ftl
>>    ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl
>>
>> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/ fixedasset/FixedAssetGeoLocation.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/FixedAssetGeoLocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/ FixedAssetGeoLocation.ftl (original)
>> +++ ofbiz/trunk/applications/accounting/webapp/accounting/fixedasset/ FixedAssetGeoLocation.ftl Sat Jan 31 14:57:28 2009
>> @@ -46,5 +46,5 @@
>>     </#if>
>>   </#if>
>> <#else>
>> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
>> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</ @ofbizUrl>" class="button">$
>> {uiLabelMap.CommonNoGeolocationAvailable}</a>
>> </#if>
>>
>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/ partygeolocation.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/partygeolocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/applications/party/webapp/partymgr/party/ partygeolocation.ftl (original)
>> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/ partygeolocation.ftl Sat Jan 31 14:57:28 2009
>> @@ -46,5 +46,5 @@
>>     </#if>
>>   </#if>
>> <#else>
>> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
>> +  <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</ @ofbizUrl>" class="button">$
>> {uiLabelMap.CommonNoGeolocationAvailable}</a>
>> </#if>
>>
>> Modified: ofbiz/trunk/applications/product/webapp/facility/facility/ FacilityLocationGeoLocation.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/facility/FacilityLocationGeoLocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/applications/product/webapp/facility/facility/ FacilityLocationGeoLocation.ftl (original)
>> +++ ofbiz/trunk/applications/product/webapp/facility/facility/ FacilityLocationGeoLocation.ftl Sat Jan 31 14:57:28 2009
>> @@ -46,5 +46,6 @@
>>     </#if>
>>   </#if>
>> <#else>
>> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
>> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</ @ofbizUrl>" class="button">$
>> {uiLabelMap.CommonNoGeolocationAvailable}</a>
>> +
>> </#if>
>>
>> Modified: ofbiz/trunk/framework/common/webcommon/WEB-INF/ geolocation.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl?rev=739568&r1=739567&r2=739568&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl  (original)
>> +++ ofbiz/trunk/framework/common/webcommon/WEB-INF/geolocation.ftl  Sat Jan 31 14:57:28 2009
>> @@ -44,5 +44,6 @@
>>     </#if>
>>   </#if>
>> <#else>
>> -  <h2>${uiLabelMap.CommonNoGeolocationAvailable}</h2>
>> +    <a href="<@ofbizUrl>PartyGeoLocation?partyId=DemoCustomer</ @ofbizUrl>" class="button">$
>> {uiLabelMap.CommonNoGeolocationAvailable}</a>
>> +
>> </#if>
>>
>>
>
>