Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

[David E. Jones-2]

This is an interesting problem... on a related note what happened to  
the old functionality where if a label was not found the label itself  
was printed? I think that changed with some of the new XML-based stuff  
and it is unfortunate because with defaulting to the label name at  
least it isn't totally blank like this.

-David


On Jan 31, 2009, at 3:15 PM, [hidden email] wrote:

> Author: lektran
> Date: Sat Jan 31 23:15:01 2009
> New Revision: 739651
>
> URL: http://svn.apache.org/viewvc?rev=739651&view=rev
> Log:
> Fix for issue OFBIZ-2142 reported by Hans Bakker: " error message of  
> login service does not show with common/messages.ftl
> "
> The labels had been moved to a different resource file
>
> Modified:
>   ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
> LoginWorker.java
>
> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
> LoginWorker.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?rev=739651&r1=739650&r2=739651&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
> LoginWorker.java (original)
> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/
> LoginWorker.java Sat Jan 31 23:15:01 2009
> @@ -76,7 +76,7 @@
> public class LoginWorker {
>
>    public final static String module = LoginWorker.class.getName();
> -    public static final String resourceWebapp = "WebappUiLabels";
> +    public static final String resourceWebapp =  
> "SecurityextUiLabels";
>
>    public static final String EXTERNAL_LOGIN_KEY_ATTR =  
> "externalLoginKey";
>    public static final String X509_CERT_ATTR = "SSLx509Cert";
>
>

[Adrian Crum-2]

That shouldn't have changed. I will look into it.

-Adrian


--- On Sat, 1/31/09, David E Jones <[hidden email]> wrote:

> From: David E Jones <[hidden email]>
> Subject: Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> To: [hidden email]
> Date: Saturday, January 31, 2009, 9:40 PM
> This is an interesting problem... on a related note what
> happened to the old functionality where if a label was not
> found the label itself was printed? I think that changed
> with some of the new XML-based stuff and it is unfortunate
> because with defaulting to the label name at least it
> isn't totally blank like this.
>
> -David
>
>
> On Jan 31, 2009, at 3:15 PM, [hidden email] wrote:
>
> > Author: lektran
> > Date: Sat Jan 31 23:15:01 2009
> > New Revision: 739651
> >
> > URL:
> http://svn.apache.org/viewvc?rev=739651&view=rev
> > Log:
> > Fix for issue OFBIZ-2142 reported by Hans Bakker:
> " error message of login service does not show with
> common/messages.ftl
> > "
> > The labels had been moved to a different resource file
> >
> > Modified:
> >  
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> >
> > Modified:
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?rev=739651&r1=739650&r2=739651&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> (original)
> > +++
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> Sat Jan 31 23:15:01 2009
> > @@ -76,7 +76,7 @@
> > public class LoginWorker {
> >
> >    public final static String module =
> LoginWorker.class.getName();
> > -    public static final String resourceWebapp =
> "WebappUiLabels";
> > +    public static final String resourceWebapp =
> "SecurityextUiLabels";
> >
> >    public static final String EXTERNAL_LOGIN_KEY_ATTR
> = "externalLoginKey";
> >    public static final String X509_CERT_ATTR =
> "SSLx509Cert";
> >
> >

     

[Jacques Le Roux]

I can testify positively. Recently I saw CommonDefaultOrganizationPartyId before introducing it's label. But maybe there are some
other cases. I mean this case is : no labels anywhere at all

Jacques

From: "Adrian Crum" <[hidden email]>

> That shouldn't have changed. I will look into it.
>
> -Adrian
>
>
> --- On Sat, 1/31/09, David E Jones <[hidden email]> wrote:
>
>> From: David E Jones <[hidden email]>
>> Subject: Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
>> To: [hidden email]
>> Date: Saturday, January 31, 2009, 9:40 PM
>> This is an interesting problem... on a related note what
>> happened to the old functionality where if a label was not
>> found the label itself was printed? I think that changed
>> with some of the new XML-based stuff and it is unfortunate
>> because with defaulting to the label name at least it
>> isn't totally blank like this.
>>
>> -David
>>
>>
>> On Jan 31, 2009, at 3:15 PM, [hidden email] wrote:
>>
>> > Author: lektran
>> > Date: Sat Jan 31 23:15:01 2009
>> > New Revision: 739651
>> >
>> > URL:
>> http://svn.apache.org/viewvc?rev=739651&view=rev
>> > Log:
>> > Fix for issue OFBIZ-2142 reported by Hans Bakker:
>> " error message of login service does not show with
>> common/messages.ftl
>> > "
>> > The labels had been moved to a different resource file
>> >
>> > Modified:
>> >
>> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
>> >
>> > Modified:
>> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
>> > URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?rev=739651&r1=739650&r2=739651&view=diff
>> >
>> ==============================================================================
>> > ---
>> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
>> (original)
>> > +++
>> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
>> Sat Jan 31 23:15:01 2009
>> > @@ -76,7 +76,7 @@
>> > public class LoginWorker {
>> >
>> >    public final static String module =
>> LoginWorker.class.getName();
>> > -    public static final String resourceWebapp =
>> "WebappUiLabels";
>> > +    public static final String resourceWebapp =
>> "SecurityextUiLabels";
>> >
>> >    public static final String EXTERNAL_LOGIN_KEY_ATTR
>> = "externalLoginKey";
>> >    public static final String X509_CERT_ATTR =
>> "SSLx509Cert";
>> >
>> >
>
>
>
>

[Adrian Crum-2]

Fixed, rev 739786.

-Adrian


--- On Sat, 1/31/09, Adrian Crum <[hidden email]> wrote:

> From: Adrian Crum <[hidden email]>
> Subject: Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> To: [hidden email]
> Date: Saturday, January 31, 2009, 11:01 PM
> That shouldn't have changed. I will look into it.
>
> -Adrian
>
>
> --- On Sat, 1/31/09, David E Jones <[hidden email]>
> wrote:
>
> > From: David E Jones <[hidden email]>
> > Subject: Re: svn commit: r739651 -
> /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > To: [hidden email]
> > Date: Saturday, January 31, 2009, 9:40 PM
> > This is an interesting problem... on a related note
> what
> > happened to the old functionality where if a label was
> not
> > found the label itself was printed? I think that
> changed
> > with some of the new XML-based stuff and it is
> unfortunate
> > because with defaulting to the label name at least it
> > isn't totally blank like this.
> >
> > -David
> >
> >
> > On Jan 31, 2009, at 3:15 PM, [hidden email] wrote:
> >
> > > Author: lektran
> > > Date: Sat Jan 31 23:15:01 2009
> > > New Revision: 739651
> > >
> > > URL:
> > http://svn.apache.org/viewvc?rev=739651&view=rev
> > > Log:
> > > Fix for issue OFBIZ-2142 reported by Hans Bakker:
> > " error message of login service does not show
> with
> > common/messages.ftl
> > > "
> > > The labels had been moved to a different resource
> file
> > >
> > > Modified:
> > >  
> >
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > >
> > > Modified:
> >
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?rev=739651&r1=739650&r2=739651&view=diff
> > >
> >
> ==============================================================================
> > > ---
> >
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > (original)
> > > +++
> >
> ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
> > Sat Jan 31 23:15:01 2009
> > > @@ -76,7 +76,7 @@
> > > public class LoginWorker {
> > >
> > >    public final static String module =
> > LoginWorker.class.getName();
> > > -    public static final String resourceWebapp =
> > "WebappUiLabels";
> > > +    public static final String resourceWebapp =
> > "SecurityextUiLabels";
> > >
> > >    public static final String
> EXTERNAL_LOGIN_KEY_ATTR
> > = "externalLoginKey";
> > >    public static final String X509_CERT_ATTR =
> > "SSLx509Cert";
> > >
> > >