Re: svn commit: r745931 - in /ofbiz/trunk/applications/product: servicedef/services_shipment.xml src/org/ofbiz/shipment/packing/PackingServices.java src/org/ofbiz/shipment/packing/PackingSession.java webapp/facility/shipment/PackOrder.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r745931 - in /ofbiz/trunk/applications/product: servicedef/services_shipment.xml src/org/ofbiz/shipment/packing/PackingServices.java src/org/ofbiz/shipment/packing/PackingSession.java webapp/facility/shipment/PackOrder.ftl

Adrian Crum
[hidden email] wrote:

> Author: jleroux
> Date: Thu Feb 19 17:19:48 2009
> New Revision: 745931
>
> URL: http://svn.apache.org/viewvc?rev=745931&view=rev
> Log:
> A slightly modified patch from Karim Rahimpur "Packing issues: weights and remaining items" https://issues.apache.org/jira/browse/OFBIZ-2163 OFBIZ-2163
> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java?rev=745931&r1=745930&r2=745931&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java (original)
> +++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java Thu Feb 19 17:19:48 2009
> @@ -70,6 +70,23 @@
>          return ServiceUtil.returnSuccess();
>      }
>  
> +    /**
> +     * <p>Create or update package lines.</p>
> +     * <p>Context parameters:
> +     * <ul>
> +     * <li>selInfo - selected rows</li>
> +     * <li>iteInfo - orderItemIds</li>
> +     * <li>prdInfo - productIds</li>
> +     * <li>pkgInfo - package numbers</li>
> +     * <li>wgtInfo - weights to pack</li>
> +     * <li>numPackagesInfo - number of packages to pack per line (>= 1, default: 1)<br/>
> +     * Packs the same items n times in consecutive packages, starting from the package number retrieved from pkgInfo.</li>
> +     * <ul>

Oops?

-Adrian
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r745931 - in /ofbiz/trunk/applications/product: servicedef/services_shipment.xml src/org/ofbiz/shipment/packing/PackingServices.java src/org/ofbiz/shipment/packing/PackingSession.java webapp/facility/shipment/PackOrder.ftl

Jacques Le Roux
Administrator
Karim  decided to document packBulk context content. Do you mean that we should just put them before the corresponding block and not
like if they were arguments of packBulk (actually they are parts of context) ?
Jacques

From: "Adrian Crum" <[hidden email]>

> [hidden email] wrote:
>> Author: jleroux
>> Date: Thu Feb 19 17:19:48 2009
>> New Revision: 745931
>>
>> URL: http://svn.apache.org/viewvc?rev=745931&view=rev
>> Log:
>> A slightly modified patch from Karim Rahimpur "Packing issues: weights and remaining items"
>> https://issues.apache.org/jira/browse/OFBIZ-2163 OFBIZ-2163
>> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java?rev=745931&r1=745930&r2=745931&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java (original)
>> +++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java Thu Feb 19 17:19:48 2009
>> @@ -70,6 +70,23 @@
>>          return ServiceUtil.returnSuccess();
>>      }
>>  +    /**
>> +     * <p>Create or update package lines.</p>
>> +     * <p>Context parameters:
>> +     * <ul>
>> +     * <li>selInfo - selected rows</li>
>> +     * <li>iteInfo - orderItemIds</li>
>> +     * <li>prdInfo - productIds</li>
>> +     * <li>pkgInfo - package numbers</li>
>> +     * <li>wgtInfo - weights to pack</li>
>> +     * <li>numPackagesInfo - number of packages to pack per line (>= 1, default: 1)<br/>
>> +     * Packs the same items n times in consecutive packages, starting from the package number retrieved from pkgInfo.</li>
>> +     * <ul>
>
> Oops?
>
> -Adrian
>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r745931 - in /ofbiz/trunk/applications/product: servicedef/services_shipment.xml src/org/ofbiz/shipment/packing/PackingServices.java src/org/ofbiz/shipment/packing/PackingSession.java webapp/facility/shipment/PackOrder.ftl

Adrian Crum
No, the JavaDocs are wrong. That last line should be

+     * </ul>

Sorry, I should have been more specific.

-Adrian


Jacques Le Roux wrote:

> Karim  decided to document packBulk context content. Do you mean that we
> should just put them before the corresponding block and not like if they
> were arguments of packBulk (actually they are parts of context) ?
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> [hidden email] wrote:
>>> Author: jleroux
>>> Date: Thu Feb 19 17:19:48 2009
>>> New Revision: 745931
>>>
>>> URL: http://svn.apache.org/viewvc?rev=745931&view=rev
>>> Log:
>>> A slightly modified patch from Karim Rahimpur "Packing issues:
>>> weights and remaining items"
>>> https://issues.apache.org/jira/browse/OFBIZ-2163 OFBIZ-2163
>>> Modified:
>>> ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java?rev=745931&r1=745930&r2=745931&view=diff 
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
>>> Thu Feb 19 17:19:48 2009
>>> @@ -70,6 +70,23 @@
>>>          return ServiceUtil.returnSuccess();
>>>      }
>>>  +    /**
>>> +     * <p>Create or update package lines.</p>
>>> +     * <p>Context parameters:
>>> +     * <ul>
>>> +     * <li>selInfo - selected rows</li>
>>> +     * <li>iteInfo - orderItemIds</li>
>>> +     * <li>prdInfo - productIds</li>
>>> +     * <li>pkgInfo - package numbers</li>
>>> +     * <li>wgtInfo - weights to pack</li>
>>> +     * <li>numPackagesInfo - number of packages to pack per line (>=
>>> 1, default: 1)<br/>
>>> +     * Packs the same items n times in consecutive packages,
>>> starting from the package number retrieved from pkgInfo.</li>
>>> +     * <ul>
>>
>> Oops?
>>
>> -Adrian
>>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r745931 - in /ofbiz/trunk/applications/product: servicedef/services_shipment.xml src/org/ofbiz/shipment/packing/PackingServices.java src/org/ofbiz/shipment/packing/PackingSession.java webapp/facility/shipment/PackOrder.ftl

Jacques Le Roux
Administrator
Ha yes :o)

Done in revision 746281.

Thanks

Jacques

From: "Adrian Crum" <[hidden email]>

> No, the JavaDocs are wrong. That last line should be
>
> +     * </ul>
>
> Sorry, I should have been more specific.
>
> -Adrian
>
>
> Jacques Le Roux wrote:
>> Karim  decided to document packBulk context content. Do you mean that we should just put them before the corresponding block and
>> not like if they were arguments of packBulk (actually they are parts of context) ?
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Thu Feb 19 17:19:48 2009
>>>> New Revision: 745931
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=745931&view=rev
>>>> Log:
>>>> A slightly modified patch from Karim Rahimpur "Packing issues: weights and remaining items"
>>>> https://issues.apache.org/jira/browse/OFBIZ-2163 OFBIZ-2163
>>>> Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java?rev=745931&r1=745930&r2=745931&view=diff
>>>> ==============================================================================
>>>> ---
>>>> ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java (original)
>>>> +++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingServices.java Thu Feb 19 17:19:48 2009
>>>> @@ -70,6 +70,23 @@
>>>>          return ServiceUtil.returnSuccess();
>>>>      }
>>>>  +    /**
>>>> +     * <p>Create or update package lines.</p>
>>>> +     * <p>Context parameters:
>>>> +     * <ul>
>>>> +     * <li>selInfo - selected rows</li>
>>>> +     * <li>iteInfo - orderItemIds</li>
>>>> +     * <li>prdInfo - productIds</li>
>>>> +     * <li>pkgInfo - package numbers</li>
>>>> +     * <li>wgtInfo - weights to pack</li>
>>>> +     * <li>numPackagesInfo - number of packages to pack per line (>= 1, default: 1)<br/>
>>>> +     * Packs the same items n times in consecutive packages, starting from the package number retrieved from pkgInfo.</li>
>>>> +     * <ul>
>>>
>>> Oops?
>>>
>>> -Adrian
>>>
>>
>>
>>
>