OFBiz › OFBiz - Dev

Re: svn commit: r746649 - /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r746649 - /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

Jacques Le Roux
Administrator
Should we not preferably solve the origin of the issue ? Are there any side-effects coming from this change ? Else why a
request-redirect was previously used ?

Jacques

From: <[hidden email]>

> Author: hansbak
> Date: Sun Feb 22 09:04:32 2009
> New Revision: 746649
>
> URL: http://svn.apache.org/viewvc?rev=746649&view=rev
> Log:
> after a request-redirect the request parameters do not seem to carry over? change to 'request'
>
> Modified:
>    ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
>
> Modified: ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=746649&r1=746648&r2=746649&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml (original)
> +++ ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml Sun Feb 22 09:04:32 2009
> @@ -357,7 +357,7 @@
>     <request-map uri="updatePerson">
>         <security https="true" auth="true"/>
>         <event type="service" path="" invoke="updatePerson"/>
> -        <response name="success" type="request-redirect" value="viewprofile"/>
> +        <response name="success" type="request" value="viewprofile"/>
>         <response name="error" type="view" value="EditPerson"/>
>     </request-map>
>
> @@ -371,7 +371,7 @@
>     <request-map uri="updatePartyGroup">
>         <security https="true" auth="true"/>
>         <event type="service" path="" invoke="updatePartyGroup"/>
> -        <response name="success" type="request-redirect" value="viewprofile"/>
> +        <response name="success" type="request" value="viewprofile"/>
>         <response name="error" type="view" value="EditPartyGroup"/>
>     </request-map>
>
>
>


David E Jones-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r746649 - /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

David E Jones-3

This is probably caused by the fix for the long-standing issue with  
the old stuff that put form fields in the URL string. Now the behavior  
of the request-redirect response is:

1. use the redirect-parameter fields if there are any specified
2. if there are no redirect-parameter fields specific then ONLY the  
URL parameters will be included automatically, the form field ones  
will not

The best fix to this issue is to add a redirect-parameter sub-element  
under the response element for the field "partyId".

-David


On Feb 23, 2009, at 12:25 AM, Jacques Le Roux wrote:

> Should we not preferably solve the origin of the issue ? Are there  
> any side-effects coming from this change ? Else why a request-
> redirect was previously used ?
>
> Jacques
>
> From: <[hidden email]>
>> Author: hansbak
>> Date: Sun Feb 22 09:04:32 2009
>> New Revision: 746649
>>
>> URL: http://svn.apache.org/viewvc?rev=746649&view=rev
>> Log:
>> after a request-redirect the request parameters do not seem to  
>> carry over? change to 'request'
>>
>> Modified:
>>   ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>> controller.xml
>>
>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>> controller.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=746649&r1=746648&r2=746649&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>> controller.xml (original)
>> +++ ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>> controller.xml Sun Feb 22 09:04:32 2009
>> @@ -357,7 +357,7 @@
>>    <request-map uri="updatePerson">
>>        <security https="true" auth="true"/>
>>        <event type="service" path="" invoke="updatePerson"/>
>> -        <response name="success" type="request-redirect"  
>> value="viewprofile"/>
>> +        <response name="success" type="request"  
>> value="viewprofile"/>
>>        <response name="error" type="view" value="EditPerson"/>
>>    </request-map>
>>
>> @@ -371,7 +371,7 @@
>>    <request-map uri="updatePartyGroup">
>>        <security https="true" auth="true"/>
>>        <event type="service" path="" invoke="updatePartyGroup"/>
>> -        <response name="success" type="request-redirect"  
>> value="viewprofile"/>
>> +        <response name="success" type="request"  
>> value="viewprofile"/>
>>        <response name="error" type="view" value="EditPartyGroup"/>
>>    </request-map>
>>
>>
>
>

hans_bakker
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r746649 - /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

hans_bakker
Thank you david, i was provoking this a bit, and thank you for the
explanation. I knew there was changed something but forgot what it
was....So the request is fine here.

regards,
Hans

On Mon, 2009-02-23 at 01:58 -0700, David E Jones wrote:

> This is probably caused by the fix for the long-standing issue with  
> the old stuff that put form fields in the URL string. Now the behavior  
> of the request-redirect response is:
>
> 1. use the redirect-parameter fields if there are any specified
> 2. if there are no redirect-parameter fields specific then ONLY the  
> URL parameters will be included automatically, the form field ones  
> will not
>
> The best fix to this issue is to add a redirect-parameter sub-element  
> under the response element for the field "partyId".
>
> -David
>
>
> On Feb 23, 2009, at 12:25 AM, Jacques Le Roux wrote:
>
> > Should we not preferably solve the origin of the issue ? Are there  
> > any side-effects coming from this change ? Else why a request-
> > redirect was previously used ?
> >
> > Jacques
> >
> > From: <[hidden email]>
> >> Author: hansbak
> >> Date: Sun Feb 22 09:04:32 2009
> >> New Revision: 746649
> >>
> >> URL: http://svn.apache.org/viewvc?rev=746649&view=rev
> >> Log:
> >> after a request-redirect the request parameters do not seem to  
> >> carry over? change to 'request'
> >>
> >> Modified:
> >>   ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
> >> controller.xml
> >>
> >> Modified: ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
> >> controller.xml
> >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=746649&r1=746648&r2=746649&view=diff
> >> =
> >> =
> >> =
> >> =
> >> =
> >> =
> >> =
> >> =
> >> =
> >> =====================================================================
> >> --- ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
> >> controller.xml (original)
> >> +++ ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
> >> controller.xml Sun Feb 22 09:04:32 2009
> >> @@ -357,7 +357,7 @@
> >>    <request-map uri="updatePerson">
> >>        <security https="true" auth="true"/>
> >>        <event type="service" path="" invoke="updatePerson"/>
> >> -        <response name="success" type="request-redirect"  
> >> value="viewprofile"/>
> >> +        <response name="success" type="request"  
> >> value="viewprofile"/>
> >>        <response name="error" type="view" value="EditPerson"/>
> >>    </request-map>
> >>
> >> @@ -371,7 +371,7 @@
> >>    <request-map uri="updatePartyGroup">
> >>        <security https="true" auth="true"/>
> >>        <event type="service" path="" invoke="updatePartyGroup"/>
> >> -        <response name="success" type="request-redirect"  
> >> value="viewprofile"/>
> >> +        <response name="success" type="request"  
> >> value="viewprofile"/>
> >>        <response name="error" type="view" value="EditPartyGroup"/>
> >>    </request-map>
> >>
> >>
> >
> >
>
--
Antwebsystems.com: Quality OFBiz services for competitive rates

David E Jones-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r746649 - /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

David E Jones-3

Yes, request is fine, and in many/most cases request-redirect will  
result in a better user experience. The example application now has  
pretty complete examples of this where it goes back to a "clean" URL  
that represents a view instead of the URL for the form submission.

-David


On Feb 23, 2009, at 2:58 AM, Hans Bakker wrote:

> Thank you david, i was provoking this a bit, and thank you for the
> explanation. I knew there was changed something but forgot what it
> was....So the request is fine here.
>
> regards,
> Hans
>
> On Mon, 2009-02-23 at 01:58 -0700, David E Jones wrote:
>> This is probably caused by the fix for the long-standing issue with
>> the old stuff that put form fields in the URL string. Now the  
>> behavior
>> of the request-redirect response is:
>>
>> 1. use the redirect-parameter fields if there are any specified
>> 2. if there are no redirect-parameter fields specific then ONLY the
>> URL parameters will be included automatically, the form field ones
>> will not
>>
>> The best fix to this issue is to add a redirect-parameter sub-element
>> under the response element for the field "partyId".
>>
>> -David
>>
>>
>> On Feb 23, 2009, at 12:25 AM, Jacques Le Roux wrote:
>>
>>> Should we not preferably solve the origin of the issue ? Are there
>>> any side-effects coming from this change ? Else why a request-
>>> redirect was previously used ?
>>>
>>> Jacques
>>>
>>> From: <[hidden email]>
>>>> Author: hansbak
>>>> Date: Sun Feb 22 09:04:32 2009
>>>> New Revision: 746649
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=746649&view=rev
>>>> Log:
>>>> after a request-redirect the request parameters do not seem to
>>>> carry over? change to 'request'
>>>>
>>>> Modified:
>>>>  ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>>>> controller.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>>>> controller.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=746649&r1=746648&r2=746649&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>>>> controller.xml (original)
>>>> +++ ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/
>>>> controller.xml Sun Feb 22 09:04:32 2009
>>>> @@ -357,7 +357,7 @@
>>>>   <request-map uri="updatePerson">
>>>>       <security https="true" auth="true"/>
>>>>       <event type="service" path="" invoke="updatePerson"/>
>>>> -        <response name="success" type="request-redirect"
>>>> value="viewprofile"/>
>>>> +        <response name="success" type="request"
>>>> value="viewprofile"/>
>>>>       <response name="error" type="view" value="EditPerson"/>
>>>>   </request-map>
>>>>
>>>> @@ -371,7 +371,7 @@
>>>>   <request-map uri="updatePartyGroup">
>>>>       <security https="true" auth="true"/>
>>>>       <event type="service" path="" invoke="updatePartyGroup"/>
>>>> -        <response name="success" type="request-redirect"
>>>> value="viewprofile"/>
>>>> +        <response name="success" type="request"
>>>> value="viewprofile"/>
>>>>       <response name="error" type="view" value="EditPartyGroup"/>
>>>>   </request-map>
>>>>
>>>>
>>>
>>>
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive rates
>

Free forum by Nabble Edit this page