Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

David E Jones-3

To remove the script directories from the classpath you would remove  
their classpath entries from the various ofbiz-component.xml files (ie  
that is where they are added to the classpath).

-David


On Apr 22, 2009, at 4:13 AM, Jacques Le Roux wrote:

> Hi David,
>
> Your suggestion was,
>
>> Once those are done we could probably remove the ${component-dir}/  
>> script directory from the classpath.
>
> I'm not sure to understand what you mean by this. Or maybe, I tried  
> and it does not work, in this case simply ignore this (last) message  
> (hope it's understandable)
>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> Thankd for your answers guys,
>>
>> Yes I know that. I recently automatically refactored all links at  
>> r765798
>> http://markmail.org/message/xe6a7zdpwwewxnxy
>>
>> Actually I was trying to follow David's suggestion from his answer  
>> to Ashish
>> http://markmail.org/message/to2jynvgthh6j756
>>
>> I was not sure to clearly understand his suggestion though, and I  
>> think now my interpretation is totally wrong. Could you please  
>> explain your idea David ?
>>
>> Thanks
>>
>> Jacques
>> PS: BTW I found some links I did not refactor even at r765808 where  
>> I already said
>> One more time caught by a file edited in Eclipse and not saved  
>> during S/R (related to r765798)
>> Fixed at r767060
>>
>> From: "Ashish Vijaywargiya" <[hidden email]>
>>> +1
>>>
>>> --
>>> Ashish
>>>
>>> On Tue, Apr 21, 2009 at 9:01 AM, Adrian Crum  
>>> <[hidden email]> wrote:
>>>
>>>>
>>>> I think the answer Jacques is looking for is: Yes, you did  
>>>> something wrong.
>>>>
>>>> The correct component:// URL is:
>>>>
>>>> <event type="simple"
>>>> path="component://accounting/script/org/ofbiz/accounting/payment/
>>>> PaymentMethodEvents.xml"
>>>> invoke="updateCreditCard"/>
>>>>
>>>> The correct classpath is:
>>>>
>>>> <event type="simple"
>>>> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>>>> invoke="updateCreditCard"/>
>>>>
>>>> From what I recall, the component:// version has a more efficient  
>>>> lookup
>>>> algorithm - and as David mentioned, it is generally better to use.
>>>>
>>>> -Adrian
>>>>
>>>>
>>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Jacques Le Roux
Administrator
Done at revision: 771090  

Jacques

From: "David E Jones" <[hidden email]>

>
> To remove the script directories from the classpath you would remove  
> their classpath entries from the various ofbiz-component.xml files (ie  
> that is where they are added to the classpath).
>
> -David
>
>
> On Apr 22, 2009, at 4:13 AM, Jacques Le Roux wrote:
>
>> Hi David,
>>
>> Your suggestion was,
>>
>>> Once those are done we could probably remove the ${component-dir}/  
>>> script directory from the classpath.
>>
>> I'm not sure to understand what you mean by this. Or maybe, I tried  
>> and it does not work, in this case simply ignore this (last) message  
>> (hope it's understandable)
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <[hidden email]>
>>> Thankd for your answers guys,
>>>
>>> Yes I know that. I recently automatically refactored all links at  
>>> r765798
>>> http://markmail.org/message/xe6a7zdpwwewxnxy
>>>
>>> Actually I was trying to follow David's suggestion from his answer  
>>> to Ashish
>>> http://markmail.org/message/to2jynvgthh6j756
>>>
>>> I was not sure to clearly understand his suggestion though, and I  
>>> think now my interpretation is totally wrong. Could you please  
>>> explain your idea David ?
>>>
>>> Thanks
>>>
>>> Jacques
>>> PS: BTW I found some links I did not refactor even at r765808 where  
>>> I already said
>>> One more time caught by a file edited in Eclipse and not saved  
>>> during S/R (related to r765798)
>>> Fixed at r767060
>>>
>>> From: "Ashish Vijaywargiya" <[hidden email]>
>>>> +1
>>>>
>>>> --
>>>> Ashish
>>>>
>>>> On Tue, Apr 21, 2009 at 9:01 AM, Adrian Crum  
>>>> <[hidden email]> wrote:
>>>>
>>>>>
>>>>> I think the answer Jacques is looking for is: Yes, you did  
>>>>> something wrong.
>>>>>
>>>>> The correct component:// URL is:
>>>>>
>>>>> <event type="simple"
>>>>> path="component://accounting/script/org/ofbiz/accounting/payment/
>>>>> PaymentMethodEvents.xml"
>>>>> invoke="updateCreditCard"/>
>>>>>
>>>>> The correct classpath is:
>>>>>
>>>>> <event type="simple"
>>>>> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>>>>> invoke="updateCreditCard"/>
>>>>>
>>>>> From what I recall, the component:// version has a more efficient  
>>>>> lookup
>>>>> algorithm - and as David mentioned, it is generally better to use.
>>>>>
>>>>> -Adrian
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>>
>

12