Re: svn commit: r762208 - /ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl

[hans_bakker]

Are you sure this is required Jacques? It was working fine.....

and "href="javascript:document.createProductionRunsForShipment.submit"

does not seem ok.....

Regards,
Hans


On Mon, 2009-04-06 at 04:41 +0000, [hidden email] wrote:

> Author: jleroux
> Date: Mon Apr  6 04:41:08 2009
> New Revision: 762208
>
> URL: http://svn.apache.org/viewvc?rev=762208&view=rev
> Log:
> Should fix https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695160&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695160
>
> Modified:
>     ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
>
> Modified: ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl?rev=762208&r1=762207&r2=762208&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl (original)
> +++ ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl Mon Apr  6 04:41:08 2009
> @@ -26,15 +26,21 @@
>    <div class="screenlet-title-bar">
>      <ul>
>        <li class="h3">Available portlets</li>
> -      <li><a href="<@ofbizUrl>ManagePortalPages?portalPageId=${parameters.portalPageId}&parentPortalPageId=${parameters.parentPortalPageId}</@ofbizUrl>">${uiLabelMap.CommonCancel}</a></li>
> +      <li>
> +        <form name="ManagePortalPages" method= "post" action= "<@ofbizUrl>ManagePortalPages</@ofbizUrl>">
> +          <input type= "hidden" name= "portalPageId" value= "${parameters.portalPageId}">
> +          <input type= "hidden" name= "parentPortalPageId" value= "${parameters.parentPortalPageId}">
> +          <a href="javascript:document.createProductionRunsForShipment.submit()" class="buttontext">${uiLabelMap.CommonCancel}</a>
> +        </form>
> +      </li>
>      </ul>
>      <br class="clear"/>
>    </div>
>    <#if portalPortlets?has_content>
> -    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
> -    
> +    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
> +
>      <table cellspacing="20" class="basic-table">
> -      <#assign leftColumn = true/>
> +      <#assign leftColumn = true/>
>        <#list portalPortlets as portalPortlet>
>          <#if leftColumn==true>
>          <tr>
> @@ -66,7 +72,7 @@
>          <#if leftColumn==false>
>          </tr>
>          </#if>
> -        <#assign leftColumn = !leftColumn/>
> +        <#assign leftColumn = !leftColumn/>
>        </#list>
>      </table>
>      <#else/>
>

--
Antwebsystems.com: Quality OFBiz services for competitive rates

[Jacques Le Roux]

Hi Hans,

No you are maybe right. I reveveted at r762221 because since this commit David explained that it was only needed for services calls
and this one is not a (direct?) service call (was just a bet and I thought it could not hurt)

Jacques
Oops, from CJay comment at
https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695986&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695986 
it seems that actually I was lucky ;o)
I will re-commit and add the fix CJay suggested if you are ok with that.
If all was widget, or at least more, life will be easier (this secure URLs task in ftl underline it)


From: "Hans Bakker" <[hidden email]>

> Are you sure this is required Jacques? It was working fine.....
>
> and "href="javascript:document.createProductionRunsForShipment.submit"
>
> does not seem ok.....
>
> Regards,
> Hans
>
>
> On Mon, 2009-04-06 at 04:41 +0000, [hidden email] wrote:
>> Author: jleroux
>> Date: Mon Apr  6 04:41:08 2009
>> New Revision: 762208
>>
>> URL: http://svn.apache.org/viewvc?rev=762208&view=rev
>> Log:
>> Should fix
>> https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695160&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695160
>>
>> Modified:
>>     ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
>>
>> Modified: ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl?rev=762208&r1=762207&r2=762208&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl (original)
>> +++ ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl Mon Apr  6 04:41:08 2009
>> @@ -26,15 +26,21 @@
>>    <div class="screenlet-title-bar">
>>      <ul>
>>        <li class="h3">Available portlets</li>
>> -      <li><a
>> href="<@ofbizUrl>ManagePortalPages?portalPageId=${parameters.portalPageId}&parentPortalPageId=${parameters.parentPortalPageId}</@ofbizUrl>">${uiLabelMap.CommonCancel}</a></li>
>> +      <li>
>> +        <form name="ManagePortalPages" method= "post" action= "<@ofbizUrl>ManagePortalPages</@ofbizUrl>">
>> +          <input type= "hidden" name= "portalPageId" value= "${parameters.portalPageId}">
>> +          <input type= "hidden" name= "parentPortalPageId" value= "${parameters.parentPortalPageId}">
>> +          <a href="javascript:document.createProductionRunsForShipment.submit()"
>> class="buttontext">${uiLabelMap.CommonCancel}</a>
>> +        </form>
>> +      </li>
>>      </ul>
>>      <br class="clear"/>
>>    </div>
>>    <#if portalPortlets?has_content>
>> -    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
>> -
>> +    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
>> +
>>      <table cellspacing="20" class="basic-table">
>> -      <#assign leftColumn = true/>
>> +      <#assign leftColumn = true/>
>>        <#list portalPortlets as portalPortlet>
>>          <#if leftColumn==true>
>>          <tr>
>> @@ -66,7 +72,7 @@
>>          <#if leftColumn==false>
>>          </tr>
>>          </#if>
>> -        <#assign leftColumn = !leftColumn/>
>> +        <#assign leftColumn = !leftColumn/>
>>        </#list>
>>      </table>
>>      <#else/>
>>
>
> --
> Antwebsystems.com: Quality OFBiz services for competitive rates
>

[Jacques Le Roux]

Hi Hans,

You were totally right
(https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12696221&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696221)
Damn Jira permlinks :D
So I kept things reverted and I also completly reverted r762149  at r764077,  please see my there comment

Jacques

From: "Jacques Le Roux" <[hidden email]>

> Hi Hans,
>
> No you are maybe right. I reveveted at r762221 because since this commit David explained that it was only needed for services
> calls and this one is not a (direct?) service call (was just a bet and I thought it could not hurt)
>
> Jacques
> Oops, from CJay comment at
> https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695986&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695986 
> it seems that actually I was lucky ;o)
> I will re-commit and add the fix CJay suggested if you are ok with that.
> If all was widget, or at least more, life will be easier (this secure URLs task in ftl underline it)
>
>
> From: "Hans Bakker" <[hidden email]>
>> Are you sure this is required Jacques? It was working fine.....
>>
>> and "href="javascript:document.createProductionRunsForShipment.submit"
>>
>> does not seem ok.....
>>
>> Regards,
>> Hans
>>
>>
>> On Mon, 2009-04-06 at 04:41 +0000, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Mon Apr  6 04:41:08 2009
>>> New Revision: 762208
>>>
>>> URL: http://svn.apache.org/viewvc?rev=762208&view=rev
>>> Log:
>>> Should fix
>>> https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695160&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695160
>>>
>>> Modified:
>>>     ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
>>>
>>> Modified: ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl?rev=762208&r1=762207&r2=762208&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl (original)
>>> +++ ofbiz/trunk/framework/common/webcommon/portal/listPortalPortlets.ftl Mon Apr  6 04:41:08 2009
>>> @@ -26,15 +26,21 @@
>>>    <div class="screenlet-title-bar">
>>>      <ul>
>>>        <li class="h3">Available portlets</li>
>>> -      <li><a
>>> href="<@ofbizUrl>ManagePortalPages?portalPageId=${parameters.portalPageId}&parentPortalPageId=${parameters.parentPortalPageId}</@ofbizUrl>">${uiLabelMap.CommonCancel}</a></li>
>>> +      <li>
>>> +        <form name="ManagePortalPages" method= "post" action= "<@ofbizUrl>ManagePortalPages</@ofbizUrl>">
>>> +          <input type= "hidden" name= "portalPageId" value= "${parameters.portalPageId}">
>>> +          <input type= "hidden" name= "parentPortalPageId" value= "${parameters.parentPortalPageId}">
>>> +          <a href="javascript:document.createProductionRunsForShipment.submit()"
>>> class="buttontext">${uiLabelMap.CommonCancel}</a>
>>> +        </form>
>>> +      </li>
>>>      </ul>
>>>      <br class="clear"/>
>>>    </div>
>>>    <#if portalPortlets?has_content>
>>> -    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
>>> -
>>> +    <#assign orderByList = Static["org.ofbiz.base.util.UtilMisc"].toList("portalPortletId")/>
>>> +
>>>      <table cellspacing="20" class="basic-table">
>>> -      <#assign leftColumn = true/>
>>> +      <#assign leftColumn = true/>
>>>        <#list portalPortlets as portalPortlet>
>>>          <#if leftColumn==true>
>>>          <tr>
>>> @@ -66,7 +72,7 @@
>>>          <#if leftColumn==false>
>>>          </tr>
>>>          </#if>
>>> -        <#assign leftColumn = !leftColumn/>
>>> +        <#assign leftColumn = !leftColumn/>
>>>        </#list>
>>>      </table>
>>>      <#else/>
>>>
>>
>> --
>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>
>
>