Re: svn commit: r766015 - /ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl

[Jacques Le Roux]

Should we not backport this commit and the previous to 9.04 ?

Jacques

From: <[hidden email]>

> Author: jacopoc
> Date: Fri Apr 17 14:02:20 2009
> New Revision: 766015
>
> URL: http://svn.apache.org/viewvc?rev=766015&view=rev
> Log:
> Added missing "
>
> Modified:
>    ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>
> Modified: ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=766015&r1=766014&r2=766015&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl (original)
> +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl Fri Apr 17 14:02:20 2009
> @@ -149,7 +149,7 @@
> <#macro renderHiddenField name value><input type="hidden" name="${name}"<#if value?has_content> value="${value}"</#if>/></#macro>
> <#macro renderIgnoredField></#macro>
>
> -<#macro renderFieldTitle style title><#if style?has_content><span class="${style}></#if>${title}<#if
> style?has_content></span></#if></#macro>
> +<#macro renderFieldTitle style title><#if style?has_content><span class="${style}"></#if>${title}<#if
> style?has_content></span></#if></#macro>
> <#macro renderSingleFormFieldTitle></#macro>
>
> <#macro renderFormOpen linkUrl formType targetWindow containerId containerStyle autocomplete name useRowSubmit><form method="post"
> action="${linkUrl}"<#if formType=="upload"> enctype="multipart/form-data"</#if><#if targetWindow?has_content>
> target="${targetWindow}"</#if><#if containerId?has_content> id="${containerId}"</#if> class=<#if
> containerStyle?has_content>"${containerStyle}"<#else>"basic-form"</#if> onSubmit="javascript:submitFormDisableSubmits(this)"<#if
> autocomplete?has_content> autocomplete="${autocomplete}"</#if> name="${name}" ><#if useRowSubmit?has_content &&
> useRowSubmit><input type="hidden" name="_useRowSubmit" value="Y"/></#if></#macro>
>
>

[Tim Ruppert]

+1

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

----- "Jacques Le Roux" <[hidden email]> wrote:

> Should we not backport this commit and the previous to 9.04 ?
>
> Jacques
>
> From: <[hidden email]>
> > Author: jacopoc
> > Date: Fri Apr 17 14:02:20 2009
> > New Revision: 766015
> >
> > URL: http://svn.apache.org/viewvc?rev=766015&view=rev
> > Log:
> > Added missing "
> >
> > Modified:
> >    ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
> >
> > Modified:
> ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=766015&r1=766014&r2=766015&view=diff
> >
> ==============================================================================
> > --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
> (original)
> > +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
> Fri Apr 17 14:02:20 2009
> > @@ -149,7 +149,7 @@
> > <#macro renderHiddenField name value><input type="hidden"
> name="${name}"<#if value?has_content>
> value="${value}"</#if>/></#macro>
> > <#macro renderIgnoredField></#macro>
> >
> > -<#macro renderFieldTitle style title><#if style?has_content><span
> class="${style}></#if>${title}<#if
> > style?has_content></span></#if></#macro>
> > +<#macro renderFieldTitle style title><#if style?has_content><span
> class="${style}"></#if>${title}<#if
> > style?has_content></span></#if></#macro>
> > <#macro renderSingleFormFieldTitle></#macro>
> >
> > <#macro renderFormOpen linkUrl formType targetWindow containerId
> containerStyle autocomplete name useRowSubmit><form method="post"
> > action="${linkUrl}"<#if formType=="upload">
> enctype="multipart/form-data"</#if><#if targetWindow?has_content>
> > target="${targetWindow}"</#if><#if containerId?has_content>
> id="${containerId}"</#if> class=<#if
> >
> containerStyle?has_content>"${containerStyle}"<#else>"basic-form"</#if>
> onSubmit="javascript:submitFormDisableSubmits(this)"<#if
> > autocomplete?has_content> autocomplete="${autocomplete}"</#if>
> name="${name}" ><#if useRowSubmit?has_content &&
> > useRowSubmit><input type="hidden" name="_useRowSubmit"
> value="Y"/></#if></#macro>
> >
> >

[Jacques Le Roux]

Done at  r766063

Jacques

From: "Tim Ruppert" <[hidden email]>

> +1
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
> ----- "Jacques Le Roux" <[hidden email]> wrote:
>
>> Should we not backport this commit and the previous to 9.04 ?
>>
>> Jacques
>>
>> From: <[hidden email]>
>> > Author: jacopoc
>> > Date: Fri Apr 17 14:02:20 2009
>> > New Revision: 766015
>> >
>> > URL: http://svn.apache.org/viewvc?rev=766015&view=rev
>> > Log:
>> > Added missing "
>> >
>> > Modified:
>> >    ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>> >
>> > Modified:
>> ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>> > URL:
>> >
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=766015&r1=766014&r2=766015&view=diff
>> >
>> ==============================================================================
>> > --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>> (original)
>> > +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>> Fri Apr 17 14:02:20 2009
>> > @@ -149,7 +149,7 @@
>> > <#macro renderHiddenField name value><input type="hidden"
>> name="${name}"<#if value?has_content>
>> value="${value}"</#if>/></#macro>
>> > <#macro renderIgnoredField></#macro>
>> >
>> > -<#macro renderFieldTitle style title><#if style?has_content><span
>> class="${style}></#if>${title}<#if
>> > style?has_content></span></#if></#macro>
>> > +<#macro renderFieldTitle style title><#if style?has_content><span
>> class="${style}"></#if>${title}<#if
>> > style?has_content></span></#if></#macro>
>> > <#macro renderSingleFormFieldTitle></#macro>
>> >
>> > <#macro renderFormOpen linkUrl formType targetWindow containerId
>> containerStyle autocomplete name useRowSubmit><form method="post"
>> > action="${linkUrl}"<#if formType=="upload">
>> enctype="multipart/form-data"</#if><#if targetWindow?has_content>
>> > target="${targetWindow}"</#if><#if containerId?has_content>
>> id="${containerId}"</#if> class=<#if
>> >
>> containerStyle?has_content>"${containerStyle}"<#else>"basic-form"</#if>
>> onSubmit="javascript:submitFormDisableSubmits(this)"<#if
>> > autocomplete?has_content> autocomplete="${autocomplete}"</#if>
>> name="${name}" ><#if useRowSubmit?has_content &&
>> > useRowSubmit><input type="hidden" name="_useRowSubmit"
>> value="Y"/></#if></#macro>
>> >
>> >
>