Re: svn commit: r766125 - in /ofbiz/trunk: .classpath LICENSE framework/base/lib/fop-0.94.jar framework/base/lib/fop-0.95.jar framework/webapp/src/org/ofbiz/webapp/view/ApacheFopWorker.java framework/webapp/src/org/ofbiz/webapp/view/FopRenderer.java

[Adam Heath-2]

[hidden email] wrote:

> Author: jleroux
> Date: Fri Apr 17 19:42:46 2009
> New Revision: 766125
>
> URL: http://svn.apache.org/viewvc?rev=766125&view=rev
> Log:
> Changes from Erwan de FERRIERES "Upgrade of the fop library (0.94 -> 0.95)" https://issues.apache.org/jira/browse/OFBIZ-2317 - OFBIZ-2317
> + LICENCE updated (libraries wiki page also updated)
>
> Added:
>     ofbiz/trunk/framework/base/lib/fop-0.95.jar   (with props)
> Removed:
>     ofbiz/trunk/framework/base/lib/fop-0.94.jar
> Modified:
>     ofbiz/trunk/.classpath
>     ofbiz/trunk/LICENSE
>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/ApacheFopWorker.java
>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/FopRenderer.java

Er, please be careful when committing things, that you *only* change
useful stuff, and don't reformat a file when doing so.

.classpath got reformatted, when you changed the library reference.
It makes it difficult to discover what was changed.

Always look at the diffs before you commit, just to double check your
changes.

> Modified: ofbiz/trunk/.classpath
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=766125&r1=766124&r2=766125&view=diff
> ==============================================================================
> --- ofbiz/trunk/.classpath (original)
> +++ ofbiz/trunk/.classpath Fri Apr 17 19:42:46 2009
> @@ -1,170 +1,170 @@
>  <?xml version="1.0" encoding="UTF-8"?>
>  <classpath>
> - <classpathentry kind="lib" path="framework/base/lib/fop-0.94.jar"/>
> +    <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>  </classpath>

[Jacques Le Roux]

Adam,

I did that intentionnally to remove the tabs I left there (did you notice I removed some tabs recently?). I agree I should have put
a note, nobody's perfect

Jacques

From: "Adam Heath" <[hidden email]>

> [hidden email] wrote:
>> Author: jleroux
>> Date: Fri Apr 17 19:42:46 2009
>> New Revision: 766125
>>
>> URL: http://svn.apache.org/viewvc?rev=766125&view=rev
>> Log:
>> Changes from Erwan de FERRIERES "Upgrade of the fop library (0.94 -> 0.95)" https://issues.apache.org/jira/browse/OFBIZ-2317 -
>> OFBIZ-2317
>> + LICENCE updated (libraries wiki page also updated)
>>
>> Added:
>>     ofbiz/trunk/framework/base/lib/fop-0.95.jar   (with props)
>> Removed:
>>     ofbiz/trunk/framework/base/lib/fop-0.94.jar
>> Modified:
>>     ofbiz/trunk/.classpath
>>     ofbiz/trunk/LICENSE
>>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/ApacheFopWorker.java
>>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/FopRenderer.java
>
> Er, please be careful when committing things, that you *only* change
> useful stuff, and don't reformat a file when doing so.
>
> .classpath got reformatted, when you changed the library reference.
> It makes it difficult to discover what was changed.
>
> Always look at the diffs before you commit, just to double check your
> changes.
>
>> Modified: ofbiz/trunk/.classpath
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=766125&r1=766124&r2=766125&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/.classpath (original)
>> +++ ofbiz/trunk/.classpath Fri Apr 17 19:42:46 2009
>> @@ -1,170 +1,170 @@
>>  <?xml version="1.0" encoding="UTF-8"?>
>>  <classpath>
>> - <classpathentry kind="lib" path="framework/base/lib/fop-0.94.jar"/>
>> +    <classpathentry kind="lib" path="framework/base/lib/fop-0.95.jar"/>
>>  </classpath>
>

[Adam Heath-2]

Jacques Le Roux wrote:
> Adam,
>
> I did that intentionnally to remove the tabs I left there (did you
> notice I removed some tabs recently?). I agree I should have put a note,
> nobody's perfect

I have no problem with space/reformat patches.  They just need to be
kept separate from real changes, to make it easier to do bisection.

And, my email wasn't direct specifically at you, it was more a general
best-practices type email.

Plus, you can't be not-perfect.  I have that market cornered myself.

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>
> Jacques Le Roux wrote:
>> Adam,
>>
>> I did that intentionnally to remove the tabs I left there (did you
>> notice I removed some tabs recently?). I agree I should have put a note,
>> nobody's perfect
>
> I have no problem with space/reformat patches.  They just need to be
> kept separate from real changes, to make it easier to do bisection.

Yes, sure you are totally right on this!
 
> And, my email wasn't direct specifically at you, it was more a general
> best-practices type email.
>
> Plus, you can't be not-perfect.  I have that market cornered myself.

Damn... another niche already taken :/

Jacques

[Adam Heath-2]

Jacques Le Roux wrote:
> Yes, sure you are totally right on this!

Can I quote you out of context in the future on this?  I'm always right!