Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
Locked
Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
 
|
IMO, this is not required at all except the one change that is to make
contactMechId optional (because of earlier changes done by Andrew r765412). The current service does support this. I have tested the service createLead several times on earlier revision and it is working fine for me. To create a lead we have two options create lead and quick add lead and both of these are working fine. With former postal address is required and with latter postal address is not required. Please correct me if I am wrong. Vikas On Apr 18, 2009, at 11:46 AM, [hidden email] wrote: > Author: jonesde > Date: Sat Apr 18 06:16:38 2009 > New Revision: 766236 > > URL: http://svn.apache.org/viewvc?rev=766236&view=rev > Log: > Applied patch from Ean Schuessler in OFBIZ-2310, also changed > service def for createLead to not require contactMechId out as there > was an error from that in testing > > Modified: > ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ > LeadServices.xml > ofbiz/trunk/applications/marketing/servicedef/services.xml > > Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/ > lead/LeadServices.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=766236&r1=766235&r2=766236&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ > LeadServices.xml (original) > +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ > LeadServices.xml Sat Apr 18 06:16:38 2009 > @@ -53,6 +53,36 @@ > <result-to-result result-name="contactMechId" > service-result-name="contactMechId"/> > </call-service> > </if-not-empty> > + <if-not-empty field="parameters.address1"> > + <call-map-processor in-map-name="parameters" out- > map-name="postalAddressCtx"> > + <simple-map-processor name="postalAddress"> > + <process field="address1"> > + <copy/> > + </process> > + <process field="address2"> > + <copy/> > + </process> > + <process field="city"> > + <copy/> > + </process> > + <process field="stateProvinceGeoId"> > + <copy/> > + </process> > + <process field="countryGeoId"> > + <copy/> > + </process> > + <process field="postalCode"> > + <copy/> > + </process> > + </simple-map-processor> > + </call-map-processor> > + <check-errors/> > + <set field="postalAddressCtx.partyId" from- > field="partyId"/> > + <set > field="postalAddressCtx.contactMechPurposeTypeId" > value="PRIMARY_LOCATION"/> > + <call-service service- > name="createPartyPostalAddress" in-map-name="postalAddressCtx"> > + <result-to-field result-name="contactMechId" > field="postalContactMechId"/> > + </call-service> > + </if-not-empty> > </else> > </if-compare> > > > Modified: ofbiz/trunk/applications/marketing/servicedef/services.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=766236&r1=766235&r2=766236&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/marketing/servicedef/services.xml > (original) > +++ ofbiz/trunk/applications/marketing/servicedef/services.xml Sat > Apr 18 06:16:38 2009 > @@ -385,8 +385,7 @@ > </service> > > <!-- lead services --> > - <service name="createLead" engine="simple" > - location="component://marketing/script/org/ofbiz/sfa/lead/ > LeadServices.xml" invoke="createLead"> > + <service name="createLead" engine="simple" > location="component://marketing/script/org/ofbiz/sfa/lead/ > LeadServices.xml" invoke="createLead"> > <description>Create a Lead Person or Group</description> > <auto-attributes entity-name="Person" mode="IN" > optional="true"> > <exclude field-name="partyId"/> > @@ -398,7 +397,7 @@ > <exclude field-name="contactMechId"/> > </auto-attributes> > <attribute name="partyId" type="String" mode="OUT"/> > - <attribute name="contactMechId" type="String" mode="OUT" /> > + <attribute name="contactMechId" type="String" mode="OUT" > optional="true"/> > <attribute name="emailAddress" type="String" mode="IN" > optional="true"/> > <attribute name="groupName" type="String" mode="IN" > optional="true"/> > <attribute name="title" type="String" mode="IN" > optional="true"/> > > |
smime.p7s (3K)
Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
|
|
To add to my last reply ...
The profile page probably need to be fixed in SFA because the contact information (if postal address) does not appear, but if I go and check the profile of the lead so created from SFA in Partymgr it does show the postal information. I did not look into the code but it may be associated with the purpose type of contact address. Vikas On Apr 18, 2009, at 12:57 PM, Vikas Mayur wrote: > IMO, this is not required at all except the one change that is to > make contactMechId optional (because of earlier changes done by > Andrew r765412). > The current service does support this. I have tested the service > createLead several times on earlier revision and it is working fine > for me. > To create a lead we have two options create lead and quick add lead > and both of these are working fine. With former postal address is > required and with latter postal address is not required. > > Please correct me if I am wrong. > > Vikas > > On Apr 18, 2009, at 11:46 AM, [hidden email] wrote: > >> Author: jonesde >> Date: Sat Apr 18 06:16:38 2009 >> New Revision: 766236 >> >> URL: http://svn.apache.org/viewvc?rev=766236&view=rev >> Log: >> Applied patch from Ean Schuessler in OFBIZ-2310, also changed >> service def for createLead to not require contactMechId out as >> there was an error from that in testing >> >> Modified: >> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >> LeadServices.xml >> ofbiz/trunk/applications/marketing/servicedef/services.xml >> >> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/ >> lead/LeadServices.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=766236&r1=766235&r2=766236&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >> LeadServices.xml (original) >> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >> LeadServices.xml Sat Apr 18 06:16:38 2009 >> @@ -53,6 +53,36 @@ >> <result-to-result result-name="contactMechId" >> service-result-name="contactMechId"/> >> </call-service> >> </if-not-empty> >> + <if-not-empty field="parameters.address1"> >> + <call-map-processor in-map-name="parameters" out- >> map-name="postalAddressCtx"> >> + <simple-map-processor name="postalAddress"> >> + <process field="address1"> >> + <copy/> >> + </process> >> + <process field="address2"> >> + <copy/> >> + </process> >> + <process field="city"> >> + <copy/> >> + </process> >> + <process field="stateProvinceGeoId"> >> + <copy/> >> + </process> >> + <process field="countryGeoId"> >> + <copy/> >> + </process> >> + <process field="postalCode"> >> + <copy/> >> + </process> >> + </simple-map-processor> >> + </call-map-processor> >> + <check-errors/> >> + <set field="postalAddressCtx.partyId" from- >> field="partyId"/> >> + <set >> field="postalAddressCtx.contactMechPurposeTypeId" >> value="PRIMARY_LOCATION"/> >> + <call-service service- >> name="createPartyPostalAddress" in-map-name="postalAddressCtx"> >> + <result-to-field result-name="contactMechId" >> field="postalContactMechId"/> >> + </call-service> >> + </if-not-empty> >> </else> >> </if-compare> >> >> >> Modified: ofbiz/trunk/applications/marketing/servicedef/services.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=766236&r1=766235&r2=766236&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/marketing/servicedef/services.xml >> (original) >> +++ ofbiz/trunk/applications/marketing/servicedef/services.xml Sat >> Apr 18 06:16:38 2009 >> @@ -385,8 +385,7 @@ >> </service> >> >> <!-- lead services --> >> - <service name="createLead" engine="simple" >> - location="component://marketing/script/org/ofbiz/sfa/lead/ >> LeadServices.xml" invoke="createLead"> >> + <service name="createLead" engine="simple" >> location="component://marketing/script/org/ofbiz/sfa/lead/ >> LeadServices.xml" invoke="createLead"> >> <description>Create a Lead Person or Group</description> >> <auto-attributes entity-name="Person" mode="IN" >> optional="true"> >> <exclude field-name="partyId"/> >> @@ -398,7 +397,7 @@ >> <exclude field-name="contactMechId"/> >> </auto-attributes> >> <attribute name="partyId" type="String" mode="OUT"/> >> - <attribute name="contactMechId" type="String" mode="OUT" /> >> + <attribute name="contactMechId" type="String" mode="OUT" >> optional="true"/> >> <attribute name="emailAddress" type="String" mode="IN" >> optional="true"/> >> <attribute name="groupName" type="String" mode="IN" >> optional="true"/> >> <attribute name="title" type="String" mode="IN" >> optional="true"/> >> >> > |
Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
|
|
Hi David,
I have fixed the sfa profile issue in r766636 and reverted part of your commit (since createLead was working with the existing implementation and this was kind of not used and unreachable code) in r766642. Btw, I am not able to commit these changes to release09.04 branch, getting 403 forbidden error. I have also send a message to you internally. Vikas On Apr 18, 2009, at 1:03 PM, Vikas Mayur wrote: > To add to my last reply ... > > The profile page probably need to be fixed in SFA because the > contact information (if postal address) does not appear, but if I go > and check the profile of the lead so created from SFA in Partymgr it > does show the postal information. I did not look into the code but > it may be associated with the purpose type of contact address. > > Vikas > > On Apr 18, 2009, at 12:57 PM, Vikas Mayur wrote: > >> IMO, this is not required at all except the one change that is to >> make contactMechId optional (because of earlier changes done by >> Andrew r765412). >> The current service does support this. I have tested the service >> createLead several times on earlier revision and it is working fine >> for me. >> To create a lead we have two options create lead and quick add lead >> and both of these are working fine. With former postal address is >> required and with latter postal address is not required. >> >> Please correct me if I am wrong. >> >> Vikas >> >> On Apr 18, 2009, at 11:46 AM, [hidden email] wrote: >> >>> Author: jonesde >>> Date: Sat Apr 18 06:16:38 2009 >>> New Revision: 766236 >>> >>> URL: http://svn.apache.org/viewvc?rev=766236&view=rev >>> Log: >>> Applied patch from Ean Schuessler in OFBIZ-2310, also changed >>> service def for createLead to not require contactMechId out as >>> there was an error from that in testing >>> >>> Modified: >>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>> LeadServices.xml >>> ofbiz/trunk/applications/marketing/servicedef/services.xml >>> >>> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/ >>> lead/LeadServices.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=766236&r1=766235&r2=766236&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>> LeadServices.xml (original) >>> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>> LeadServices.xml Sat Apr 18 06:16:38 2009 >>> @@ -53,6 +53,36 @@ >>> <result-to-result result-name="contactMechId" >>> service-result-name="contactMechId"/> >>> </call-service> >>> </if-not-empty> >>> + <if-not-empty field="parameters.address1"> >>> + <call-map-processor in-map-name="parameters" out- >>> map-name="postalAddressCtx"> >>> + <simple-map-processor name="postalAddress"> >>> + <process field="address1"> >>> + <copy/> >>> + </process> >>> + <process field="address2"> >>> + <copy/> >>> + </process> >>> + <process field="city"> >>> + <copy/> >>> + </process> >>> + <process field="stateProvinceGeoId"> >>> + <copy/> >>> + </process> >>> + <process field="countryGeoId"> >>> + <copy/> >>> + </process> >>> + <process field="postalCode"> >>> + <copy/> >>> + </process> >>> + </simple-map-processor> >>> + </call-map-processor> >>> + <check-errors/> >>> + <set field="postalAddressCtx.partyId" from- >>> field="partyId"/> >>> + <set >>> field="postalAddressCtx.contactMechPurposeTypeId" >>> value="PRIMARY_LOCATION"/> >>> + <call-service service- >>> name="createPartyPostalAddress" in-map-name="postalAddressCtx"> >>> + <result-to-field result-name="contactMechId" >>> field="postalContactMechId"/> >>> + </call-service> >>> + </if-not-empty> >>> </else> >>> </if-compare> >>> >>> >>> Modified: ofbiz/trunk/applications/marketing/servicedef/services.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=766236&r1=766235&r2=766236&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/marketing/servicedef/services.xml >>> (original) >>> +++ ofbiz/trunk/applications/marketing/servicedef/services.xml Sat >>> Apr 18 06:16:38 2009 >>> @@ -385,8 +385,7 @@ >>> </service> >>> >>> <!-- lead services --> >>> - <service name="createLead" engine="simple" >>> - location="component://marketing/script/org/ofbiz/sfa/lead/ >>> LeadServices.xml" invoke="createLead"> >>> + <service name="createLead" engine="simple" >>> location="component://marketing/script/org/ofbiz/sfa/lead/ >>> LeadServices.xml" invoke="createLead"> >>> <description>Create a Lead Person or Group</description> >>> <auto-attributes entity-name="Person" mode="IN" >>> optional="true"> >>> <exclude field-name="partyId"/> >>> @@ -398,7 +397,7 @@ >>> <exclude field-name="contactMechId"/> >>> </auto-attributes> >>> <attribute name="partyId" type="String" mode="OUT"/> >>> - <attribute name="contactMechId" type="String" mode="OUT" /> >>> + <attribute name="contactMechId" type="String" mode="OUT" >>> optional="true"/> >>> <attribute name="emailAddress" type="String" mode="IN" >>> optional="true"/> >>> <attribute name="groupName" type="String" mode="IN" >>> optional="true"/> >>> <attribute name="title" type="String" mode="IN" >>> optional="true"/> >>> >>> >> > |
Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
|
|
Re: svn commit: r766236 - in /ofbiz/trunk/applications/mark
|
|
Thanks David!
Vikas On Apr 20, 2009, at 8:32 PM, David E Jones wrote: > > Thanks for the reminder Vikas. I have added permissions for those > who have access to the apps only for branches/release09.04. > > -David > > > On Apr 20, 2009, at 4:48 AM, Vikas Mayur wrote: > >> Hi David, >> >> I have fixed the sfa profile issue in r766636 and reverted part of >> your commit (since createLead was working with the existing >> implementation and this was kind of not used and unreachable code) >> in r766642. >> >> Btw, I am not able to commit these changes to release09.04 branch, >> getting 403 forbidden error. I have also send a message to you >> internally. >> >> Vikas >> >> On Apr 18, 2009, at 1:03 PM, Vikas Mayur wrote: >> >>> To add to my last reply ... >>> >>> The profile page probably need to be fixed in SFA because the >>> contact information (if postal address) does not appear, but if I >>> go and check the profile of the lead so created from SFA in >>> Partymgr it does show the postal information. I did not look into >>> the code but it may be associated with the purpose type of contact >>> address. >>> >>> Vikas >>> >>> On Apr 18, 2009, at 12:57 PM, Vikas Mayur wrote: >>> >>>> IMO, this is not required at all except the one change that is to >>>> make contactMechId optional (because of earlier changes done by >>>> Andrew r765412). >>>> The current service does support this. I have tested the service >>>> createLead several times on earlier revision and it is working >>>> fine for me. >>>> To create a lead we have two options create lead and quick add >>>> lead and both of these are working fine. With former postal >>>> address is required and with latter postal address is not required. >>>> >>>> Please correct me if I am wrong. >>>> >>>> Vikas >>>> >>>> On Apr 18, 2009, at 11:46 AM, [hidden email] wrote: >>>> >>>>> Author: jonesde >>>>> Date: Sat Apr 18 06:16:38 2009 >>>>> New Revision: 766236 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=766236&view=rev >>>>> Log: >>>>> Applied patch from Ean Schuessler in OFBIZ-2310, also changed >>>>> service def for createLead to not require contactMechId out as >>>>> there was an error from that in testing >>>>> >>>>> Modified: >>>>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>>>> LeadServices.xml >>>>> ofbiz/trunk/applications/marketing/servicedef/services.xml >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/ >>>>> sfa/lead/LeadServices.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=766236&r1=766235&r2=766236&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>>>> LeadServices.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ >>>>> LeadServices.xml Sat Apr 18 06:16:38 2009 >>>>> @@ -53,6 +53,36 @@ >>>>> <result-to-result result-name="contactMechId" >>>>> service-result-name="contactMechId"/> >>>>> </call-service> >>>>> </if-not-empty> >>>>> + <if-not-empty field="parameters.address1"> >>>>> + <call-map-processor in-map-name="parameters" >>>>> out-map-name="postalAddressCtx"> >>>>> + <simple-map-processor name="postalAddress"> >>>>> + <process field="address1"> >>>>> + <copy/> >>>>> + </process> >>>>> + <process field="address2"> >>>>> + <copy/> >>>>> + </process> >>>>> + <process field="city"> >>>>> + <copy/> >>>>> + </process> >>>>> + <process field="stateProvinceGeoId"> >>>>> + <copy/> >>>>> + </process> >>>>> + <process field="countryGeoId"> >>>>> + <copy/> >>>>> + </process> >>>>> + <process field="postalCode"> >>>>> + <copy/> >>>>> + </process> >>>>> + </simple-map-processor> >>>>> + </call-map-processor> >>>>> + <check-errors/> >>>>> + <set field="postalAddressCtx.partyId" from- >>>>> field="partyId"/> >>>>> + <set >>>>> field="postalAddressCtx.contactMechPurposeTypeId" >>>>> value="PRIMARY_LOCATION"/> >>>>> + <call-service service- >>>>> name="createPartyPostalAddress" in-map-name="postalAddressCtx"> >>>>> + <result-to-field result- >>>>> name="contactMechId" field="postalContactMechId"/> >>>>> + </call-service> >>>>> + </if-not-empty> >>>>> </else> >>>>> </if-compare> >>>>> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/servicedef/ >>>>> services.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=766236&r1=766235&r2=766236&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/servicedef/services.xml >>>>> (original) >>>>> +++ ofbiz/trunk/applications/marketing/servicedef/services.xml >>>>> Sat Apr 18 06:16:38 2009 >>>>> @@ -385,8 +385,7 @@ >>>>> </service> >>>>> >>>>> <!-- lead services --> >>>>> - <service name="createLead" engine="simple" >>>>> - location="component://marketing/script/org/ofbiz/sfa/ >>>>> lead/LeadServices.xml" invoke="createLead"> >>>>> + <service name="createLead" engine="simple" >>>>> location="component://marketing/script/org/ofbiz/sfa/lead/ >>>>> LeadServices.xml" invoke="createLead"> >>>>> <description>Create a Lead Person or Group</description> >>>>> <auto-attributes entity-name="Person" mode="IN" >>>>> optional="true"> >>>>> <exclude field-name="partyId"/> >>>>> @@ -398,7 +397,7 @@ >>>>> <exclude field-name="contactMechId"/> >>>>> </auto-attributes> >>>>> <attribute name="partyId" type="String" mode="OUT"/> >>>>> - <attribute name="contactMechId" type="String" >>>>> mode="OUT" /> >>>>> + <attribute name="contactMechId" type="String" >>>>> mode="OUT" optional="true"/> >>>>> <attribute name="emailAddress" type="String" mode="IN" >>>>> optional="true"/> >>>>> <attribute name="groupName" type="String" mode="IN" >>>>> optional="true"/> >>>>> <attribute name="title" type="String" mode="IN" >>>>> optional="true"/> >>>>> >>>>> >>>> >>> >> > |
| Free forum by Nabble | Edit this page |