Re: svn commit: r769991 - /ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java

[Andrew Zeneski-2]

Thanks Adrian,

I had actually changed SecurityConfigurationException to extend  
GeneralRuntimeException instead of GeneralException, but that didn't  
get checked in.

Andrew

On Apr 29, 2009, at 7:18 PM, [hidden email] wrote:

> Author: adrianc
> Date: Wed Apr 29 23:18:24 2009
> New Revision: 769991
>
> URL: http://svn.apache.org/viewvc?rev=769991&view=rev
> Log:
> Fixed a problem with the new auth code that was preventing  
> compilation.
>
> Modified:
>    ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/
> test/AuthorizationTests.java
>
> Modified: ofbiz/trunk/applications/securityext/src/org/ofbiz/
> securityext/test/AuthorizationTests.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java?rev=769991&r1=769990&r2=769991&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/
> test/AuthorizationTests.java (original)
> +++ ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/
> test/AuthorizationTests.java Wed Apr 29 23:18:24 2009
> @@ -2,6 +2,7 @@
>
> import org.ofbiz.base.util.Debug;
> import org.ofbiz.entity.GenericDelegator;
> +import org.ofbiz.security.SecurityConfigurationException;
> import org.ofbiz.security.authz.Authorization;
> import org.ofbiz.security.authz.AuthorizationFactory;
> import org.ofbiz.service.testtools.OFBizTestCase;
> @@ -12,7 +13,7 @@
>     protected GenericDelegator delegator;
>     protected Authorization security;
>
> -    public AuthorizationTests(String name) {
> +    public AuthorizationTests(String name) throws  
> SecurityConfigurationException {
>         super(name);
>         delegator = GenericDelegator.getGenericDelegator("default");
>         security = AuthorizationFactory.getInstance(delegator);
>
>

[Adrian Crum-2]

No problem. One thing I do is run ant clean then ant build before committing changes - just to make sure there are no problems.

-Adrian


--- On Wed, 4/29/09, Andrew Zeneski <[hidden email]> wrote:

> From: Andrew Zeneski <[hidden email]>
> Subject: Re: svn commit: r769991 - /ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
> To: [hidden email]
> Date: Wednesday, April 29, 2009, 6:51 PM
> Thanks Adrian,
>
> I had actually changed SecurityConfigurationException to
> extend GeneralRuntimeException instead of GeneralException,
> but that didn't get checked in.
>
> Andrew
>
> On Apr 29, 2009, at 7:18 PM, [hidden email] wrote:
>
> > Author: adrianc
> > Date: Wed Apr 29 23:18:24 2009
> > New Revision: 769991
> >
> > URL:
> http://svn.apache.org/viewvc?rev=769991&view=rev
> > Log:
> > Fixed a problem with the new auth code that was
> preventing compilation.
> >
> > Modified:
> >  
> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
> >
> > Modified:
> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java?rev=769991&r1=769990&r2=769991&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
> (original)
> > +++
> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
> Wed Apr 29 23:18:24 2009
> > @@ -2,6 +2,7 @@
> >
> > import org.ofbiz.base.util.Debug;
> > import org.ofbiz.entity.GenericDelegator;
> > +import
> org.ofbiz.security.SecurityConfigurationException;
> > import org.ofbiz.security.authz.Authorization;
> > import org.ofbiz.security.authz.AuthorizationFactory;
> > import org.ofbiz.service.testtools.OFBizTestCase;
> > @@ -12,7 +13,7 @@
> >     protected GenericDelegator delegator;
> >     protected Authorization security;
> >
> > -    public AuthorizationTests(String name) {
> > +    public AuthorizationTests(String name) throws
> SecurityConfigurationException {
> >         super(name);
> >         delegator =
> GenericDelegator.getGenericDelegator("default");
> >         security =
> AuthorizationFactory.getInstance(delegator);
> >
> >

     

[Andrew Zeneski-2]

What a wonderful idea... ;) Yeah of course I do that, in this case I  
just didn't check in the changes to the exception class. I have the  
old security deprecated locally and decided last minute to wait to  
check that in to prevent build warnings for now.

Andrew

On Apr 30, 2009, at 1:40 AM, Adrian Crum wrote:

>
> No problem. One thing I do is run ant clean then ant build before  
> committing changes - just to make sure there are no problems.
>
> -Adrian
>
>
> --- On Wed, 4/29/09, Andrew Zeneski <[hidden email]>  
> wrote:
>
>> From: Andrew Zeneski <[hidden email]>
>> Subject: Re: svn commit: r769991 - /ofbiz/trunk/applications/
>> securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java
>> To: [hidden email]
>> Date: Wednesday, April 29, 2009, 6:51 PM
>> Thanks Adrian,
>>
>> I had actually changed SecurityConfigurationException to
>> extend GeneralRuntimeException instead of GeneralException,
>> but that didn't get checked in.
>>
>> Andrew
>>
>> On Apr 29, 2009, at 7:18 PM, [hidden email] wrote:
>>
>>> Author: adrianc
>>> Date: Wed Apr 29 23:18:24 2009
>>> New Revision: 769991
>>>
>>> URL:
>> http://svn.apache.org/viewvc?rev=769991&view=rev
>>> Log:
>>> Fixed a problem with the new auth code that was
>> preventing compilation.
>>>
>>> Modified:
>>>
>> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/
>> AuthorizationTests.java
>>>
>>> Modified:
>> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/
>> AuthorizationTests.java
>>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/AuthorizationTests.java?rev=769991&r1=769990&r2=769991&view=diff
>>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>>> ---
>> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/
>> AuthorizationTests.java
>> (original)
>>> +++
>> ofbiz/trunk/applications/securityext/src/org/ofbiz/securityext/test/
>> AuthorizationTests.java
>> Wed Apr 29 23:18:24 2009
>>> @@ -2,6 +2,7 @@
>>>
>>> import org.ofbiz.base.util.Debug;
>>> import org.ofbiz.entity.GenericDelegator;
>>> +import
>> org.ofbiz.security.SecurityConfigurationException;
>>> import org.ofbiz.security.authz.Authorization;
>>> import org.ofbiz.security.authz.AuthorizationFactory;
>>> import org.ofbiz.service.testtools.OFBizTestCase;
>>> @@ -12,7 +13,7 @@
>>>    protected GenericDelegator delegator;
>>>    protected Authorization security;
>>>
>>> -    public AuthorizationTests(String name) {
>>> +    public AuthorizationTests(String name) throws
>> SecurityConfigurationException {
>>>        super(name);
>>>        delegator =
>> GenericDelegator.getGenericDelegator("default");
>>>        security =
>> AuthorizationFactory.getInstance(delegator);
>>>
>>>
>
>
>