Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
Locked
Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
 
|
Hi Hans,
Thanks for doing this. Btw, All the files under framework/resources/ templates does not contains any license header. I think this is again done on purpose. You might be interested in looking at the original jira issue for this work at https://issues.apache.org/jira/browse/OFBIZ-2169 but this particular issue is not discussed in depth. Hopefully, Jacopo could comment better when he see this message. Vikas On May 4, 2009, at 2:46 PM, [hidden email] wrote: > Author: hansbak > Date: Mon May 4 09:16:38 2009 > New Revision: 771252 > > URL: http://svn.apache.org/viewvc?rev=771252&view=rev > Log: > empty template file put back, and added message and header, thanks > Vikas for reporting > > Added: > ofbiz/trunk/framework/resources/templates/Forms.xml > - copied, changed from r771034, ofbiz/trunk/framework/resources/ > templates/Forms.xml > > Copied: ofbiz/trunk/framework/resources/templates/Forms.xml (from > r771034, ofbiz/trunk/framework/resources/templates/Forms.xml) > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/resources/templates/Forms.xml?p2=ofbiz/trunk/framework/resources/templates/Forms.xml&p1=ofbiz/trunk/framework/resources/templates/Forms.xml&r1=771034&r2=771252&rev=771252&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/framework/resources/templates/Forms.xml (original) > +++ ofbiz/trunk/framework/resources/templates/Forms.xml Mon May 4 > 09:16:38 2009 > @@ -1,5 +1,26 @@ > <?xml version="1.0" encoding="UTF-8"?> > +<!-- > + Licensed to the Apache Software Foundation (ASF) under one > + or more contributor license agreements. See the NOTICE file > + distributed with this work for additional information > + regarding copyright ownership. The ASF licenses this file > + to you under the Apache License, Version 2.0 (the > + "License"); you may not use this file except in compliance > + with the License. You may obtain a copy of the License at > + > + http://www.apache.org/licenses/LICENSE-2.0 > + > + Unless required by applicable law or agreed to in writing, > + software distributed under the License is distributed on an > + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > + KIND, either express or implied. See the License for the > + specific language governing permissions and limitations > + under the License. > +--> > + > <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd > "> > > + <!-- this file is intentionally empty and is used in the > build.xml file in the ofbiz root directory --> > + > </forms> > > |
smime.p7s (3K)
Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
|
Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
|
|
I don't think a license header is required on a file that contains
virtually nothing, also the message you've added would only serve to confuse any newcomers who make use of the tool. A readme file in the directory might be better. Regards Scott On 4/05/2009, at 9:54 PM, Hans Bakker wrote: > I think these files are pretty questionable: it fails xml validation, > have no headers and no message, this this intended..... > > On Mon, 2009-05-04 at 15:13 +0530, Vikas Mayur wrote: >> Hi Hans, >> >> Thanks for doing this. Btw, All the files under framework/resources/ >> templates does not contains any license header. I think this is again >> done on purpose. You might be interested in looking at the original >> jira issue for this work at https://issues.apache.org/jira/browse/OFBIZ-2169 >> but this particular issue is not discussed in depth. >> >> Hopefully, Jacopo could comment better when he see this message. >> >> Vikas >> >> On May 4, 2009, at 2:46 PM, [hidden email] wrote: >> >>> Author: hansbak >>> Date: Mon May 4 09:16:38 2009 >>> New Revision: 771252 >>> >>> URL: http://svn.apache.org/viewvc?rev=771252&view=rev >>> Log: >>> empty template file put back, and added message and header, thanks >>> Vikas for reporting >>> >>> Added: >>> ofbiz/trunk/framework/resources/templates/Forms.xml >>> - copied, changed from r771034, ofbiz/trunk/framework/resources/ >>> templates/Forms.xml >>> >>> Copied: ofbiz/trunk/framework/resources/templates/Forms.xml (from >>> r771034, ofbiz/trunk/framework/resources/templates/Forms.xml) >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/resources/templates/Forms.xml?p2=ofbiz/trunk/framework/resources/templates/Forms.xml&p1=ofbiz/trunk/framework/resources/templates/Forms.xml&r1=771034&r2=771252&rev=771252&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/framework/resources/templates/Forms.xml (original) >>> +++ ofbiz/trunk/framework/resources/templates/Forms.xml Mon May 4 >>> 09:16:38 2009 >>> @@ -1,5 +1,26 @@ >>> <?xml version="1.0" encoding="UTF-8"?> >>> +<!-- >>> + Licensed to the Apache Software Foundation (ASF) under one >>> + or more contributor license agreements. See the NOTICE >>> file >>> + distributed with this work for additional information >>> + regarding copyright ownership. The ASF licenses this file >>> + to you under the Apache License, Version 2.0 (the >>> + "License"); you may not use this file except in compliance >>> + with the License. You may obtain a copy of the License at >>> + >>> + http://www.apache.org/licenses/LICENSE-2.0 >>> + >>> + Unless required by applicable law or agreed to in writing, >>> + software distributed under the License is distributed on an >>> + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> + KIND, either express or implied. See the License for the >>> + specific language governing permissions and limitations >>> + under the License. >>> +--> >>> + >>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>> "> >>> >>> + <!-- this file is intentionally empty and is used in the >>> build.xml file in the ofbiz root directory --> >>> + >>> </forms> >>> >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
|
|
In reply to this post by hans_bakker
Oh about the xml validation error, I've noticed that before as well
and I wonder if we shouldn't just alter the xsds to allow 0 or more forms, screens, services or whatever instead of 1 or more. I mean it doesn't really cause any harm having an empty file does it? We could just log a warning if when the system tries to load from those files (maybe it already does). Regards Scott On 4/05/2009, at 9:54 PM, Hans Bakker wrote: > I think these files are pretty questionable: it fails xml validation, > have no headers and no message, this this intended..... > > On Mon, 2009-05-04 at 15:13 +0530, Vikas Mayur wrote: >> Hi Hans, >> >> Thanks for doing this. Btw, All the files under framework/resources/ >> templates does not contains any license header. I think this is again >> done on purpose. You might be interested in looking at the original >> jira issue for this work at https://issues.apache.org/jira/browse/OFBIZ-2169 >> but this particular issue is not discussed in depth. >> >> Hopefully, Jacopo could comment better when he see this message. >> >> Vikas >> >> On May 4, 2009, at 2:46 PM, [hidden email] wrote: >> >>> Author: hansbak >>> Date: Mon May 4 09:16:38 2009 >>> New Revision: 771252 >>> >>> URL: http://svn.apache.org/viewvc?rev=771252&view=rev >>> Log: >>> empty template file put back, and added message and header, thanks >>> Vikas for reporting >>> >>> Added: >>> ofbiz/trunk/framework/resources/templates/Forms.xml >>> - copied, changed from r771034, ofbiz/trunk/framework/resources/ >>> templates/Forms.xml >>> >>> Copied: ofbiz/trunk/framework/resources/templates/Forms.xml (from >>> r771034, ofbiz/trunk/framework/resources/templates/Forms.xml) >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/resources/templates/Forms.xml?p2=ofbiz/trunk/framework/resources/templates/Forms.xml&p1=ofbiz/trunk/framework/resources/templates/Forms.xml&r1=771034&r2=771252&rev=771252&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/framework/resources/templates/Forms.xml (original) >>> +++ ofbiz/trunk/framework/resources/templates/Forms.xml Mon May 4 >>> 09:16:38 2009 >>> @@ -1,5 +1,26 @@ >>> <?xml version="1.0" encoding="UTF-8"?> >>> +<!-- >>> + Licensed to the Apache Software Foundation (ASF) under one >>> + or more contributor license agreements. See the NOTICE >>> file >>> + distributed with this work for additional information >>> + regarding copyright ownership. The ASF licenses this file >>> + to you under the Apache License, Version 2.0 (the >>> + "License"); you may not use this file except in compliance >>> + with the License. You may obtain a copy of the License at >>> + >>> + http://www.apache.org/licenses/LICENSE-2.0 >>> + >>> + Unless required by applicable law or agreed to in writing, >>> + software distributed under the License is distributed on an >>> + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> + KIND, either express or implied. See the License for the >>> + specific language governing permissions and limitations >>> + under the License. >>> +--> >>> + >>> <forms xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd >>> "> >>> >>> + <!-- this file is intentionally empty and is used in the >>> build.xml file in the ofbiz root directory --> >>> + >>> </forms> >>> >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Re: svn commit: r771252 - /ofbiz/trunk/framework/resourc
|
|
+1 - Scott's comment for improving xsd to allow 0 or more instead of 1
or more. -- Ashish Scott Gray wrote: > Oh about the xml validation error, I've noticed that before as well > and I wonder if we shouldn't just alter the xsds to allow 0 or more > forms, screens, services or whatever instead of 1 or more. I mean it > doesn't really cause any harm having an empty file does it? We could > just log a warning if when the system tries to load from those files > (maybe it already does). > > Regards > Scott |
| Free forum by Nabble | Edit this page |