Re: svn commit: r773709 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string: UelFunctions.java UelUtil.java

[Scott Gray-2]

Hi Adrian,

Isn't it better performance wise if the most commonly used resolvers  
are at the top?

Regards
Scott

> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/
> UelUtil.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java?rev=773709&r1=773708&r2=773709&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/
> UelUtil.java (original)
> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/
> UelUtil.java Mon May 11 22:05:57 2009
> @@ -39,10 +39,10 @@
>     protected static final ExpressionFactory exprFactory =  
> JuelConnector.newExpressionFactory();
>     protected static final ELResolver defaultResolver = new  
> ExtendedCompositeResolver() {
>         {
> +            add(new NodeELResolver()); // Below the most common but  
> must be kept above BeanELResolver
>             add(new ExtendedMapResolver(false));
>             add(new ExtendedListResolver(false));
>             add(new ArrayELResolver(false));
> -            add(new NodeELResolver()); // Below the most common but  
> must be kept above BeanELResolver
>             add(new ResourceBundleELResolver());
>             add(new BeanELResolver(false));
>         }
>
>

[Adrian Crum]

The NodeELResolver wasn't effective lower in the list - probably because
of the auto-vivify implementation in the other resolvers. I'll look into
it more later.

-Adrian

Scott Gray wrote:

> Hi Adrian,
>
> Isn't it better performance wise if the most commonly used resolvers are
> at the top?
>
> Regards
> Scott
>
>> Modified:
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java?rev=773709&r1=773708&r2=773709&view=diff 
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java
>> (original)
>> +++
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java
>> Mon May 11 22:05:57 2009
>> @@ -39,10 +39,10 @@
>>     protected static final ExpressionFactory exprFactory =
>> JuelConnector.newExpressionFactory();
>>     protected static final ELResolver defaultResolver = new
>> ExtendedCompositeResolver() {
>>         {
>> +            add(new NodeELResolver()); // Below the most common but
>> must be kept above BeanELResolver
>>             add(new ExtendedMapResolver(false));
>>             add(new ExtendedListResolver(false));
>>             add(new ArrayELResolver(false));
>> -            add(new NodeELResolver()); // Below the most common but
>> must be kept above BeanELResolver
>>             add(new ResourceBundleELResolver());
>>             add(new BeanELResolver(false));
>>         }
>>
>>
>