Re: svn commit: r778548 - /ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java

[BJ Freeman]

Scott:
if I remember right, if a authorization is provided by the gateway, the
user has to call in and get the number if they did not get it back for
some reason. They are charged and so is the customer if they try to
re-authorize.

or am I missing something.

[hidden email] sent the following on 5/25/2009 6:46 PM:

> Author: lektran
> Date: Tue May 26 01:46:03 2009
> New Revision: 778548
>
> URL: http://svn.apache.org/viewvc?rev=778548&view=rev
> Log:
> Set authRefNum earlier so that it can be overwritten if there is a communication failure
>
> Modified:
>     ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
>
> Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java?rev=778548&r1=778547&r2=778548&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java (original)
> +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java Tue May 26 01:46:03 2009
> @@ -400,6 +400,7 @@
>              Debug.logError(e, "Unable to parse response code; not a number!", module);
>          }
>  
> +        result.put("authRefNum", parameters.get("PNREF"));
>          if (codeInt == 0 && avsCheckOkay && cvv2CheckOkay) {
>              result.put("authResult", Boolean.TRUE);
>              result.put("authCode", parameters.get("AUTHCODE"));
> @@ -426,7 +427,6 @@
>          }
>          result.put("cvCode", cvvCode);
>          result.put("avsCode", avsCode);
> -        result.put("authRefNum", parameters.get("PNREF"));
>          result.put("authFlag", parameters.get("RESULT"));
>          result.put("authMessage", parameters.get("RESPMSG"));
>      }
>
>
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Scott Gray-2]

I don't know if you're missing something because I'm not really sure  
what you're saying...

But anyway this commit had no affect whatsoever on the authRefNum  
being stored, I was merely fixing a bug where upon a communication  
failure during auth the code was trying to store the result code in  
the authRefNum field but it was subsequently being overwritten in the  
result map by the value of PNREF, whose value was null anyway because  
of the communication failure.  Sorry for the long sentence but hope it  
clarifies the commit for you somewhat.

Regards
Scott

On 26/05/2009, at 2:12 PM, BJ Freeman wrote:

> Scott:
> if I remember right, if a authorization is provided by the gateway,  
> the
> user has to call in and get the number if they did not get it back for
> some reason. They are charged and so is the customer if they try to
> re-authorize.
>
> or am I missing something.
>
> [hidden email] sent the following on 5/25/2009 6:46 PM:
>> Author: lektran
>> Date: Tue May 26 01:46:03 2009
>> New Revision: 778548
>>
>> URL: http://svn.apache.org/viewvc?rev=778548&view=rev
>> Log:
>> Set authRefNum earlier so that it can be overwritten if there is a  
>> communication failure
>>
>> Modified:
>>    ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
>> thirdparty/verisign/PayflowPro.java
>>
>> Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/
>> accounting/thirdparty/verisign/PayflowPro.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java?rev=778548&r1=778547&r2=778548&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
>> thirdparty/verisign/PayflowPro.java (original)
>> +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
>> thirdparty/verisign/PayflowPro.java Tue May 26 01:46:03 2009
>> @@ -400,6 +400,7 @@
>>             Debug.logError(e, "Unable to parse response code; not a  
>> number!", module);
>>         }
>>
>> +        result.put("authRefNum", parameters.get("PNREF"));
>>         if (codeInt == 0 && avsCheckOkay && cvv2CheckOkay) {
>>             result.put("authResult", Boolean.TRUE);
>>             result.put("authCode", parameters.get("AUTHCODE"));
>> @@ -426,7 +427,6 @@
>>         }
>>         result.put("cvCode", cvvCode);
>>         result.put("avsCode", avsCode);
>> -        result.put("authRefNum", parameters.get("PNREF"));
>>         result.put("authFlag", parameters.get("RESULT"));
>>         result.put("authMessage", parameters.get("RESPMSG"));
>>     }
>>
>>
>>
>
> --
> BJ Freeman
> http://www.businessesnetwork.com/automation
> http://bjfreeman.elance.com
> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
> Systems Integrator.
>